Bug 2154124 - Review Request: rust-noisy_float - Rust library containing floating point types
Summary: Review Request: rust-noisy_float - Rust library containing floating point types
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2022-12-15 22:19 UTC by blinxen
Modified: 2023-02-01 10:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2023-02-01 10:24:04 UTC
Type: ---
manisandro: fedora-review+

Attachments (Terms of Use)
The .spec file difference from Copr build 5353619 to 5355019 (778 bytes, patch)
2023-01-29 16:27 UTC, Jakub Kadlčík
no flags Details | Diff

Description blinxen 2022-12-15 22:19:06 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/blinxen/rust-noisy_float/fedora-37-x86_64/05147450-rust-noisy_float/rust-noisy_float.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/blinxen/rust-noisy_float/fedora-37-x86_64/05147450-rust-noisy_float/rust-noisy_float-0.2.0-1.fc37.src.rpm
Description: This crate contains floating point types that panic if they are set to an illegal value, such as NaN.
Fedora Account System Username: blinxen

This package is only a dependency for https://github.com/ImageOptim/libimagequant, which I am trying to build.
As this is my first package in Fedora, I require a sponsor.

Here is the successful copr build: https://copr.fedorainfracloud.org/coprs/blinxen/rust-noisy_float/build/5147450/ 

I am not sure if this is needed, but here is the rpmlint output:

> rpmlint rust-noisy_float-0.2.0-1.fc37.src.rpm
============================================================================================================ rpmlint session starts ===========================================================================================================
rpmlint: 2.4.0
checks: 31, packages: 1

============================================================================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s ============================================================================

Comment 1 blinxen 2023-01-23 20:44:02 UTC
As of now, I no longer need a sponsor. Also the spec file was generated with `rust2rpm`, so the review should be quite simple.

Comment 2 blinxen 2023-01-29 12:44:10 UTC
The build in rawhide is failing because a `dev-dependency` (rust-criterion) is missing.
`criterion` is only used for benchmarking so I just removed it from `Cargo.toml`.

Here is the new spec file and the corresponding SRPM:

New spec file: https://download.copr.fedorainfracloud.org/results/blinxen/rust-noisy_float/fedora-37-x86_64/05353613-rust-noisy_float/rust-noisy_float.spec
New SRPM: https://download.copr.fedorainfracloud.org/results/blinxen/rust-noisy_float/fedora-37-x86_64/05353613-rust-noisy_float/rust-noisy_float-0.2.0-1.fc37.src.rpm

Comment 4 Sandro Mani 2023-01-29 13:31:46 UTC
There is a broken install dependency:

 Problem: conflicting requests
  - nothing provides (crate(approx/default) >= 0.4.0 with crate(approx/default) < 0.5.0~) needed by rust-noisy_float+approx-devel-0.2.0-1.fc38.noarch

Comment 6 Jakub Kadlčík 2023-01-29 16:27:26 UTC
Created attachment 1940993 [details]
The .spec file difference from Copr build 5353619 to 5355019

Comment 8 Sandro Mani 2023-01-29 17:06:07 UTC
Looks good to me, approved!

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  See: https://docs.fedoraproject.org/en-US/packaging-

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "Apache License 2.0". 4 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Spec file according to URL is the same as in SRPM.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: rust-noisy_float-devel-0.2.0-1.fc38.noarch.rpm
======================================================================================= rpmlint session starts ======================================================================================
rpmlint: 2.4.0
rpmlintrc: [PosixPath('/tmp/tmpelwlo6d9')]
checks: 31, packages: 5

rust-noisy_float+approx-devel.noarch: W: no-documentation
rust-noisy_float+default-devel.noarch: W: no-documentation
rust-noisy_float+serde-devel.noarch: W: no-documentation
======================================================== 5 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.4 s =======================================================

Rpmlint (installed packages)
============================ rpmlint session starts ============================
rpmlint: 2.4.0
checks: 31, packages: 4

rust-noisy_float+default-devel.noarch: W: no-documentation
rust-noisy_float+approx-devel.noarch: W: no-documentation
rust-noisy_float+serde-devel.noarch: W: no-documentation
 4 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.0 s 

Source checksums
https://crates.io/api/v1/crates/noisy_float/0.2.0/download#/noisy_float-0.2.0.crate :
  CHECKSUM(SHA256) this package     : 1e7b02ec475e966206b5d1385cabf72e4cfa7ef643cc704ddca4e6bdb5000d7a
  CHECKSUM(SHA256) upstream package : 978fe6e6ebc0bf53de533cd456ca2d9de13de13856eda1518a285d7705a213af
However, diff -r shows no differences

rust-noisy_float-devel (rpmlib, GLIBC filtered):
    (crate(num-traits/default) >= 0.2.0 with crate(num-traits/default) < 0.3.0~)

rust-noisy_float+default-devel (rpmlib, GLIBC filtered):

rust-noisy_float+approx-devel (rpmlib, GLIBC filtered):
    (crate(approx/default) >= 0.5.0 with crate(approx/default) < 0.6.0~)

rust-noisy_float+serde-devel (rpmlib, GLIBC filtered):
    (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~)





Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2154124
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: C/C++, PHP, Python, Haskell, SugarActivity, fonts, R, Perl, Ocaml, Java

Comment 9 Fedora Admin user for bugzilla script actions 2023-01-29 18:28:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-noisy_float

Note You need to log in before you can comment on or make changes to this bug.