RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2154288 - Unit test failure "nm:ERROR:../src/libnm-client-impl/tests/test-nm-client.c:877:_client_dev_removed: assertion failed (arr->len == 0): (1 == 0)"
Summary: Unit test failure "nm:ERROR:../src/libnm-client-impl/tests/test-nm-client.c:8...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: NetworkManager
Version: 9.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Thomas Haller
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-16 14:05 UTC by Thomas Haller
Modified: 2023-02-08 10:10 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-08 10:04:18 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker NMT-112 0 None None None 2023-01-22 14:16:11 UTC
Red Hat Issue Tracker RHELPLAN-142722 0 None None None 2023-02-07 12:23:33 UTC
freedesktop.org Gitlab NetworkManager NetworkManager merge_requests 1528 0 None opened [th/test-client-fixes] fix test_monitor() unit test in "test-client.py" 2023-02-07 12:22:44 UTC

Description Thomas Haller 2022-12-16 14:05:40 UTC 
when you run unit tests in gitlab-ci, it's relatively easy to get a failure (feels like 1 out of 80 builds). If you then manually run the pipelines for all distros, you have a relatively high probability to encounter the race. (retry, if you don't).

See for example: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/jobs/33621885

I think this started with https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/8dc4b4701be87eeb9abf7f61de075d728a401b77



I think https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/8dc4b4701be87eeb9abf7f61de075d728a401b77 also introduced a second race in the unit tests. That one is harder to hit. They might be related. See for example:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/jobs/33527162#L5315

ERROR: test_monitor (__main__.TestNmcli.test_monitor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builds/NetworkManager/NetworkManager/src/tests/client/test-client.py", line 1226, in f
    func(self)
  File "/builds/NetworkManager/NetworkManager/src/tests/client/test-client.py", line 1233, in f
    func(self)
  File "/builds/NetworkManager/NetworkManager/src/tests/client/test-client.py", line 1917, in test_monitor
    nmc.expect("con-1: connection profile removed")
  File "/usr/lib/python3.11/site-packages/pexpect/spawnbase.py", line 343, in expect
    return self.expect_list(compiled_pattern_list,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/pexpect/spawnbase.py", line 372, in expect_list
    return exp.expect_loop(timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/pexpect/expect.py", line 181, in expect_loop
    return self.timeout(e)
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/pexpect/expect.py", line 144, in timeout
    raise exc
pexpect.exceptions.TIMEOUT: Timeout exceeded.
Comment 1 Thomas Haller 2023-02-08 09:56:19 UTC 
fixed by https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/df228a5f8d4de60951fe689950f016896b5dc383
Comment 2 Thomas Haller 2023-02-08 10:04:18 UTC 
closing this one as UPSTREAM.

This bug was about a unit test failure. That unit test failure was in upstream (but arguably also in our RHEL package builds).
Still, it's fixed now, the test is re-enabled and there is no further QA necessary.

(the QA for a unit test is just letting the unit test run -- which it does now all the time, and we will notice when it starts failing again).
Comment 3 Thomas Haller 2023-02-08 10:10:15 UTC 
btw, in comment 0, we were talking about two unit test failures.

1)
  "nm:ERROR:../src/libnm-client-impl/tests/test-nm-client.c:877:_client_dev_removed: assertion failed (arr->len == 0): (1 == 0)" (edit)
  fixed by https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/c1d234ce30a301ae9af2462343edf03431608e43

2)
  ERROR: test_monitor (__main__.TestNmcli.test_monitor)
  fixed by https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/df228a5f8d4de60951fe689950f016896b5dc383

(both are fixed, and both tests are running (on upstream `main` and `nm-1-42` branches)
Note You need to log in before you can comment on or make changes to this bug.