Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2154339

Summary: If setting a state with full options of a bridge failed, the bridge would be removed
Product: Red Hat Enterprise Linux 9 Reporter: Mingyu Shi <mshi>
Component: nmstateAssignee: Gris Ge <fge>
Status: CLOSED CURRENTRELEASE QA Contact: Mingyu Shi <mshi>
Severity: high Docs Contact:
Priority: medium    
Version: 9.2CC: ferferna, jiji, jishi, network-qe, sfaye, till
Target Milestone: rcKeywords: Regression, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-11 14:13:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2144442    
Attachments:
Description Flags
NMtrace.log none

Description Mingyu Shi 2022-12-16 15:41:43 UTC
Created attachment 1933113 [details]
NMtrace.log

Description of problem:
When applying a state contains full options of bridge, if it fails(such as invalid value), then the bridge would be removed unexpectedly.

Version-Release number of selected component (if applicable):
nmstate-2.2.2-2.el9.x86_64
NetworkManager-1.41.6-1.el9.x86_64
Linux kvm-04-guest30.hv2.lab.eng.bos.redhat.com 5.14.0-212.el9.x86_64 #1 SMP PREEMPT_DYNAMIC Tue Dec 13 17:09:01 EST 2022 x86_64 x86_64 x86_64 GNU/Linux
DISTRO=RHEL-9.2.0-20221215.0

How reproducible:
100%

Steps to Reproduce:
cat << EOF > simple_br.yaml
interfaces:
- name: br_test
  type: linux-bridge
  description: br_test
  state: up
  mac-address: AA:CF:A8:2D:6A:48
EOF
nmstatectl apply simple_br.yaml
# use `nmstatectl show br_test` to get and apply a FULL bridge state, otherwise it may not be reproducible 
nmstatectl show br_test | sed 's/mac-address: AA:CF:A8:2D:6A:48/mac-address: error/' | nmstatectl apply
# after failure, check
ip link show br_test

Actual results:
Device "br_test" does not exist.

Expected results:
br_test rollbacked to initial state

Additional info:

Comment 1 Mingyu Shi 2022-12-19 08:31:28 UTC
It also happens in other interface

For example, setting a dummy mtu to 0, apply and fail as expect, then the dummy interface would be removed without notice.

Comment 2 Fernando F. Mancera 2023-01-10 17:10:58 UTC
Hi Mingyu, I was not able to reproduce this problem.

I used upstream build of NetworkManager and the same Nmstate version that you specified. Could you share also Nmstate logs? These are my results:

[root@f48e458b3dae nmstate-workspace]# NetworkManager --version
1.41.7-31573.copr.4509c303fa.el8
[root@f48e458b3dae nmstate-workspace]# nmstatectl apply simple_br.yaml
dns-resolver: {}
route-rules: {}
routes: {}
interfaces:
- name: br_test
  type: linux-bridge
  description: br_test
  state: up
  mac-address: AA:CF:A8:2D:6A:48
ovs-db: {}

[root@f48e458b3dae nmstate-workspace]# nmstatectl show br_test | sed 's/mac-address: AA:CF:A8:2D:6A:48/mac-address: error/' | nmstatectl apply
(omitted logs)
[2023-01-10T17:08:35Z ERROR nmstate::nm::nm_dbus::convert] Failed to convert to MAC address to bytes "ERROR": invalid digit found in string
(omitted logs)
[2023-01-10T17:08:45Z INFO  nmstate::query_apply::net_state] Rollbacked to checkpoint /org/freedesktop/NetworkManager/Checkpoint/3

[root@f48e458b3dae nmstate-workspace]# ip link show br_test
10: br_test: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
    link/ether aa:cf:a8:2d:6a:48 brd ff:ff:ff:ff:ff:ff

Could you retry it with latest Nmstate version and NetworkManager from this copr repository? https://copr.fedorainfracloud.org/coprs/networkmanager/NetworkManager-main-debug/builds/

Thanks!

Comment 3 Mingyu Shi 2023-01-11 14:03:00 UTC
I confirm it now works well with:
nmstate-2.2.3-2.el9.x86_64
nispor-1.2.9-1.el9.x86_64
NetworkManager-1.41.7-2.el9.x86_64