Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/netcdf-decoders.spec SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/netcdf-decoders-4.1.4-1.fc6.src.rpm Description: The NetCDF Decoders package converts WMO GRIB products and textual bulletins into NetCDF formatted files. This package usually works in conjunction with the LDM package to covert incoming products to the NetCDF format without the need to store the raw data. The gribtonc decoder converts most models in the GRIB format. There are perl decoders for the following textual report types: METAR, buoy, upper air, and synoptic products. This package requires the installation of NetCDF, UDUNITS, and the Perl-NetCDF packages to work.
God: + Rpmlint doesn't complaints source package. + Local build works fine. + rpmlint doesn't complaints binary package. + Mock build works fine. + Tarbar in source RPM matches with upstream. + RPM contains verbatin copy of the license text. + License text seem to be ok for free software Bad: - Can't install becouse perlNetCDF) is required.
> Bad: > - Can't install becouse perlNetCDF) is required. perl(NetCDF) is under review in bug 215444, which this depends on. Thanks!
Jochen - do you still want to review? perl(NetCDF) is now available.
Good: + Tarball in source RPM match with upstream. + rpmlint is quite on source rpm. + Local build works fine. + rpmlint is quite on binary rpm. + Local install and uninstalling works fine. Bad: - The %makeinstall macro should not be used (wiki: PackagingGuidelines#MakeInstall) Sorry, I have to interupt, becouse I have a install problem with mock on my new machine.
(In reply to comment #4) > Bad: > - The %makeinstall macro should not be used > (wiki: PackagingGuidelines#MakeInstall) The makefiles do not support DESTDIR, and I really don't want to patch them to do so.
I will cite: Why the %makeinstall macro should not be used Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} will work. %makeinstall is a kludge that can work with Makefiles that don't make use of the DESTDIR variable but it has the following potential issues: * %makeinstall overrides a set of environment variables during "make install". I.e. it performs make prefix="..." includedir="..." ... * It is error prone, and can have unexpected effects when run against less than perfect Makefiles. * It can trigger unnecessary rebuilds when executing "make install" * If a package contains libtool archives, it can cause broken *.la files to be installed. Instead, Fedora packages should use: make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT install Thsi is a list of reasons why %Makeinstall should not used. Sory for any inconviniences.
At last I have a positiv message for you. I have solve my moch issue and can report a positve build of your package on mock. Best Regards: Jochen Schmitt
(In reply to comment #6) > I will cite: > > Why the %makeinstall macro should not be used > > Fedora's RPM includes a %makeinstall macro but it must NOT be used when make > install DESTDIR=%{buildroot} will work. ^^^^^^^^^ And I say again, DESTDIR does NOT work with this package, and %makeinstall does. If someone can show me a clean way to add DESTDIR support, that would be nice. But the configure system used in this package is very outdated and I don't think it's work spending time on it when a reasonable work around is available.
Sorry, You are right. I wil APPROVE you package.
Thanks. Checked it and built. Added to owners.list. Requesting branches...