Bug 2155090 - cython-mode.el:109:1: Compiler warning
Summary: cython-mode.el:109:1: Compiler warning
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Cython
Version: 37
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-19 23:22 UTC by Edgar Hoch
Modified: 2022-12-29 01:09 UTC (History)
5 users (show)

Fixed In Version: Cython-0.29.32-2.fc38 Cython-0.29.32-2.fc37
Clone Of:
Environment:
Last Closed: 2022-12-29 01:09:55 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github cython emacs-cython-mode pull 1 0 None open Wrap the docstring of cython-default-compile-format to 80 characters 2022-12-20 00:09:51 UTC

Description Edgar Hoch 2022-12-19 23:22:44 UTC
Description of problem:

When I start Emacs on Fedora 37 for the first time, I got the following  compiler warning:

Warning (comp): cython-mode.el:109:1: Warning: custom-declare-variable `cython-default-compile-format' docstring wider than 80 characters Disable showing Disable logging


Version-Release number of selected component (if applicable):
emacs-28.1-3.fc37.x86_64
emacs-cython-mode-0.29.32-1.fc37.noarch


How reproducible:
First start of Emacs on Fedora 37.

Steps to Reproduce:
1. Check in ~/.emacs.d/eln-cache/ exists. Delete (or rename) it
   to simulate a fresh, first start of Emacs on this Fedora version.
2. Start Emacs
3. Read the Warning buffer

Comment 1 Miro Hrončok 2022-12-19 23:33:49 UTC
As a maintainer of cython, I unfortunatelly have no understanding of emacs.

Upstream has removed the emacs file https://github.com/cython/cython/commit/07ca6c336b497a9fa0579183f875e48dd3da82d7


Do you know what to do to fix this?

Comment 2 Miro Hrončok 2022-12-19 23:35:03 UTC
I see:

;;;###autoload
(defcustom cython-default-compile-format "cython -a %s"
  "Format for the default command to compile a Cython file.
It will be passed to `format' with `buffer-file-name' as the only other argument."
  :group 'cython
  :type 'string)


Do I change that so it wraps into 80 characters?

Comment 3 Edgar Hoch 2022-12-19 23:40:17 UTC
Yes, I think changing the docstring lines so that the fit below (or equal?) 80 characters will remove the warning.
Thanks!

Comment 4 Miro Hrončok 2022-12-20 00:09:52 UTC
Upstream PR: https://github.com/cython/emacs-cython-mode/pull/1

Comment 5 Miro Hrončok 2022-12-20 00:15:56 UTC
Fedora PRs:

Rawhide: https://src.fedoraproject.org/rpms/Cython/pull-request/37
Fedora 38: https://src.fedoraproject.org/rpms/Cython/pull-request/38

Will you be able to test the scratch build that is produced by the CI? I can post a link once it is ready.

Comment 6 Edgar Hoch 2022-12-20 00:19:39 UTC
(In reply to Miro Hrončok from comment #5)
> Will you be able to test the scratch build that is produced by the CI? I can
> post a link once it is ready.

Yes, I can do it.

Comment 8 Edgar Hoch 2022-12-20 00:43:35 UTC
Yes, the update fixes the problem, no warning about this emacs files occurs.

Thanks for the fast solution!

Comment 9 Fedora Update System 2022-12-20 11:05:44 UTC
FEDORA-2022-bc122c5ec6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc122c5ec6

Comment 10 Fedora Update System 2022-12-20 11:07:36 UTC
FEDORA-2022-bc122c5ec6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-12-20 12:04:42 UTC
FEDORA-2022-9801dd34a1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9801dd34a1

Comment 12 Fedora Update System 2022-12-21 02:36:22 UTC
FEDORA-2022-9801dd34a1 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-9801dd34a1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9801dd34a1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-12-29 01:09:55 UTC
FEDORA-2022-9801dd34a1 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.