Spec URL: https://pnemade.fedorapeople.org/last-resort-fonts.spec SRPM URL: https://pnemade.fedorapeople.org/last-resort-fonts-15.0.0-1.src.rpm Description: Last Resort is a special-purpose font that includes a collection of glyphs to represent types of Unicode characters. These glyphs are specifically designed to allow users to recognize that a code point is one of the following: – In which particular block a Unicode character is encoded – In the PUA (Private Use Area) for which no agreement exists – Unassigned (reserved for future assignment) – A noncharacter Fedora Account System Username: pnemade
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=95556548
No dist tag in Release.
sorry missed it here is updated package Spec URL: https://pnemade.fedorapeople.org/last-resort-fonts.spec SRPM URL: https://pnemade.fedorapeople.org/last-resort-fonts-15.0.0-1.fc37.src.rpm
Maybe good to ask upstream for including the license file into the archive. also, not a big deal but should we use 15.000 as a version because upstream seemed shipping 13.001 as an errata of Unicode 13.0.0? otherwise that looks good to me. approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: last-resort-fonts-15.0.0-1.fc38.noarch.rpm last-resort-fonts-15.0.0-1.fc38.src.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppxrxw_3z')] checks: 31, packages: 2 last-resort-fonts.noarch: W: no-documentation ========== 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s ========= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 last-resort-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://raw.githubusercontent.com/unicode-org/last-resort-font/main/LICENSE.md : CHECKSUM(SHA256) this package : 6a73f9541c2de74158c0e7cf6b0a58ef774f5a780bf191f2d7ec9cc53efe2bf2 CHECKSUM(SHA256) upstream package : 6a73f9541c2de74158c0e7cf6b0a58ef774f5a780bf191f2d7ec9cc53efe2bf2 https://github.com/unicode-org/last-resort-font/releases/download/15.000/LastResort-Regular.ttf : CHECKSUM(SHA256) this package : b5a6cbd70646342aca928c619d544e2c844d73ba346db256b421ebaac02c5fd1 CHECKSUM(SHA256) upstream package : b5a6cbd70646342aca928c619d544e2c844d73ba346db256b421ebaac02c5fd1 Requires -------- last-resort-fonts (rpmlib, GLIBC filtered): fontpackages-filesystem Provides -------- last-resort-fonts: font(lastresort) last-resort-fonts metainfo() metainfo(org.fedoraproject.last-resort-fonts.metainfo.xml) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2155117 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, fonts Disabled plugins: Python, Haskell, Ocaml, R, SugarActivity, PHP, Java, Perl, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thank you for this package review. Here is updated package keeping same changelog Spec URL: https://pnemade.fedorapeople.org/last-resort-fonts.spec SRPM URL: https://pnemade.fedorapeople.org/last-resort-fonts-15.000-1.fc37.src.rpm I will import this srpm as initial srpm.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/last-resort-fonts