Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/05157549-opentyrian/opentyrian.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/05157549-opentyrian/opentyrian-2.1.20221123-1.fc38.src.rpm Description: OpenTyrian is an open-source port of the DOS game Tyrian. Tyrian is an arcade-style vertical scrolling shooter. The story is set in 20,031 where you play as Trent Hawkins, a skilled fighter-pilot employed to fight MicroSol and save the galaxy. Tyrian features a story mode, one- and two-player arcade modes, and networked multiplayer. Fedora Account System Username: atim
Hi. I'm packaging this for Debian, I'd be happy to review your work here. This look fine so far. Debian considered the game data as non-free so it rely instead on game-data-packager to get the assets.
/usr/share/tyrian/dpmi16bi.ovl is a DOS code object (like a .so) and should be dropped from opentyrian-data
The original /usr/share/licenses/opentyrian/license.doc is obsolete and should be removed. > 2. Copying Prohibited. Except as authorized under this paragraph, NO > COPIES OF THE GAME OR ANY PORTIONS THEREOF MAY BE MADE BY YOU OR ANY > PERSON UNDER YOUR AUTHORITY OR CONTROL. The new "disclaimer": https://github.com/opentyrian/opentyrian == Additional Necessary Files ================================================== Tyrian 2.1 data files which have been released as freeware: https://camanis.net/tyrian/tyrian21.zip
You could just copy this and be done with it https://sources.debian.org/src/game-data-packager/69/data/tyrian.yaml/#L14 https://web.archive.org/web/20130603080919/https://worldtreegames.webs.com/ --------------------------------------------------------------------- Tyrian was released as Freeware in 2004. From http://www.freewebs.com/worldtreegames/ : > Feel free to play it all you want and share it with friends, but for > the moment I'd like to just have a central backup place (here) for > the game. In the future I might not mind other sites sharing it, > but I do enjoy amusing fans. :) From http://www.camanis.net/ : > Tyrian has been released as freeware by Jason Emery. These terms overide the one from the license.doc present in tyrian21.zip.
Thanks for review and help with packaging! New build: Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/05209352-opentyrian/opentyrian.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/05209352-opentyrian/opentyrian-2.1.20221123-1.fc38.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/5209363 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2155166-opentyrian/fedora-rawhide-x86_64/05209363-opentyrian/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Everything looks good to me. If the licensing of the _data_ does not match Fedora-legal rules, please resubmit package to RPMFusion (I'm there too) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "BSD 3-Clause License", "GNU Lesser General Public License v2.1 or later". 113 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/opentyrian/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opentyrian-data [x]: Package functions as described. [x]: Latest version is packaged. [?]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: opentyrian-2.1.20221123-1.fc38.x86_64.rpm opentyrian-data-2.1.20221123-1.fc38.noarch.rpm opentyrian-debuginfo-2.1.20221123-1.fc38.x86_64.rpm opentyrian-debugsource-2.1.20221123-1.fc38.x86_64.rpm opentyrian-2.1.20221123-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfugojxl1')] checks: 31, packages: 5 opentyrian-data.noarch: W: no-documentation opentyrian-data.noarch: W: files-duplicate /usr/share/tyrian/tyrset.pcx /usr/share/tyrian/netset.pcx 5 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: opentyrian-debuginfo-2.1.20221123-1.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzu9v6cbi')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 opentyrian-data.noarch: W: no-documentation opentyrian-data.noarch: W: files-duplicate /usr/share/tyrian/tyrset.pcx /usr/share/tyrian/netset.pcx 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.4 s Source checksums ---------------- https://raw.githubusercontent.com/flathub/com.github.opentyrian.OpenTyrian/master/opentyrian.appdata.xml : CHECKSUM(SHA256) this package : c76ce584f4a8cd00c521ea01c5ec8e6a96d856f633458e895aaf176f0dc8e5a7 CHECKSUM(SHA256) upstream package : c76ce584f4a8cd00c521ea01c5ec8e6a96d856f633458e895aaf176f0dc8e5a7 https://camanis.net/tyrian/tyrian21.zip : CHECKSUM(SHA256) this package : 7790d09a2a3addcd33c66ef063d5900eb81cc9c342f4807eb8356364dd1d9277 CHECKSUM(SHA256) upstream package : 7790d09a2a3addcd33c66ef063d5900eb81cc9c342f4807eb8356364dd1d9277 https://github.com/opentyrian/opentyrian/archive/v2.1.20221123/opentyrian-2.1.20221123.tar.gz : CHECKSUM(SHA256) this package : e0e8a8b0d61de10a3a65789ace9ea8e8c5d8dc67f3e423d2c852d64da38aeeb9 CHECKSUM(SHA256) upstream package : e0e8a8b0d61de10a3a65789ace9ea8e8c5d8dc67f3e423d2c852d64da38aeeb9 Requires -------- opentyrian (rpmlib, GLIBC filtered): hicolor-icon-theme libSDL2-2.0.so.0()(64bit) libSDL2_net-2.0.so.0()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) opentyrian-data rtld(GNU_HASH) opentyrian-data (rpmlib, GLIBC filtered): opentyrian opentyrian-debuginfo (rpmlib, GLIBC filtered): opentyrian-debugsource (rpmlib, GLIBC filtered): Provides -------- opentyrian: application() application(opentyrian.desktop) metainfo() metainfo(opentyrian.appdata.xml) opentyrian opentyrian(x86-64) opentyrian-data: opentyrian-data opentyrian-debuginfo: debuginfo(build-id) opentyrian-debuginfo opentyrian-debuginfo(x86-64) opentyrian-debugsource: opentyrian-debugsource opentyrian-debugsource(x86-64)
(In reply to Alexandre Detiste from comment #7) > If the licensing of the _data_ does not match Fedora-legal rules, > please resubmit package to RPMFusion (I'm there too) Thanks! Should we add FE-Legal here and wait for approval?
(In reply to Artem from comment #8) > (In reply to Alexandre Detiste from comment #7) > > > If the licensing of the _data_ does not match Fedora-legal rules, > > please resubmit package to RPMFusion (I'm there too) > > Thanks! Should we add FE-Legal here and wait for approval? Sounds like you should submit the data license for review at https://gitlab.com/fedora/legal/fedora-license-data/-/issues See: https://docs.fedoraproject.org/en-US/legal/license-review-process/
Assets/data files not allowed for redistributing via official Fedora repos, see: https://gitlab.com/fedora/legal/fedora-license-data/-/issues/345 But we can package just source files [1] and script downloader helper should be fine, i hope. New build: Spec URL: https://download.copr.fedorainfracloud.org/results/atim/opentyrian/fedora-rawhide-x86_64/06479571-opentyrian/opentyrian.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/opentyrian/fedora-rawhide-x86_64/06479571-opentyrian/opentyrian-2.1.20221123-1.fc40.src.rpm [1]: https://gitlab.com/fedora/legal/fedora-license-data/-/issues/345#note_1561680062
Minor quick fix: Spec URL: https://download.copr.fedorainfracloud.org/results/atim/opentyrian/fedora-rawhide-x86_64/06479580-opentyrian/opentyrian.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/opentyrian/fedora-rawhide-x86_64/06479580-opentyrian/opentyrian-2.1.20221123-1.fc40.src.rpm
Hi! Package need to be re-approved: Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago Changing status to POST would enough i believe.
@Artem when would the "script downloader helper" be run?
(In reply to Richard Fontana from comment #13) > @Artem when would the "script downloader helper" be run? The only tip for user is description in 'opentyrian-data' package and manual invoking: $ opentyrian-install-data-files.sh I agree this really bad. Quick and dirty. It's also requires root permissions and files upstream bug about this [1]. I also need to look at your suggestion 'game-data-packager' from RPMfusion, this interesting. The only problem with RPMfusion is it not enabled by default. This reduce discoverability of new packages hardly. [1]: https://github.com/opentyrian/opentyrian/issues/73
Spec URL: https://download.copr.fedorainfracloud.org/results/atim/opentyrian/fedora-rawhide-x86_64/06479623-opentyrian/opentyrian.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/opentyrian/fedora-rawhide-x86_64/06479623-opentyrian/opentyrian-2.1.20221123-1.fc40.src.rpm
The downloader script looks way too brittle. There is "autodownloader" in Fedora but it is almost not maintained, but could get "opentyrian" packaged faster. > https://github.com/opentyrian/opentyrian/issues/73 I don't think it's wise to annoy upstream with petty packaging issues. They would more likely accept a more generic/reusable patch.