SPEC: https://pagure.io/ksanecore_rpm/raw/master/f/ksanecore.spec SRPM: https://pagure.io/ksanecore_rpm/raw/master/f/ksanecore-22.12.0-1.fc37.src.rpm Description: Library providing logic to interface scanners This is a new KDE library required for Skanlite and Skanpage applications.
I am taking this review
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons CC0 1.0", "*No copyright* BSD 2-Clause License", "*No copyright* BSD 3-Clause License", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 2.1", "Unknown or generated". 29 files have unknown license. Detailed output of licensecheck in 2155354-ksanecore/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/cmake/KSaneCore, /usr/include/KSaneCore [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/cmake/KSaneCore, /usr/include/KSaneCore [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ksanecore-22.12.0-1.fc38.x86_64.rpm ksanecore-devel-22.12.0-1.fc38.x86_64.rpm ksanecore-debuginfo-22.12.0-1.fc38.x86_64.rpm ksanecore-debugsource-22.12.0-1.fc38.x86_64.rpm ksanecore-22.12.0-1.fc38.src.rpm ============================================== rpmlint session starts ============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpoxacsczv')] checks: 31, packages: 5 ksanecore-devel.x86_64: W: no-documentation ksanecore.src: W: invalid-license LGPLv2.1-only ksanecore.src: W: invalid-license LGPLv3.0-only ksanecore.x86_64: W: invalid-license LGPLv2.1-only ksanecore.x86_64: W: invalid-license LGPLv3.0-only ksanecore-debuginfo.x86_64: W: invalid-license LGPLv2.1-only ksanecore-debuginfo.x86_64: W: invalid-license LGPLv3.0-only ksanecore-debugsource.x86_64: W: invalid-license LGPLv2.1-only ksanecore-debugsource.x86_64: W: invalid-license LGPLv3.0-only ksanecore-devel.x86_64: W: invalid-license LGPLv2.1-only ksanecore-devel.x86_64: W: invalid-license LGPLv3.0-only ============== 5 packages and 0 specfiles checked; 0 errors, 11 warnings, 0 badness; has taken 0.3 s =============== Rpmlint (debuginfo) ------------------- Checking: ksanecore-debuginfo-22.12.0-1.fc38.x86_64.rpm ============================================== rpmlint session starts ============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcpbz6ppp')] checks: 31, packages: 1 ksanecore-debuginfo.x86_64: W: invalid-license LGPLv2.1-only ksanecore-debuginfo.x86_64: W: invalid-license LGPLv3.0-only =============== 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.2 s =============== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 ksanecore-devel.x86_64: W: no-documentation ksanecore-debugsource.x86_64: W: invalid-license LGPLv2.1-only ksanecore-debugsource.x86_64: W: invalid-license LGPLv3.0-only ksanecore-debuginfo.x86_64: W: invalid-license LGPLv2.1-only ksanecore-debuginfo.x86_64: W: invalid-license LGPLv3.0-only ksanecore.x86_64: W: invalid-license LGPLv2.1-only ksanecore.x86_64: W: invalid-license LGPLv3.0-only ksanecore-devel.x86_64: W: invalid-license LGPLv2.1-only ksanecore-devel.x86_64: W: invalid-license LGPLv3.0-only 4 packages and 0 specfiles checked; 0 errors, 9 warnings, 0 badness; has taken 0.3 s Source checksums ---------------- http://download.kde.org/stable/release-service/22.12.0/src/ksanecore-22.12.0.tar.xz : CHECKSUM(SHA256) this package : d4c2653ea1bf0cb5012c3971547022535a5f925e6f56c4e2731e27d571376bee CHECKSUM(SHA256) upstream package : d4c2653ea1bf0cb5012c3971547022535a5f925e6f56c4e2731e27d571376bee Requires -------- ksanecore (rpmlib, GLIBC filtered): libKF5I18n.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libsane.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) ksanecore-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) ksanecore(x86-64) libKSaneCore.so.1()(64bit) ksanecore-debuginfo (rpmlib, GLIBC filtered): ksanecore-debugsource (rpmlib, GLIBC filtered): Provides -------- ksanecore: ksanecore ksanecore(x86-64) libKSaneCore.so.1()(64bit) ksanecore-devel: cmake(KSaneCore) cmake(ksanecore) ksanecore-devel ksanecore-devel(x86-64) ksanecore-debuginfo: debuginfo(build-id) ksanecore-debuginfo ksanecore-debuginfo(x86-64) libKSaneCore.so.22.12.0-22.12.0-1.fc38.x86_64.debug()(64bit) ksanecore-debugsource: ksanecore-debugsource ksanecore-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2155354 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Perl, SugarActivity, Python, Haskell, Java, Ocaml, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
I am approving this package but please also add "gcc-c++" and "cmake" itself as a BR as well. Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Rest is LGTM, thank you.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ksanecore