Spec URL: https://dcavalca.fedorapeople.org/review/crosswords-puzzle-sets-xword-dl/crosswords-puzzle-sets-xword-dl.spec SRPM URL: https://dcavalca.fedorapeople.org/review/crosswords-puzzle-sets-xword-dl/crosswords-puzzle-sets-xword-dl-0.3.0~20220905git5b233eb-1.fc38.src.rpm Description: Download crossword puzzles for GNOME Crosswords from assorted newspapers using xword-dl. Fedora Account System Username: dcavalca
LGTM - APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 29 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2155776-crosswords-puzzle-sets-xword- dl/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: crosswords-puzzle-sets-xword-dl-0.3.0~20220905git5b233eb-1.fc38.noarch.rpm crosswords-puzzle-sets-xword-dl-0.3.0~20220905git5b233eb-1.fc38.src.rpm =========================================================================== rpmlint session starts ========================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvc9ccdb_')] checks: 31, packages: 2 crosswords-puzzle-sets-xword-dl.noarch: W: no-documentation ============================================ 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s =========================================== Source checksums ---------------- https://gitlab.gnome.org/jrb/puzzle-sets-xword-dl/-/archive/5b233eba14166b5663e1c594b1183c2289433fa2/puzzle-sets-xword-dl-5b233eba14166b5663e1c594b1183c2289433fa2.tar.gz : CHECKSUM(SHA256) this package : d4b936b80567d16d0ae75cd983d402eaa8bf8d3297c7c4fdc2a430b6df1156d2 CHECKSUM(SHA256) upstream package : d4b936b80567d16d0ae75cd983d402eaa8bf8d3297c7c4fdc2a430b6df1156d2 Requires -------- crosswords-puzzle-sets-xword-dl (rpmlib, GLIBC filtered): crosswords python3-xword-dl Provides -------- crosswords-puzzle-sets-xword-dl: crosswords-puzzle-sets-xword-dl metainfo() metainfo(org.gnome.Crosswords.PuzzleSets.xword-dl.metainfo.xml) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2155776 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, PHP, Haskell, Java, SugarActivity, Ocaml, R, Perl, fonts, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/crosswords-puzzle-sets-xword-dl
FEDORA-2022-d83811cb80 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d83811cb80
FEDORA-2022-d83811cb80 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-b2f57b8d54 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b2f57b8d54
FEDORA-2022-b312e27a4c has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b312e27a4c
FEDORA-2022-b2f57b8d54 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b2f57b8d54 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b2f57b8d54 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-b312e27a4c has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b312e27a4c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b312e27a4c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-b2f57b8d54 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-b312e27a4c has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.