Bug 2155900 - update uhubctl to 2.5.0 to take advantage of 6.0 kernels
Summary: update uhubctl to 2.5.0 to take advantage of 6.0 kernels
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: uhubctl
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Scott K Logan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-22 19:43 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2023-01-28 01:31 UTC (History)
1 user (show)

Fixed In Version: uhubctl-2.5.0-1.fc37 uhubctl-2.5.0-1.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-22 01:42:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2022-12-22 19:43:20 UTC
Description of problem:
uhubctl was updated to 2.5.0 in rawhide (F38), but not in older branches. Please backport the update to F37 and F36, too. https://github.com/mvp/uhubctl/pull/450 which takes advantage of new sysfs interfaces in kernel 6.0 and fixes two issues was merged only in 2.5.0 or later.

See:
https://github.com/mvp/uhubctl#usb-devices-are-not-removed-after-port-power-down-on-linux
https://github.com/mvp/uhubctl#power-comes-back-on-after-few-seconds-on-linux

Version-Release number of selected component (if applicable):
uhubctl-2.4.0-4.fc37.x86_64

Comment 1 Scott K Logan 2022-12-22 20:59:24 UTC
I'm pretty lukewarm about this.

On one hand, the diff is pretty containable [1].
On the other hand, Fedora's updates policy states: "Updates [to stable releases] should aim to fix bugs, and not introduce features" [2].

Since this isn't a library there is no ABI concern, and the changes appear to only add new command line options. It's hard for me to tell if this update could regress existing behaviors, especially if an existing use is suddenly automatically switching to a new underlying mechanism (kernel v6, as you said) without the user's knowledge.

All that said, I'm open to this change mainly because upstream doesn't believe it warranted a major version bump. It would give me a lot of peace of mind if you'd test and give feedback on the Bodhi update, though.

--scott

[1] https://github.com/mvp/uhubctl/compare/v2.4.0...v2.5.0
[2] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#stable-releases

Comment 2 Dominik 'Rathann' Mierzejewski 2023-01-04 11:33:11 UTC
Thanks for the quick response and sorry for the delay in mine. It was the holiday season. :)

Arguably, the "power coming back after a few seconds" is a bug that is fixed in kernel 6.0+
and uhubctl 2.5.0, but only if both components are updated.

And sure, I will test and give feedback. I have a couple of supported USB hubs.
I'm experiencing the two issues I described in comment #0 and I can confirm that updating
to 2.5.0 fixes them. I did a f37 scratch build of your 2.5.0 update from rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=95757202 to test.

Comment 3 Fedora Update System 2023-01-17 17:26:23 UTC
FEDORA-2023-272ac04ea0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-272ac04ea0

Comment 4 Fedora Update System 2023-01-17 17:26:24 UTC
FEDORA-2023-aea66941f7 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-aea66941f7

Comment 5 Fedora Update System 2023-01-18 02:37:02 UTC
FEDORA-2023-272ac04ea0 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-272ac04ea0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-272ac04ea0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-01-18 03:39:41 UTC
FEDORA-2023-aea66941f7 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-aea66941f7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-aea66941f7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-01-22 01:42:13 UTC
FEDORA-2023-272ac04ea0 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-01-28 01:31:15 UTC
FEDORA-2023-aea66941f7 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.