Bug 2156150 - python3-sip-devel-4.19.25-5 contains broken LFLAGS defaults
Summary: python3-sip-devel-4.19.25-5 contains broken LFLAGS defaults
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: sip
Version: 37
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Than Ngo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-24 13:17 UTC by tarikviehmann
Modified: 2023-03-16 18:32 UTC (History)
2 users (show)

Fixed In Version: sip-4.19.25-6.fc37
Clone Of:
Environment:
Last Closed: 2023-03-16 18:32:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description tarikviehmann 2022-12-24 13:17:26 UTC
Description of problem:

For context, this happened when trying to build ros2 humble on fedora 37.
The qt_gui_cpp package utilizes the sipconfig python lib by creating creating an object of a class deriving from 
> sipconfig.Configuration 
class and then passing that object to 
> sipconfig.SIPModuleMakefile

The component i am describing here can be found at https://github.com/ros-visualization/python_qt_binding/blob/humble/cmake/sip_configure.py

The __init__ of sipconfig.Configuration uses the defined _default_macros. For the LFLAGS, these resolve to:

> 'LFLAGS':'-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -Wl,-dT,/builddir/build/BUILD/sip-4.19.25/.package_note-sip-4.19.25-5.fc37.x86_64.ld'

which in turn causes the final makefile that was generated to crash with a linker error:

> /usr/bin/ld: cannot open linker script file /builddir/build/BUILD/sip-4.19.25/.package_note-sip-4.19.25-5.fc37.x86_64.ld: No such file or directory

Version-Release number of selected component (if applicable):

python3-sip-devel-4.19.25-5.fc37.x86_64

How reproducible:


Steps to Reproduce:
1. Install python3-sip-devel on Fedora 37
2. The installed component at /usr/lib64/python3.11/site-packages/sipconfig.py contains the described LFLAGS
3. Create a config using sipconfig.Configuration
4- Feed that configuration to sipconfig.SIPModuleMakefile
5. Run the resulting makefile

Actual results:
Linker error due to the default LFLAGS generated by sipconfig.Configuration

Expected results:
No Linker error due to default LFLAGS.

Additional info:
The problem disappears when removing the following linker option from LFLAGS 
> -Wl,-dT,/builddir/build/BUILD/sip-4.19.25/.package_note-sip-4.19.25-5.fc37.x86_64.ld

Comment 1 Than Ngo 2023-03-07 16:30:35 UTC
it is fixed in sip-4.19.25-6.fc37

Comment 2 Fedora Update System 2023-03-07 16:37:47 UTC
FEDORA-2023-a5b7b6b33a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a5b7b6b33a

Comment 3 Fedora Update System 2023-03-08 01:26:53 UTC
FEDORA-2023-a5b7b6b33a has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a5b7b6b33a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a5b7b6b33a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2023-03-16 18:32:04 UTC
FEDORA-2023-a5b7b6b33a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.