Bug 2156942 - Tests fail on big-endian platform (s390x)
Summary: Tests fail on big-endian platform (s390x)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pykeepass
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F-ExcludeArch-s390x
TreeView+ depends on / blocked
 
Reported: 2022-12-29 18:28 UTC by Ben Beasley
Modified: 2023-05-12 14:39 UTC (History)
3 users (show)

Fixed In Version: python-pykeepass-4.0.4-1.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-12 12:20:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github libkeepass pykeepass issues 332 0 None open Tests fail on big-endian platform (s390x) 2022-12-29 18:28:18 UTC

Description Ben Beasley 2022-12-29 18:28:18 UTC
Description of problem:

Tests fail (and library fails to import) due to an assertion error on s390x.

Version-Release number of selected component (if applicable): 4.0.3-1


How reproducible:


Steps to Reproduce:
1. fedpkg scratch-build --arches s390x

Actual results:

+ /usr/bin/python3 -m unittest discover -s tests -v
tests (unittest.loader._FailedTest.tests) ... ERROR
======================================================================
ERROR: tests (unittest.loader._FailedTest.tests)
----------------------------------------------------------------------
ImportError: Failed to import test module: tests
Traceback (most recent call last):
  File "/usr/lib64/python3.11/unittest/loader.py", line 407, in _find_test_path
    module = self._get_module_from_name(name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/unittest/loader.py", line 350, in _get_module_from_name
    __import__(name)
  File "/builddir/build/BUILD/pykeepass-4.0.3/tests/tests.py", line 18, in <module>
    from pykeepass import PyKeePass, icons
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/__init__.py", line 2, in <module>
    from .pykeepass import PyKeePass, create_database
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/pykeepass.py", line 28, in <module>
    from pykeepass.kdbx_parsing.kdbx import KDBX
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/kdbx_parsing/__init__.py", line 1, in <module>
    from .kdbx import KDBX
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/kdbx_parsing/kdbx.py", line 2, in <module>
    from .kdbx3 import DynamicHeader as DynamicHeader3
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/kdbx_parsing/kdbx3.py", line 10, in <module>
    from .common import (
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/kdbx_parsing/common.py", line 2, in <module>
    from .twofish import Twofish
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/kdbx_parsing/twofish.py", line 27, in <module>
    from . import pytwofish
  File "/builddir/build/BUILD/pykeepass-4.0.3/pykeepass/kdbx_parsing/pytwofish.py", line 395, in <module>
    assert b'l\xb4V\x1c@\xbf\n\x97\x05\x93\x1c\xb6\xd4\x08\xe7\xfa' == Twofish(__testkey).encrypt(__testdat)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
----------------------------------------------------------------------
Ran 1 test in 0.000s
FAILED (errors=1)


Expected results:

Tests pass.

Additional info:

ExcludeArch will be added. The sole dependent package already excludes s390x: https://src.fedoraproject.org/rpms/secrets/blob/e31477918101de297a36372281fe12de4a9fe259/f/secrets.spec#_15

Comment 1 Fedora Admin user for bugzilla script actions 2022-12-30 00:29:27 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 2 Ben Cotton 2023-02-07 15:11:53 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 3 Ben Beasley 2023-03-05 14:37:06 UTC
Fix proposed upstream. Allowing some time for upstream to (maybe) review it.

https://github.com/libkeepass/pykeepass/pull/336

Comment 4 Fedora Update System 2023-05-12 12:17:47 UTC
FEDORA-2023-e00430d7bb has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e00430d7bb

Comment 5 Fedora Update System 2023-05-12 12:20:22 UTC
FEDORA-2023-e00430d7bb has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.