Bug 2157746 - Review Request: perl-Test-MockTime-HiRes - Replaces actual time with simulated high resolution time
Summary: Review Request: perl-Test-MockTime-HiRes - Replaces actual time with simulate...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2157099
TreeView+ depends on / blocked
 
Reported: 2023-01-02 16:47 UTC by Jitka Plesnikova
Modified: 2023-01-13 13:19 UTC (History)
2 users (show)

Fixed In Version: perl-Test-MockTime-HiRes-0.08-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-13 13:19:29 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2023-01-02 16:47:45 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Test-MockTime-HiRes/perl-Test-MockTime-HiRes.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Test-MockTime-HiRes/perl-Test-MockTime-HiRes-0.08-1.fc38.src.rpm
Description:
Test::MockTime::HiRes is a Time::HiRes compatible version of Test::MockTime. You can wait milliseconds in simulated time.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2023-01-13 09:18:36 UTC
URL and Source0 address are Ok.
Source0 archive (SHA-512: 8a533d3650fe59ebc7852f5edb07d242d4c8833ed8ea918d4e0fb999e51b12ca6dc12567f55b47a6a37b65821b922e17e0208726ad3afe75a895fc84896fcf9f) is original. Ok.
Summary verified from lib/Test/MockTime/HiRes.pm. Ok.
Description verified from lib/Test/MockTime/HiRes.pm. Ok.
License verified from lib/Test/MockTime/HiRes.pm, README.md, LICENSE. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.

TODO: List packaged files explicitly instrad of using top-level globs (perl-Test-MockTime-HiRes.spec:75) <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists>.

All tests pass. Ok.

$ rpmlint perl-Test-MockTime-HiRes.spec ../SRPMS/perl-Test-MockTime-HiRes-0.08-1.fc38.src.rpm ../RPMS/noarch/perl-Test-MockTime-HiRes-*
======================================== rpmlint session starts =======================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

perl-Test-MockTime-HiRes-tests.noarch: W: no-documentation
========= 3 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.5 s ========
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test-MockTime-HiRes-*
drwxr-xr-x    2 root     root                        0 Jan  2 01:00 /usr/share/doc/perl-Test-MockTime-HiRes
-rw-r--r--    1 root     root                      583 Feb  4  2018 /usr/share/doc/perl-Test-MockTime-HiRes/Changes
-rw-r--r--    1 root     root                     1102 Feb  4  2018 /usr/share/doc/perl-Test-MockTime-HiRes/README.md
drwxr-xr-x    2 root     root                        0 Jan  2 01:00 /usr/share/licenses/perl-Test-MockTime-HiRes
-rw-r--r--    1 root     root                    18391 Feb  4  2018 /usr/share/licenses/perl-Test-MockTime-HiRes/LICENSE
-rw-r--r--    1 root     root                     1270 Jan  2 01:00 /usr/share/man/man3/Test::MockTime::HiRes.3pm.gz
drwxr-xr-x    2 root     root                        0 Jan  2 01:00 /usr/share/perl5/vendor_perl/Test
drwxr-xr-x    2 root     root                        0 Jan  2 01:00 /usr/share/perl5/vendor_perl/Test/MockTime
-rw-r--r--    1 root     root                     3988 Feb  4  2018 /usr/share/perl5/vendor_perl/Test/MockTime/HiRes.pm
drwxr-xr-x    2 root     root                        0 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes
drwxr-xr-x    2 root     root                        0 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes/t
-rwxr-xr-x    1 root     root                      324 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes/t/01_core.t
-rwxr-xr-x    1 root     root                     2728 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes/t/02_hires.t
-rwxr-xr-x    1 root     root                     1013 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes/t/03_anyevent.t
-rwxr-xr-x    1 root     root                      288 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes/t/04_sleep.t
-rwxr-xr-x    1 root     root                      616 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes/t/05_hires.t
-rwxr-xr-x    1 root     root                      108 Jan  2 01:00 /usr/libexec/perl-Test-MockTime-HiRes/test
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Test-MockTime-HiRes-0.08-1.fc38.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(Test::MockTime)
      1 perl(Test::More)
      1 perl(Time::HiRes)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
$ rpm -q --requires -p ../RPMS/noarch/perl-Test-MockTime-HiRes-tests-0.08-1.fc38.noarch.rpm | sort -f | uniq -c
      1 /usr/bin/perl
      1 /usr/bin/sh
      1 perl(AnyEvent)
      1 perl(AnyEvent::Impl::Perl)
      1 perl(parent)
      1 perl(strict)
      1 perl(Test::Class)
      1 perl(Test::MockTime::HiRes)
      1 perl(Test::More)
      1 perl(Test::Requires)
      1 perl(Time::HiRes)
      1 perl(warnings)
      1 perl-Test-Harness
      1 perl-Test-MockTime-HiRes = 0.08-1.fc38
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Test-MockTime-HiRes-0.08-1.fc38.noarch.rpm | sort -f | uniq -c
      1 perl(Test::MockTime::HiRes) = 0.08
      1 perl-Test-MockTime-HiRes = 0.08-1.fc38
$ rpm -q --provides -p ../RPMS/noarch/perl-Test-MockTime-HiRes-tests-0.08-1.fc38.noarch.rpm | sort -f | uniq -c
      1 perl-Test-MockTime-HiRes-tests = 0.08-1.fc38
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Test-MockTime-HiRes-*
Binary dependencies are resolvable. Ok.

The package builds in Fedora 38 (https://koji.fedoraproject.org/koji/taskinfo?taskID=96083588). Ok.

Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please consider correcting the 'TODO' item before building this package.
Resolution: Package APPROVED.

Comment 2 Jitka Plesnikova 2023-01-13 12:20:58 UTC
https://pagure.io/releng/fedora-scm-requests/issue/50435

Comment 3 Fedora Admin user for bugzilla script actions 2023-01-13 12:21:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-MockTime-HiRes

Comment 4 Jitka Plesnikova 2023-01-13 13:19:29 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.