Red Hat Bugzilla – Bug 215792
Review Request: wgrib - Manipulate, inventory and decode GRIB files
Last modified: 2007-11-30 17:11:49 EST
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/wgrib.spec
SRPM Name or Url:
WGRIB is a program to manipulate, inventory and decode GRIB files.
Note that an older wgrib is currently shipped with grads, this will replace it.
It is not completely obvious that the version-release is right,
maybe it could also be something like
to be safe in case 1.8.0 appears. Not sure, as it may also be
some post-releases. It seems to be 188.8.131.52g, anyway.
* matches upstream (diff used)
* rpmlint gives (easy to fix)
W: wgrib incoherent-version-in-changelog 184.108.40.206b 220.127.116.11b-1
* license is public domain, notice included, match upstream
* upstream is not properly packaged. Maybe you could send a mail?
* %files right
* very simple package
I wanted to test using the porting.txt instructions, but couldn't
If it is possible, I think it would be good to include that file, if
it isn't too big.
The only potential blocker, in my opinion is the version-release.
What branch will you create?
I found land.grb
should be shipped
All the tests were successful.
Just found (beware, there is no top-level directory):
There is a script src2all which shows how the source files are
combined into wgrib.c. And also a makefile which could be
used to build wgrib.
Think the version is right, previous versions are like 18.104.22.168, 22.214.171.124g.
Did you get this output from testbin.f:
bad values: 1.0116254E-40
I'm thinking of not using testbin.f because I don't really want to be debugging
one test program when another works. Also, do you really think it makes sense
to ship testbin.c and land.grb or just use it in %check?
I checked out the tar file before, but it seems to be version 126.96.36.199g which is
marked as "beta" on the main web page. The full C file seems to be the
preferred "release" mechanism and the makefile shipped with the tar file is
pretty useless as well.
Here's the latest:
As for branches, I'd like to do FC-5 on. Will need to coordinate with your
grads package obviously.
Thanks for the review!
(In reply to comment #4)
> Think the version is right, previous versions are like 188.8.131.52, 184.108.40.206g.
> Did you get this output from testbin.f:
> bad values: 1.0116254E-40
Yes. From my tests it seems to be for the very latest point, maybe
an error in the test script.
> I'm thinking of not using testbin.f because I don't really want to be debugging
> one test program when another works. Also, do you really think it makes sense
> to ship testbin.c and land.grb or just use it in %check?
Both would make sense in my opinion. I think that those files would
be rightly in %doc (and also testbin.f).
> I checked out the tar file before, but it seems to be version 220.127.116.11g which is
> marked as "beta" on the main web page. The full C file seems to be the
> preferred "release" mechanism and the makefile shipped with the tar file is
> pretty useless as well.
Ok, I thought it was the corresponding wgrib.c. In fact the Changes
file is misleading, and that's because of that file that I thought that
that the shipped version was 18.104.22.168g. I proposed the tar file because
there are already some files shipped in that tar and it could remove
the need to ship some of the files individually.
Somethingn should be done for the Changes file.
> Here's the latest:
> As for branches, I'd like to do FC-5 on. Will need to coordinate with your
> grads package obviously.
Ok. It's already done for devel.
Emailed Wesley. 22.214.171.124g has just been made "production", so I've upped the
version. He still wants the .c file to be the official release, but has started
versioning them on the ftp site. I've asked again for versioned .tar files so
we can get the Changes file with them, but I really don't see it as a blocker at
The version issue being sorted out, rpmlint is silent now,
Why isn't it built now?
cvs troubles then I got busy.
Checked in and added to owners.list. Building on devel. Will ask for FC-6 and
FC-5 branches, but won't build until you rebuilt grads. Let me know...
I have rebuilt grads without wgrib.
FC-5 and FC-6 builds submitted. Closing..