Bug 2158224 - [RFE: EPEL8] EPEL8 branch for dumb-init
Summary: [RFE: EPEL8] EPEL8 branch for dumb-init
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dumb-init
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Artur Frenszek-Iwicki
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-04 17:35 UTC by Pat Riehecky
Modified: 2023-03-01 00:35 UTC (History)
2 users (show)

Fixed In Version: dumb-init-1.2.5-7.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-01 00:35:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Pat Riehecky 2023-01-04 17:35:25 UTC
Description of problem:
Can dumb-init be branched and built for EPEL8?

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Artur Frenszek-Iwicki 2023-01-04 18:12:29 UTC
I managed to successfully build dumb-init in EPEL8 mock, so this should work.

Comment 2 Artur Frenszek-Iwicki 2023-01-04 20:03:48 UTC
Building in koji failed on s390x: https://koji.fedoraproject.org/koji/taskinfo?taskID=95767898
> =================================== FAILURES ===================================
> ________________________ test_working_directories[1-0] _________________________
>     @pytest.mark.usefixtures('both_debug_modes', 'both_setsid_modes')
>     def test_working_directories():
>         """The child process must start in the working directory in which
>         dumb-init was invoked, but dumb-init itself should not keep a
>         reference to that."""
>     
>         # We need absolute path to dumb-init since we pass cwd=/tmp to get
>         # predictable output - so we can't rely on dumb-init being found
>         # in the "." directory.
>         dumb_init = os.path.realpath(shutil.which('dumb-init'))
>         proc = run((dumb_init,
>                     'sh', '-c', 'readlink /proc/$PPID/cwd && readlink /proc/$$/cwd'),
>                    cwd="/tmp", stdout=PIPE, stderr=PIPE)
>     
>         assert proc.returncode == 0
> >       assert proc.stdout == b'/\n/tmp\n'
> E       AssertionError: assert b'/tmp\n/tmp\n' == b'/\n/tmp\n'
> E         At index 1 diff: 116 != 10
> E         Left contains more items, first extra item: 109
> E         Full diff:
> E         - b'/tmp\n/tmp\n'
> E         ?    ---
> E         + b'/\n/tmp\n'
> tests/cwd_test.py:22: AssertionError
> ===================== 1 failed, 181 passed in 9.65 seconds =====================

I'll try to find a fix for this. If I can't, I guess I'll just add "ExcludeArch: s390x".

Comment 3 Fedora Update System 2023-02-20 18:32:08 UTC
FEDORA-EPEL-2023-85bd9419d1 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-85bd9419d1

Comment 4 Artur Frenszek-Iwicki 2023-02-20 18:34:11 UTC
Sorry for taking so long - I admit I completely forgot about this ticket.
Whatever was causing the tests to fail on s390x appears to have been fixed.
Enjoy!

Comment 5 Fedora Update System 2023-02-21 02:23:28 UTC
FEDORA-EPEL-2023-85bd9419d1 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-85bd9419d1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-03-01 00:35:08 UTC
FEDORA-EPEL-2023-85bd9419d1 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.