Bug 2158328 - RFE: Support changing txqueuelen and other link settings
Summary: RFE: Support changing txqueuelen and other link settings
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: NetworkManager
Version: 9.2
Hardware: All
OS: Linux
medium
low
Target Milestone: rc
: ---
Assignee: Beniamino Galvani
QA Contact: Vladimir Benes
Marc Muehlfeld
URL:
Whiteboard:
Depends On:
Blocks: 2183217
TreeView+ depends on / blocked
 
Reported: 2023-01-05 04:56 UTC by Jonathan Maxwell
Modified: 2023-07-13 07:25 UTC (History)
8 users (show)

Fixed In Version: NetworkManager-1.43.3-1.el9
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker NMT-114 0 None None None 2023-01-22 14:16:28 UTC
Red Hat Issue Tracker RHELPLAN-143987 0 None None None 2023-01-05 05:02:17 UTC
freedesktop.org Gitlab NetworkManager NetworkManager-ci merge_requests 1332 0 None merged general: add test for new link settings 2023-03-14 10:41:50 UTC
freedesktop.org Gitlab NetworkManager NetworkManager merge_requests 1541 0 None merged Add a "link" setting 2023-03-03 12:42:42 UTC

Description Jonathan Maxwell 2023-01-05 04:56:15 UTC
We had a request from a customer to set txqueuelen in /etc/NetworkManager/system-connections/<interface>.nmconnection. 

According to "man nm-settings" there is currently no way to do this. So the customer needs to use udev rules, rc_local or write a NM dispatcher script.

Please can a txqueuelen option under the connection setting be added?

Comment 5 Beniamino Galvani 2023-01-24 15:55:05 UTC
While at it, we could add support for other related properties as well:

 txqueuelen   (IFLA_TXQLEN)
 numtxqueues  (IFLA_NUM_TX_QUEUES)
 numrxqueues  (IFLA_NUM_RX_QUEUES)
 gso_max_size (IFLA_GSO_MAX_SIZE)
 gso_max_segs (IFLA_GSO_MAX_SEGS)
 gro_max_size (IFLA_GRO_MAX_SIZE)
 tso_max_size (IFLA_TSO_MAX_SIZE)
 tso_max_segs (IFLA_TSO_MAX_SEGS)

Probably those properties should go in the "connection" setting.

Comment 6 Vladimir Benes 2023-03-07 13:41:39 UTC
This doesn't work under ifcfg-rh plugin, changes are simply gone. Moving back to assigned.

Comment 7 Till Maas 2023-03-07 18:41:03 UTC
(In reply to Vladimir Benes from comment #6)
> This doesn't work under ifcfg-rh plugin, changes are simply gone. Moving
> back to assigned.

The original request was only for key files, see comment:0. Therefore it seems to be fine to support this only with key files.

Comment 8 Till Maas 2023-03-07 18:47:15 UTC
(In reply to Till Maas from comment #7)
> (In reply to Vladimir Benes from comment #6)
> > This doesn't work under ifcfg-rh plugin, changes are simply gone. Moving
> > back to assigned.
> 
> The original request was only for key files, see comment:0. Therefore it
> seems to be fine to support this only with key files.

The acceptance criteria concur:

As a linux administrator, I would like a way to configure the number of frames allowed per kernel transmission queue using NetworkManager so that I don’t need to write a dispatcher script or to use udev rules or rc local.


Given a RHEL machine where NetworkManager is running

When txqueuelen is set in /etc/NetworkManager/system-connections/<interface>.nmconnection in the “connection” or “ethtool” setting (depending where it makes most sense)

Then, NetworkManager should configure the txqueuelen for this interface.

Moving back to ON_QA.

Comment 9 Beniamino Galvani 2023-03-07 22:00:05 UTC
> The original request was only for key files, see comment:0. Therefore it seems to be fine to support this only with key files.

The problem is that there is no indication anywhere that the properties are ignored because ifcfg doesn't support them, they just vanish from the connection upon saving. If a RHEL9 machine has ifcfg files (that were generated manually or copied from RHEL8), these property won't work and it would be very hard to understand why for users. It seems better to either add ifcfg support for them, or add a mechanism to return an error when a property is not supported by the current format.


Note You need to log in before you can comment on or make changes to this bug.