Bug 2158464 - Review Request: perl-Syntax-Operator-In - Infix element-of-list meta-operator
Summary: Review Request: perl-Syntax-Operator-In - Infix element-of-list meta-operator
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-05 14:19 UTC by Petr Pisar
Modified: 2023-01-10 12:08 UTC (History)
2 users (show)

Fixed In Version: perl-Syntax-Operator-In-0.04-2.fc38
Clone Of:
Environment:
Last Closed: 2023-01-10 12:08:16 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2023-01-05 14:19:36 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator-In.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator-In-0.04-1.fc38.src.rpm
Description:
This Perl module provides an infix meta-operator that implements an
element-of-list test on either strings or numbers.

Fedora Account System Username: ppisar

Comment 1 Jakub Kadlčík 2023-01-05 14:22:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5201882
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158464-perl-Syntax-Operator-In/srpm-builds/05201882/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Petr Pisar 2023-01-05 15:19:07 UTC
Why do you think this package does not build in Rawhide? That log shows an error in HTTPS transfer:

Retry request #1 on https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator-In-0.04-1.fc38.src.rpm: Requests error on https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator-In-0.04-1.fc38.src.rpm: HTTPSConnectionPool(host='ppisar.fedorapeople.org', port=443): Max retries exceeded with url: /perl-Syntax-Operator-In/perl-Syntax-Operator-In-0.04-1.fc38.src.rpm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:992)')))

Comment 3 Petr Pisar 2023-01-05 15:23:30 UTC
(In reply to Petr Pisar from comment #2)
> That log shows an error in HTTPS transfer:
> 
https://pagure.io/fedora-infrastructure/issue/11073

Comment 4 Petr Pisar 2023-01-05 15:25:37 UTC
In the mean time, you get the package from <ssh://fedorapeople.org:/home/fedora/ppisar/public_html/perl-Syntax-Operator-In> directory.

Comment 5 Petr Pisar 2023-01-06 07:54:52 UTC
The certificate was fixed, the URLs are safe now.

Comment 6 Jitka Plesnikova 2023-01-10 07:27:20 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Syntax-Operator-In-0.04-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 ld-linux-x86-64.so.2()(64bit)
      1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 perl(Carp)
      1 perl-libs
      2 perl(:MODULE_COMPAT_5.36.0)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 perl(XS::Parse::Infix) >= 0.27
      1 perl(:XS_Parse_Infix_ABI_2)
      1 rtld(GNU_HASH) 
Binary requires are Ok.

$ rpm -qp --provides perl-Syntax-Operator-In-0.04-1.fc38.x86_64.rpm | sort | uniq -c
      1 perl(Syntax::Operator::Elem) = 0.04
      1 perl(Syntax::Operator::In) = 0.04
      1 perl-Syntax-Operator-In = 0.04-1.fc38
      1 perl-Syntax-Operator-In(x86-64) = 0.04-1.fc38
Binary provides are Ok.

Rpmlint is ok

TODO: Please consider using only one style of defining the rpm Build Root.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags

FIX: Add missing 'done' to 'for' on line 73.

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item.

Resolution:
Approved

Comment 7 Tomas Hrcka 2023-01-10 10:55:09 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Operator-In

Comment 8 Petr Pisar 2023-01-10 11:51:25 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.