Spec URL: https://dcavalca.fedorapeople.org/review/python-recordclass/python-recordclass.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-recordclass/python-recordclass-0.18.1.1-1.fc38.src.rpm Description: Recordclass is Python library implementing a mutable variant of namedtuple, which support assignments, and other memory saving variants. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=95791851
Copr build: https://copr.fedorainfracloud.org/coprs/build/5203775 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158694-python-recordclass/fedora-rawhide-x86_64/05203775-python-recordclass/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
LGTM; APPROVED. Two notes: - License check found some CC-1.0 files. These are for appveyor and not shipped so it's fine - Consider splitting the examples to a -doc subpackage, it's quite large (~ 2.7 MB) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2641920 bytes in 56 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* Creative Commons CC0 1.0". 84 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2158694-python- recordclass/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-recordclass [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2703360 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 python3-recordclass.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-recordclass/examples/HTRU_2.csv python3-recordclass.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-recordclass/examples/example.csv python3-recordclass.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-recordclass/examples/example.txt python3-recordclass.x86_64: W: package-with-huge-docs 72% python3-recordclass.x86_64: W: files-duplicate /usr/lib64/python3.11/site-packages/recordclass/test/typing/__init__.py /usr/lib64/python3.11/site-packages/recordclass/test/match/__init__.py python3-recordclass.x86_64: W: files-duplicate /usr/share/doc/python3-recordclass/examples/example.txt /usr/share/doc/python3-recordclass/examples/example.csv 2 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 0.2 s Unversioned so-files -------------------- python3-recordclass: /usr/lib64/python3.11/site-packages/recordclass/_dataobject.cpython-311-x86_64-linux-gnu.so python3-recordclass: /usr/lib64/python3.11/site-packages/recordclass/_linkedlist.cpython-311-x86_64-linux-gnu.so python3-recordclass: /usr/lib64/python3.11/site-packages/recordclass/_litelist.cpython-311-x86_64-linux-gnu.so python3-recordclass: /usr/lib64/python3.11/site-packages/recordclass/_litetuple.cpython-311-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/r/recordclass/recordclass-0.18.1.1.tar.gz : CHECKSUM(SHA256) this package : b0ad89f013798d71e8e480c69b4b59d07f10626c7f7ca33b77cfcca326d1f19f CHECKSUM(SHA256) upstream package : b0ad89f013798d71e8e480c69b4b59d07f10626c7f7ca33b77cfcca326d1f19f Requires -------- python3-recordclass (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH) python-recordclass-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-recordclass: python-recordclass python3-recordclass python3-recordclass(x86-64) python3.11-recordclass python3.11dist(recordclass) python3dist(recordclass) python-recordclass-debugsource: python-recordclass-debugsource python-recordclass-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2158694 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Python, Shell-api Disabled plugins: R, fonts, Perl, PHP, Java, SugarActivity, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks! $ fedpkg request-repo python-recordclass 2158694 https://pagure.io/releng/fedora-scm-requests/issue/50317 $ fedpkg request-branch --repo python-recordclass f37 https://pagure.io/releng/fedora-scm-requests/issue/50318 $ fedpkg request-branch --repo python-recordclass f36 https://pagure.io/releng/fedora-scm-requests/issue/50319
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-recordclass
FEDORA-2023-d3cbdc0641 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d3cbdc0641
FEDORA-2023-d3cbdc0641 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-fbb955dd0f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fbb955dd0f
FEDORA-2023-99c173ba9b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-99c173ba9b
FEDORA-2023-fbb955dd0f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-99c173ba9b has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.