Spec URL: https://smani.fedorapeople.org/review/perl-Feature-Compat-Class.spec SRPM URL: https://smani.fedorapeople.org/review/perl-Feature-Compat-Class-0.04-1.fc38.src.rpm Description: Make class syntax available Fedora Account System Username: smani
Copr build: https://copr.fedorainfracloud.org/coprs/build/5204503 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158741-perl-Feature-Compat-Class/fedora-rawhide-x86_64/05204503-perl-Feature-Compat-Class/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Hello Sandro, I spotted some small issues, see the review below. Please note that this package fails to build on F36 and F37 due to an out-of-date dependency. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Description line too long please make sure that there are no lines in the description longer than 80 characters. - Invalid license Perl I couldn't find any reference to the Perl license, but you should be using SPDX licensing. The correct license would be "GPL-1.0-or-later OR Artistic-1.0-Perl". Please see: https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages - Missing requires perl(Object::Pad) perl(Object::Pad) isn't in the final requires (see below). I double checked, and I believe it should be in there. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "The Perl 5 License GNU General Public License, Version 1", "GNU General Public License". 18 files have unknown license. Detailed output of licensecheck in /home/arthur/fedora-review/2158741-perl-Feature-Compat- Class/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Feature-Compat-Class-0.04-1.fc38.noarch.rpm perl-Feature-Compat-Class-0.04-1.fc38.src.rpm ============================================================================================================================ rpmlint session starts =========================================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpm8mcxfcd')] checks: 31, packages: 2 perl-Feature-Compat-Class.noarch: W: invalid-license Perl perl-Feature-Compat-Class.src: W: invalid-license Perl perl-Feature-Compat-Class.noarch: E: description-line-too-long This module provides the new class keyword and related others (method, field and ADJUST) in a forward-compatible way. perl-Feature-Compat-Class.src: E: description-line-too-long This module provides the new class keyword and related others (method, field and ADJUST) in a forward-compatible way. ============================================================================================= 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 2 badness; has taken 0.2 s ============================================================================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 perl-Feature-Compat-Class.noarch: W: invalid-license Perl perl-Feature-Compat-Class.noarch: E: description-line-too-long This module provides the new class keyword and related others (method, field and ADJUST) in a forward-compatible way. 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.0 s Source checksums ---------------- https://cpan.metacpan.org/authors/id/P/PE/PEVANS/Feature-Compat-Class-0.04.tar.gz : CHECKSUM(SHA256) this package : 84ac47b32820ef1718450c8b88b8ae2ea7cae803b60ecd07a3fbea9910192f4e CHECKSUM(SHA256) upstream package : 84ac47b32820ef1718450c8b88b8ae2ea7cae803b60ecd07a3fbea9910192f4e Requires -------- perl-Feature-Compat-Class (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.36.0) perl(:VERSION) perl(constant) perl(feature) perl(warnings) Provides -------- perl-Feature-Compat-Class: perl(Feature::Compat::Class) perl-Feature-Compat-Class Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2158741 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Perl, Shell-api Disabled plugins: Python, Haskell, R, SugarActivity, C/C++, PHP, fonts, Java, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Few things I missed (thanks Petr): - Please change the url to https://metacpan.org/dist/Feature-Compat-Class - Add a constraint for perl(Object::Pad) >= 0.75 - Add coreutils to BuildRequires for %{_fixperms} - List files under %{perl_vendorlib} directory more explicitly. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists I omitted the other versioned requirements Petr mentioned in the other review as they are not required by the guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies
Spec URL: https://smani.fedorapeople.org/review/perl-Feature-Compat-Class.spec SRPM URL: https://smani.fedorapeople.org/review/perl-Feature-Compat-Class-0.04-2.fc38.src.rpm %changelog * Fri Jan 06 2023 Sandro Mani <manisandro> - 0.04-2 - Fix license - Fix source URL - List files explicitly - Fix requires/BRs
Copr build: https://copr.fedorainfracloud.org/coprs/build/5204855 (failed) Build log: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158741-perl-Feature-Compat-Class/srpm-builds/05204855/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
SRPM is missing, but the diff looks good! Package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Feature-Compat-Class
Thanks for the review!