Bug 2160043 - tkgate: Build in C89 mode
Summary: tkgate: Build in C89 mode
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: tkgate
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCExemptions
TreeView+ depends on / blocked
 
Reported: 2023-01-11 11:58 UTC by Florian Weimer
Modified: 2023-08-16 09:23 UTC (History)
1 user (show)

Fixed In Version: tkgate-2.0-38.beta10.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-11 12:12:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
tkgate-c99.patch (2.11 KB, patch)
2023-01-11 11:58 UTC, Florian Weimer
no flags Details | Diff

Description Florian Weimer 2023-01-11 11:58:02 UTC
Created attachment 1937299 [details]
tkgate-c99.patch

I tried to port the package to C99 mode, but failed because of internal type conflicts.

With the attached patch, I get:

In file included from tkgate.h:52,
                 from paux.c:23:
tkgate_config.h:32: note: this is the location of the previous definition
   32 | #define STRMAX          1024            /* Maximum length of a string */
      | 
paux.c:41:15: error: conflicting types for 'Encoder'; have 'void *'
   41 | typedef void *Encoder;
      |               ^~~~~~~
In file included from tkgate.h:53:
tkgate_misc.h:47:28: note: previous declaration of 'Encoder' with type 'Encoder' {aka 'struct encoder_str'}
   47 | typedef struct encoder_str Encoder;
      |                            ^~~~~~~
paux.c: In function 'ycString':


Note You need to log in before you can comment on or make changes to this bug.