Bug 2160202 - Review Request: golang-github-d2g-hardwareaddr - Generate Hardware Addresses
Summary: Review Request: golang-github-d2g-hardwareaddr - Generate Hardware Addresses
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergio Basto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2045489
TreeView+ depends on / blocked
 
Reported: 2023-01-11 18:19 UTC by Maxwell G
Modified: 2023-02-03 01:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-22 22:33:52 UTC
Type: ---
Embargoed:
sergio: fedora-review+


Attachments (Terms of Use)

Comment 2 Sergio Basto 2023-01-20 23:11:22 UTC
Rpmlint
-------
Checking: golang-github-d2g-hardwareaddr-devel-0-0.1.20230111gite7d9fbe.fc38.noarch.rpm
          golang-github-d2g-hardwareaddr-0-0.1.20230111gite7d9fbe.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp4pgjw64t')]
checks: 31, packages: 2

golang-github-d2g-hardwareaddr.spec: W: no-%build-section
golang-github-d2g-hardwareaddr-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/d2g/hardwareaddr/.goipath
golang-github-d2g-hardwareaddr-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/d2g/hardwareaddr/README.md /usr/share/doc/golang-github-d2g-hardwareaddr-devel/README.md
 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.2 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

golang-github-d2g-hardwareaddr-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/d2g/hardwareaddr/.goipath
golang-github-d2g-hardwareaddr-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/d2g/hardwareaddr/README.md /usr/share/doc/golang-github-d2g-hardwareaddr-devel/README.md
 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/d2g/hardwareaddr/archive/e7d9fbe030e4b7b08e3bdd128e2e81809e4389fd/hardwareaddr-e7d9fbe030e4b7b08e3bdd128e2e81809e4389fd.tar.gz :
  CHECKSUM(SHA256) this package     : 867c8ffc592e672ca8f10e10a6a1860d716b03d03d915484bf7b73adbe6ae18d
  CHECKSUM(SHA256) upstream package : 867c8ffc592e672ca8f10e10a6a1860d716b03d03d915484bf7b73adbe6ae18d



the very simple spec , makes easy to review , the source code of this package is 34 lines 

Package APPROVED

Comment 3 Maxwell G 2023-01-20 23:42:32 UTC
Thank you for the review, Sergio

https://pagure.io/releng/fedora-scm-requests/issue/50559

Comment 4 Fedora Update System 2023-01-22 22:33:22 UTC
FEDORA-2023-e09a03e788 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e09a03e788

Comment 5 Fedora Update System 2023-01-22 22:33:52 UTC
FEDORA-2023-e09a03e788 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2023-01-25 03:56:11 UTC
FEDORA-2023-0c69afdc55 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c69afdc55

Comment 7 Fedora Update System 2023-01-26 02:25:58 UTC
FEDORA-2023-0c69afdc55 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0c69afdc55`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c69afdc55

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-02-03 01:25:04 UTC
FEDORA-2023-0c69afdc55 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.