Spec URL: https://yselkowitz.fedorapeople.org/flatseal.spec SRPM URL: https://yselkowitz.fedorapeople.org/SRPMS/flatseal-1.8.1-1.fc38.src.rpm Description: Flatseal is a graphical utility to review and modify permissions from your Flatpak applications. Fedora Account System Username: yselkowitz
Copr build: https://copr.fedorainfracloud.org/coprs/build/5227730 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2160771-flatseal/fedora-rawhide-x86_64/05227730-flatseal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Taking this review.
Are you still planning on taking this review?
Initial spec review: > Source0: %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz This has tags, so use those instead: "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz" > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop > > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml These should go into %check for clarity.
(In reply to Neal Gompa from comment #4) > Initial spec review: > > > Source0: %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz > > This has tags, so use those instead: > "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz" The packaging guidelines say otherwise, since git tags are not immutable: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags > > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop > > > > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml > > These should go into %check for clarity. The guidelines allow either: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
(In reply to Yaakov Selkowitz from comment #5) > (In reply to Neal Gompa from comment #4) > > Initial spec review: > > > > > Source0: %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz > > > > This has tags, so use those instead: > > "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz" > > The packaging guidelines say otherwise, since git tags are not immutable: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_git_tags > It definitely does not say that. It only mentions screwiness with how Bitbucket works. > > > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop > > > > > > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml > > > > These should go into %check for clarity. > > The guidelines allow either: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_desktop_file_install_usage > > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > #_app_data_validate_usage I guess, though checks like this should be in %check...
Created attachment 1939881 [details] The .spec file difference from Copr build 5227730 to 5283032
Copr build: https://copr.fedorainfracloud.org/coprs/build/5283032 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2160771-flatseal/fedora-rawhide-x86_64/05283032-flatseal/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Review notes: * Package naming follows packaging guidelines * Package builds and installs * Package has no serious rpmlint issues * Package licensing is handled correctly PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/flatseal
FEDORA-2023-15905b1689 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-15905b1689
FEDORA-EPEL-2023-750a4a2151 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-750a4a2151
FEDORA-2023-15905b1689 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-15905b1689 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-15905b1689 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
The Pagure repository was created at https://src.fedoraproject.org/flatpaks/flatseal
FEDORA-FLATPAK-2023-04f87ea1a5 has been submitted as an update to Fedora 37 Flatpaks. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-04f87ea1a5
FEDORA-EPEL-2023-750a4a2151 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-750a4a2151 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-FLATPAK-2023-04f87ea1a5 has been pushed to the Fedora 37 Flatpaks testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-04f87ea1a5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-15905b1689 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-750a4a2151 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-FLATPAK-2023-04f87ea1a5 has been pushed to the Fedora 37 Flatpaks stable repository. If problem still persists, please make note of it in this bug report.