Bug 2160771 - Review Request: flatseal - Manage Flatpak permissions
Summary: Review Request: flatseal - Manage Flatpak permissions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-13 16:21 UTC by Yaakov Selkowitz
Modified: 2023-02-02 02:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-31 01:56:58 UTC
Type: ---
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 5227730 to 5283032 (1.24 KB, patch)
2023-01-22 19:52 UTC, Jakub Kadlčík
no flags Details | Diff

Description Yaakov Selkowitz 2023-01-13 16:21:49 UTC
Spec URL: https://yselkowitz.fedorapeople.org/flatseal.spec
SRPM URL: https://yselkowitz.fedorapeople.org/SRPMS/flatseal-1.8.1-1.fc38.src.rpm
Description: Flatseal is a graphical utility to review and modify permissions from your Flatpak applications.
Fedora Account System Username: yselkowitz

Comment 1 Jakub Kadlčík 2023-01-13 16:42:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5227730
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2160771-flatseal/fedora-rawhide-x86_64/05227730-flatseal/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Neal Gompa 2023-01-15 05:39:03 UTC
Taking this review.

Comment 3 Yaakov Selkowitz 2023-01-22 17:32:00 UTC
Are you still planning on taking this review?

Comment 4 Neal Gompa 2023-01-22 17:38:01 UTC
Initial spec review:

> Source0:        %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz

This has tags, so use those instead: "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz"

> desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
> 
> appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml

These should go into %check for clarity.

Comment 5 Yaakov Selkowitz 2023-01-22 18:03:57 UTC
(In reply to Neal Gompa from comment #4)
> Initial spec review:
> 
> > Source0:        %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz
> 
> This has tags, so use those instead:
> "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz"

The packaging guidelines say otherwise, since git tags are not immutable:

https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags

> > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
> > 
> > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml
> 
> These should go into %check for clarity.

The guidelines allow either:

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage

https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage

Comment 6 Neal Gompa 2023-01-22 18:21:00 UTC
(In reply to Yaakov Selkowitz from comment #5)
> (In reply to Neal Gompa from comment #4)
> > Initial spec review:
> > 
> > > Source0:        %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz
> > 
> > This has tags, so use those instead:
> > "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz"
> 
> The packaging guidelines say otherwise, since git tags are not immutable:
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
> #_git_tags
> 

It definitely does not say that. It only mentions screwiness with how Bitbucket works.

> > > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
> > > 
> > > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml
> > 
> > These should go into %check for clarity.
> 
> The guidelines allow either:
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_desktop_file_install_usage
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
> #_app_data_validate_usage

I guess, though checks like this should be in %check...

Comment 7 Yaakov Selkowitz 2023-01-22 19:46:09 UTC
Spec URL: https://yselkowitz.fedorapeople.org/flatseal.spec
SRPM URL: https://yselkowitz.fedorapeople.org/SRPMS/flatseal-1.8.1-1.fc38.src.rpm
Description: Flatseal is a graphical utility to review and modify permissions from your Flatpak applications.
Fedora Account System Username: yselkowitz

Comment 8 Jakub Kadlčík 2023-01-22 19:52:37 UTC
Created attachment 1939881 [details]
The .spec file difference from Copr build 5227730 to 5283032

Comment 9 Jakub Kadlčík 2023-01-22 19:52:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5283032
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2160771-flatseal/fedora-rawhide-x86_64/05283032-flatseal/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 10 Neal Gompa 2023-01-22 20:35:14 UTC
Review notes:

* Package naming follows packaging guidelines
* Package builds and installs
* Package has no serious rpmlint issues
* Package licensing is handled correctly

PACKAGE APPROVED.

Comment 11 Fedora Admin user for bugzilla script actions 2023-01-22 21:19:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/flatseal

Comment 12 Fedora Update System 2023-01-23 00:11:28 UTC
FEDORA-2023-15905b1689 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-15905b1689

Comment 13 Fedora Update System 2023-01-23 01:01:56 UTC
FEDORA-EPEL-2023-750a4a2151 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-750a4a2151

Comment 14 Fedora Update System 2023-01-23 01:56:49 UTC
FEDORA-2023-15905b1689 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-15905b1689 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-15905b1689

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Admin user for bugzilla script actions 2023-01-23 20:30:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/flatpaks/flatseal

Comment 16 Fedora Update System 2023-01-23 21:39:53 UTC
FEDORA-FLATPAK-2023-04f87ea1a5 has been submitted as an update to Fedora 37 Flatpaks. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-04f87ea1a5

Comment 17 Fedora Update System 2023-01-25 02:01:31 UTC
FEDORA-EPEL-2023-750a4a2151 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-750a4a2151

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2023-01-25 02:50:07 UTC
FEDORA-FLATPAK-2023-04f87ea1a5 has been pushed to the Fedora 37 Flatpaks testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-04f87ea1a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2023-01-31 01:56:58 UTC
FEDORA-2023-15905b1689 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2023-02-02 00:37:48 UTC
FEDORA-EPEL-2023-750a4a2151 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2023-02-02 02:20:34 UTC
FEDORA-FLATPAK-2023-04f87ea1a5 has been pushed to the Fedora 37 Flatpaks stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.