Copr build:
https://copr.fedorainfracloud.org/coprs/build/5238030
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161113-libopenshot/srpm-builds/05238030/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

libopenshot-audio is now imported into Fedora, can you review this now?

Thanks. Will do.

Review done on Fedora Rawhide using
mock  -N -n --postinstall ./temp/libopenshot-audio-0.3.0-2.fc37.src.rpm
fedora-review -n libopenshot -o="-n -N"

with files downloaded locally as libopenshot-audio was not yet available from repositories. 

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GNU Lesser General Public License, Version 3", "*No copyright*
     GNU Lesser General Public License, Version 3", "GNU Lesser General
     Public License, Version 3 Creative Commons CC0 1.0 Creative Commons
     Attribution 3.0", "*No copyright* BSD 3-Clause License", "Creative
     Commons Attribution 3.0", "*No copyright* Creative Commons CC0 1.0",
     "*No copyright* MIT License", "Unknown or generated", "BSD 3-Clause
     License", "MIT License". 24 files have unknown license. Detailed
     output of licensecheck in /home/fedora/review-
     libopenshot/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define _lto_cflags %{nil}
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 3.5 starting (python version = 3.11.1, NVR = mock-3.5-2.fc38)...
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.5
INFO: Mock Version: 3.5
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.5
INFO: Mock Version: 3.5
Finish: chroot init
INFO: installing package(s): /builddir/libopenshot-devel-0.3.0-3.fc38.aarch64.rpm /builddir/libopenshot-debuginfo-0.3.0-3.fc38.aarch64.rpm /builddir/libopenshot-0.3.0-3.fc38.aarch64.rpm /builddir/libopenshot-debugsource-0.3.0-3.fc38.aarch64.rpm /builddir/ruby-libopenshot-0.3.0-3.fc38.aarch64.rpm /builddir/python3-libopenshot-0.3.0-3.fc38.aarch64.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 54cfc20cc9f846b8b2c46bad03f31d39 -D /var/lib/mock/fedora-rawhide-aarch64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.rjctc34a:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-aarch64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$  --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-aarch64/root/ --releasever 38 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/libopenshot-devel-0.3.0-3.fc38.aarch64.rpm /builddir/libopenshot-debuginfo-0.3.0-3.fc38.aarch64.rpm /builddir/libopenshot-0.3.0-3.fc38.aarch64.rpm /builddir/libopenshot-debugsource-0.3.0-3.fc38.aarch64.rpm /builddir/ruby-libopenshot-0.3.0-3.fc38.aarch64.rpm /builddir/python3-libopenshot-0.3.0-3.fc38.aarch64.rpm --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: libopenshot-0.3.0-3.fc38.aarch64.rpm
          libopenshot-devel-0.3.0-3.fc38.aarch64.rpm
          python3-libopenshot-0.3.0-3.fc38.aarch64.rpm
          ruby-libopenshot-0.3.0-3.fc38.aarch64.rpm
          libopenshot-debuginfo-0.3.0-3.fc38.aarch64.rpm
          libopenshot-debugsource-0.3.0-3.fc38.aarch64.rpm
          libopenshot-0.3.0-3.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpuf5g3hfi')]
checks: 31, packages: 7

python3-libopenshot.aarch64: W: no-documentation
ruby-libopenshot.aarch64: W: no-documentation
 7 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 3.0 s 




Unversioned so-files
--------------------
python3-libopenshot: /usr/lib64/python3.11/site-packages/_openshot.so
ruby-libopenshot: /usr/lib64/ruby/vendor_ruby/openshot.so

Source checksums
----------------
https://github.com/OpenShot/libopenshot/archive/v0.3.0/libopenshot-0.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : 5b289432b1209f11fe60c17c07e9365ab62e3074dcc7d50996fc816dfe54a282
  CHECKSUM(SHA256) upstream package : 5b289432b1209f11fe60c17c07e9365ab62e3074dcc7d50996fc816dfe54a282


Requires
--------
libopenshot (rpmlib, GLIBC filtered):
    ld-linux-aarch64.so.1()(64bit)
    libMagick++-7.Q16HDRI.so.5()(64bit)
    libMagickCore-7.Q16HDRI.so.10()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libavcodec.so.59()(64bit)
    libavcodec.so.59(LIBAVCODEC_59)(64bit)
    libavformat.so.59()(64bit)
    libavformat.so.59(LIBAVFORMAT_59)(64bit)
    libavutil.so.57()(64bit)
    libavutil.so.57(LIBAVUTIL_57)(64bit)
    libbabl-0.1.so.0()(64bit)
    libbabl-0.1.so.0(V0_1_0)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgomp.so.1()(64bit)
    libgomp.so.1(GOMP_1.0)(64bit)
    libgomp.so.1(GOMP_4.0)(64bit)
    libgomp.so.1(OMP_1.0)(64bit)
    libjsoncpp.so.25()(64bit)
    libm.so.6()(64bit)
    libopencv_calib3d.so.407()(64bit)
    libopencv_core.so.407()(64bit)
    libopencv_dnn.so.407()(64bit)
    libopencv_imgproc.so.407()(64bit)
    libopencv_tracking.so.407()(64bit)
    libopencv_video.so.407()(64bit)
    libopenshot-audio.so.9()(64bit)
    libprotobuf.so.30()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libswresample.so.4()(64bit)
    libswresample.so.4(LIBSWRESAMPLE_4)(64bit)
    libswscale.so.6()(64bit)
    libswscale.so.6(LIBSWSCALE_6)(64bit)
    libzmq.so.5()(64bit)
    rtld(GNU_HASH)

libopenshot-devel (rpmlib, GLIBC filtered):
    libopenshot(aarch-64)
    libopenshot.so.23()(64bit)

python3-libopenshot (rpmlib, GLIBC filtered):
    ld-linux-aarch64.so.1()(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libjsoncpp.so.25()(64bit)
    libopencv_core.so.407()(64bit)
    libopenshot(aarch-64)
    libopenshot-audio.so.9()(64bit)
    libopenshot.so.23()(64bit)
    libpython3.11.so.1.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    python(abi)
    rtld(GNU_HASH)

ruby-libopenshot (rpmlib, GLIBC filtered):
    ld-linux-aarch64.so.1()(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libjsoncpp.so.25()(64bit)
    libopencv_core.so.407()(64bit)
    libopenshot(aarch-64)
    libopenshot-audio.so.9()(64bit)
    libopenshot.so.23()(64bit)
    libruby.so.3.2()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

libopenshot-debuginfo (rpmlib, GLIBC filtered):

libopenshot-debugsource (rpmlib, GLIBC filtered):



Provides
--------
libopenshot:
    libopenshot
    libopenshot(aarch-64)
    libopenshot.so.23()(64bit)

libopenshot-devel:
    libopenshot-devel
    libopenshot-devel(aarch-64)

python3-libopenshot:
    python-libopenshot
    python3-libopenshot
    python3-libopenshot(aarch-64)
    python3.11-libopenshot

ruby-libopenshot:
    ruby-libopenshot
    ruby-libopenshot(aarch-64)

libopenshot-debuginfo:
    debuginfo(build-id)
    libopenshot-debuginfo
    libopenshot-debuginfo(aarch-64)
    libopenshot.so.0.3.0-0.3.0-3.fc38.aarch64.debug()(64bit)

libopenshot-debugsource:
    libopenshot-debugsource
    libopenshot-debugsource(aarch-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -n libopenshot -o=-n -N
Buildroot used: fedora-rawhide-aarch64
Active plugins: Shell-api, Generic, Python, C/C++
Disabled plugins: R, fonts, SugarActivity, Ocaml, Haskell, Java, Perl, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


COMMENTS:
a) Once Catch2 is packaged, it would be good to enable tests
b) Can ThirdParty directory be removed to be sure bundled JsonCPP is not used? The files 
c) The file sintel_trailer-720p.mp4 is not packaged

Files: examples/sintel_trailer-720p.mp4
Copyright: © copyright Blender Foundation | durian.blender.org
License: CC-BY-3.0

Thus the CC-BY-3.0 license is not needed.

d) JsonCPP is brought in as a dependency, so license ( CC0-1.0 or MIT ) can be removed

Files: thirdparty/jsoncpp/*
Copyright: Copyright (c) 2007-2010 by Baptiste Lepi
lleur and
The JsonCpp Authors
License: CC0-1.0 or MIT

e) Installed libraries are libopenshot.so.0.3.0  and libopenshot.so.23 would have expected
libopenshot.so.0.3.0  libopenshot.so.0
can 
%global soversion 23
be updated to
%global soversion 0

f) Can
%define _lto_cflags %{nil}
be changed to 
%global _lto_cflags %{nil}
if it is still needed

Catch2 should be available shortly:
https://src.fedoraproject.org/rpms/Catch2

(In reply to Benson Muite from comment #5)
> Catch2 should be available shortly:
> https://src.fedoraproject.org/rpms/Catch2

This was already in Fedora as catch: https://src.fedoraproject.org/rpms/catch

What's the current status? It looks like this review has stalled out?

Taking over review.

License:        LGPL-3.0-or-later and BSD-3-Clause and (MIT or CC0-1.0) and CC-BY-3.0

You should drop "and (MIT or CC0-1.0)" from License:, because it refers to jsoncpp, which is unbundled.

You should either drop CC-BY-3.0 as well or include the examples/sintel_trailer-720p.mp4 which this license refers to.

Once the above two are fixed, this package is APPROVED.

Please delete third_party/jsoncpp in %prep and do try to enable tests now that catch is in Fedora.

And these would be nice to have.

Updated with review comments addressed:

Spec URL: https://ngompa.fedorapeople.org/for-review/libopenshot.spec
SRPM URL: https://ngompa.fedorapeople.org/for-review/libopenshot-0.3.0-4.fc38.src.rpm

Looks good, APPROVED now. Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/libopenshot

FEDORA-2023-b0d8ea5dee has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b0d8ea5dee

FEDORA-2023-a6470f15d9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a6470f15d9

FEDORA-2023-a6470f15d9 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-b0d8ea5dee has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.