Bug 2161412 - tbb: FTBFS in Fedora Rawhide
Summary: tbb: FTBFS in Fedora Rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: tbb
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
Assignee: Thomas Rodgers
QA Contact: Fedora Extras Quality Assurance
URL: https://koschei.fedoraproject.org/pac...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-16 20:45 UTC by Mattias Ellert
Modified: 2023-01-24 08:36 UTC (History)
4 users (show)

Fixed In Version: tbb-2020.3-14.fc38
Clone Of:
Environment:
Last Closed: 2023-01-24 08:36:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch that fixes the issue (454 bytes, patch)
2023-01-16 21:48 UTC, Mattias Ellert
no flags Details | Diff

Description Mattias Ellert 2023-01-16 20:45:08 UTC
Description of problem:
Package tbb fails to build from source in Fedora Rawhide.

Version-Release number of selected component (if applicable):
2020.3-12.fc37

Steps to Reproduce:
koji build --scratch f38 tbb-2020.3-12.fc37.src.rpm

Additional info:
This package is tracked by Koschei. See:
https://koschei.fedoraproject.org/package/tbb

The failure started when gcc was update to vrsion 13 in rawhide.

In file included from ../../src/tbb/scheduler_common.h:39,
                 from ../../src/tbb/observer_proxy.h:22,
                 from ../../src/tbb/observer_proxy.cpp:21:
../../include/tbb/task.h:300:20: error: declaration of 'tbb::task& tbb::internal::task_prefix::task()' changes meaning of 'task' [-fpermissive]
  300 |         tbb::task& task() {return *reinterpret_cast<tbb::task*>(this+1);}
      |                    ^~~~
../../include/tbb/task.h:252:9: note: used here to mean 'class tbb::task'
  252 |         task* next_offloaded;
      |         ^~~~
../../include/tbb/task.h:43:7: note: declared here
   43 | class task;
      |       ^~~~

Comment 1 Mattias Ellert 2023-01-16 21:48:02 UTC
Created attachment 1938488 [details]
Patch that fixes the issue

Scratch build with proposed patch applied.

https://koji.fedoraproject.org/koji/taskinfo?taskID=96218649

Comment 2 Thomas Rodgers 2023-01-17 02:41:53 UTC
I stumbled on this last month testing the parallel algorithms in libstdc++. I have pushed a fix to rawhide.

Scratch build -

https://koji.fedoraproject.org/koji/taskinfo?taskID=96229330

Comment 3 Mattias Ellert 2023-01-17 09:24:43 UTC
Could you do a non-scratch build for rawhide. A scratch build doesn't fix FTBFS failures in other packages that fail because they include the broken tbb header.

PS. The patch that was checked in to git has a tab in it.

Comment 4 Thomas Rodgers 2023-01-17 19:18:41 UTC
Build -

https://koji.fedoraproject.org/koji/taskinfo?taskID=96257509

Fixed the errant tab in the patch


Note You need to log in before you can comment on or make changes to this bug.