This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2161424 - FTBFS: librsvg2 has errors in cssparser->procedural-masquerade with Rust 1.66
Summary: FTBFS: librsvg2 has errors in cssparser->procedural-masquerade with Rust 1.66
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: librsvg2
Version: 8.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Tomas Popela
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-16 21:56 UTC by Josh Stone
Modified: 2023-06-20 10:46 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-20 10:46:29 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+


Attachments (Terms of Use)
future-incompatibilities report as of Rust 1.62 (9.32 KB, text/plain)
2023-01-16 21:56 UTC, Josh Stone
no flags Details
Upgrade to procedural-masquerade 0.1.7 (11.95 KB, patch)
2023-01-16 21:58 UTC, Josh Stone
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Github rust-lang rust issues 83125 0 None open Tracking Issue for `proc_macro_back_compat` 2023-01-16 21:56:17 UTC
Github rust-lang rust pull 94063 0 None Merged Only apply `ProceduralMasquerade` hack to older versions of `rental` 2023-01-16 21:56:17 UTC
Github servo rust-cssparser pull 274 0 None Merged Make procedural-masquerade resilient to macro input pretty-printing changes 2023-01-16 21:56:17 UTC
Red Hat Issue Tracker   RHEL-635 0 None None None 2023-06-20 10:46:28 UTC
Red Hat Issue Tracker RHELPLAN-145251 0 None None None 2023-01-16 21:56:48 UTC

Description Josh Stone 2023-01-16 21:56:18 UTC
Created attachment 1938489 [details]
future-incompatibilities report as of Rust 1.62

Description of problem:
librsvg2 hits several "error: proc-macro derive panicked" when building with Rust 1.66.

Version-Release number of selected component (if applicable):
librsvg2-2.42.7-4.el8

How reproducible:
100%

Steps to Reproduce:
1. Upgrade to Rust 1.66 (bug 2123899)
2. Rebuild the librsvg2 rpm.

Actual results:
Several errors such as this:

error: proc-macro derive panicked
   --> /builddir/build/BUILD/librsvg-2.42.7/vendor/cssparser/src/macros.rs:39:17
    |
39  |                   cssparser_internal__assert_ascii_lowercase__max_len!( $( $match_body )* )
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /builddir/build/BUILD/librsvg-2.42.7/vendor/cssparser/src/color.rs:213:31
    |
213 |                   let degrees = match_ignore_ascii_case! { &*unit,
    |  _______________________________-
214 | |                     "deg" => v,
215 | |                     "grad" => v * 360. / 400.,
216 | |                     "rad" => v * 360. / (2. * PI),
217 | |                     "turn" => v * 360.,
218 | |                     _ => return Err(location.new_unexpected_token_error(Token::Ident(unit.clone()))),
219 | |                 };
    | |_________________- in this macro invocation
    |
    = help: message: expected suffix ").0," not found in "#[allow(unused)] enum ProceduralMasqueradeDummyType\n{\n    Input =\n    (0, stringify!\n    (\"deg\" => v, \"grad\" => v * 360. / 400., \"rad\" => v * 360. / (2. * PI),\n    \"turn\" => v * 360., _ => return\n    Err(location.new_unexpected_token_error(Token ::\n    Ident(unit.clone()))),)).0\n}"
    = note: this error originates in the macro `match_ignore_ascii_case` (in Nightly builds, run with -Z macro-backtrace for more info)


Expected results:
A successful rebuild.

Additional info:
The errors are in the vendored cssparser crate, but they actually stem from its dependency on procedural-masquerade 0.1.5, which made improper assumptions about macro tokenization, fixed in 0.1.7. The compiler has been maintaining a crude hack to avoid breaking this, until folks could upgrade their dependencies, and I have attached the future-incompatibilities report from Rust 1.62 for reference. Upstream has reduced the scope of that compiler hack as of Rust 1.66.

Comment 1 Josh Stone 2023-01-16 21:58:21 UTC
Created attachment 1938490 [details]
Upgrade to procedural-masquerade 0.1.7

This patch upgrades the lockfile and vendored crate to procedural-masquerade 0.1.7.


Note You need to log in before you can comment on or make changes to this bug.