Spec URL: https://v02460.fedorapeople.org/rust-pyo3-log.spec SRPM URL: https://v02460.fedorapeople.org/rust-pyo3-log-0.7.0-3.fc38.src.rpm Description: Logging bridge from pyo3 native extension to python Fedora Account System Username: v02460
Copr build: https://copr.fedorainfracloud.org/coprs/build/5240870 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2161739-rust-pyo3-log/fedora-rawhide-x86_64/05240870-rust-pyo3-log/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Two quick comments: > echo 'python3-devel' This should not be necessary - pyo3 (via pyo3-ffi) should already pull in python3-devel. There have also been new releases of the pyo3-log crate (v0.8.0 and v0.8.1), but it looks like matrix-synapse depends on v0.7, so I would continue with the review of v0.7.0 and only update to a later version once matrix-synapse requires it?
That sounds good! And you are right – I removed the dependency on python3-devel. New version: Spec URL: https://v02460.fedorapeople.org/rust-pyo3-log.spec SRPM URL: https://v02460.fedorapeople.org/rust-pyo3-log-0.7.0-4.fc38.src.rpm
Thanks, looks good to me now! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass ! latest version of the crate is packaged (we need 0.7.x right now) - license matches upstream specification and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - enable tracking of the package in koschei for all relevant branches
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pyo3-log
FEDORA-2023-ea818e4902 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ea818e4902
FEDORA-2023-ea818e4902 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-2dedbef650 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2dedbef650
FEDORA-2023-08e065d25d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-08e065d25d
FEDORA-2023-08e065d25d has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-08e065d25d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-2dedbef650 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-2dedbef650 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-2dedbef650 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-2dedbef650 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
> There have also been new releases of the pyo3-log crate (v0.8.0 and v0.8.1), but it looks like matrix-synapse > depends on v0.7, so I would continue with the review of v0.7.0 and only update to a later version once > matrix-synapse requires it? It looks like pyo3-log @ 0.8.1 changed to a range for it's pyo3 dependency. Not having that range, this pyo3-log does not appear to be compatible across available Fedora pyo3 versions (0.15/0.16/0.17). A quick test here can be done with `cargo new ...` then `cargo add "pyo3@..."` and `cargo add "pyo3-log@..."`. This package, at 0.7.0, is compatible with pyo3 0.17. At 0.8.1 it could work across all available Fedora versions.
Well, for now, the only thing that matters is that it's compatible with what matrix-synapse needs. As soon as they update their pyo3-log dependency, we can do so, too.
Ok. If a project needs to use pyo3-log with a currently unsupported pyo3 (0.15), should that request be in a new bz issue?
Yes. This is the ticket for the initial package review, which has concluded. If you need a different version, please file a new bug against the Fedora / rust-pyo3-log component. As far as I can tell (since you haven't given me any specifics of what you're working on), we have two options here: 1. Update rust-pyo3-log to v0.8.1, and add a rust-pyo3-log0.7 compat package that will be used by matrix-synapse. 2. Add a rust-pyo3-log0.5 compat package (which was the version originally targeted at pyo3 0.15). I'm not sure how "compatible" pyo3-log 0.8 really is with older PyO3 versions, but if upstream claims it is ... well. However: At this point, I'd rather not package any more software that depends on PyO3 v0.15. That version has been obsolete for over a year, and I'd rather start to *drop* software that depends on it than add more ... What are you working on that only supports pyo3 0.15?
> If you need a different version, please file a new bug against the Fedora / rust-pyo3-log component. Ok, thanks. I will note that for future reference. Wasn't trying to be vague, but wasn't sure if this was the right place for my details. Just wanted to quote that comment of yours describing the reasoning behind selecting 0.7, for context. > What are you working on that only supports pyo3 0.15? The other project is fapolicy-analyzer, which needs to support Python 3.6, which Pyo3 dropped support for starting @ 0.16. My Rust components are just now being bridged into the Python logger, otherwise I would have commented on this sooner. > I'm not sure how "compatible" pyo3-log 0.8 really is with older PyO3 versions I can't speak for much other than having plugged 0.8.1 into my project and it (1) compiles (2) writes the logs as expected. Happy to help provide additional feedback if requested.
I've checked, and the latest matrix-synapse release also started depending on v0.8.1. Since nothing in Fedora currently depends on pyo3-log, I've gone ahead and submitted updates for the package. :)
Thank you, this is very helpful! I had a bz request coming for this, then one of my own bugs skipped line :/
FEDORA-2023-08e065d25d has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.