Bug 2162249 - Review Request: gitklient - Git gui client for KDE
Summary: Review Request: gitklient - Git gui client for KDE
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-19 07:44 UTC by Vasiliy Glazov
Modified: 2023-01-19 12:21 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-19 12:21:43 UTC
Type: Bug
Embargoed:
vitaly: fedora-review+


Attachments (Terms of Use)

Description Vasiliy Glazov 2023-01-19 07:44:38 UTC
Spec URL: https://raw.githubusercontent.com/Vascom/gitklient/main/gitklient.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8872/96338872/gitklient-0-1.20230119git0645ced.fc38.src.rpm

Description:
Git gui client for KDE.

Currently this application at development stage. So will packaged only for rawhide.

Comment 1 Jakub Kadlčík 2023-01-19 08:01:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5250866
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2162249-gitklient/fedora-rawhide-x86_64/05250866-gitklient/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Vitaly 2023-01-19 08:12:10 UTC
I will review this package.

Comment 3 Vitaly 2023-01-19 08:46:36 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Creative Commons CC0 1.0", "Unknown or
     generated", "Creative Commons Attribution-ShareAlike 4.0", "*No
     copyright* GNU General Public License, Version 3", "*No copyright* BSD
     3-Clause License", "GNU General Public License, Version 3", "*No
     copyright* GNU Library General Public License, Version 2.0". 137 files
     have unknown license. Detailed output of licensecheck in
     /var/lib/copr-rpmbuild/results/gitklient/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/qt5/plugins/kf5/overlayicon,
     /usr/share/doc/HTML/en/gitklient
[-]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/lib64/qt5/plugins/kf5/overlayicon, /usr/share/doc/HTML,
     /usr/share/doc/HTML/en/gitklient,
     /usr/lib64/qt5/plugins/kf5/kfileitemaction, /usr/share/doc/HTML/en
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 122880 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: gitklient-0-1.20230119git0645ced.fc38.x86_64.rpm
          gitklient-debuginfo-0-1.20230119git0645ced.fc38.x86_64.rpm
          gitklient-debugsource-0-1.20230119git0645ced.fc38.x86_64.rpm
          gitklient-0-1.20230119git0645ced.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpihw1jjgh')]
checks: 31, packages: 4

gitklient.x86_64: W: no-manual-page-for-binary gitklient
gitklient.x86_64: W: no-manual-page-for-binary gitklientdiff
gitklient.x86_64: W: no-manual-page-for-binary gitklientmerge
gitklient.x86_64: W: incoherent-version-in-changelog 0.1.20230119git0645ced ['0-1.20230119git0645ced.fc38', '0-1.20230119git0645ced']
gitklient.x86_64: W: files-duplicate /usr/share/licenses/gitklient/LICENSE /usr/share/licenses/gitklient/COPYING
 4 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.8 s 




Rpmlint (debuginfo)
-------------------
Checking: gitklient-debuginfo-0-1.20230119git0645ced.fc38.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp5d8ysgm8')]
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

gitklient.x86_64: W: no-manual-page-for-binary gitklient
gitklient.x86_64: W: no-manual-page-for-binary gitklientdiff
gitklient.x86_64: W: no-manual-page-for-binary gitklientmerge
gitklient.x86_64: W: incoherent-version-in-changelog 0.1.20230119git0645ced ['0-1.20230119git0645ced.fc38', '0-1.20230119git0645ced']
gitklient.x86_64: W: files-duplicate /usr/share/licenses/gitklient/LICENSE /usr/share/licenses/gitklient/COPYING
 3 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 1.6 s 



Unversioned so-files
--------------------
gitklient: /usr/lib64/qt5/plugins/kf5/kfileitemaction/gitklientitemaction.so
gitklient: /usr/lib64/qt5/plugins/kf5/overlayicon/gitklientoverlayplugin.so

Source checksums
----------------
https://invent.kde.org/sdk/gitklient/-/archive/0645ced7abc8211190e8c600a2dde65df88f87aa/gitklient-0645ced7abc8211190e8c600a2dde65df88f87aa.tar.bz2 :
  CHECKSUM(SHA256) this package     : bd5d6b7c53eceaf2f31a0e9b51bcbcee3511128dbea2eb86a11fbec3b267dbc6
  CHECKSUM(SHA256) upstream package : bd5d6b7c53eceaf2f31a0e9b51bcbcee3511128dbea2eb86a11fbec3b267dbc6


Requires
--------
gitklient (rpmlib, GLIBC filtered):
    /usr/bin/sh
    hicolor-icon-theme
    kf5-filesystem
    libKF5ConfigCore.so.5()(64bit)
    libKF5ConfigGui.so.5()(64bit)
    libKF5ConfigWidgets.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5Crash.so.5()(64bit)
    libKF5DBusAddons.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5KIOCore.so.5()(64bit)
    libKF5KIOGui.so.5()(64bit)
    libKF5KIOWidgets.so.5()(64bit)
    libKF5Parts.so.5()(64bit)
    libKF5Service.so.5()(64bit)
    libKF5SyntaxHighlighting.so.5()(64bit)
    libKF5WidgetsAddons.so.5()(64bit)
    libKF5XmlGui.so.5()(64bit)
    libQt5Concurrent.so.5()(64bit)
    libQt5Concurrent.so.5(Qt_5)(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgitklient.so.0()(64bit)
    libgitklientdiff.so.0()(64bit)
    libgitklientgui.so.0()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

gitklient-debuginfo (rpmlib, GLIBC filtered):

gitklient-debugsource (rpmlib, GLIBC filtered):



Provides
--------
gitklient:
    application()
    application(org.kde.gitklient.desktop)
    application(org.kde.gitklient.diff.desktop)
    application(org.kde.gitklient.merge.desktop)
    gitklient
    gitklient(x86-64)
    libgitklient.so.0()(64bit)
    libgitklientdiff.so.0()(64bit)
    libgitklientgui.so.0()(64bit)
    metainfo()
    metainfo(org.kde.gitklient.appdata.xml)

gitklient-debuginfo:
    debuginfo(build-id)
    gitklient-debuginfo
    gitklient-debuginfo(x86-64)
    libgitklient.so.0.4.0-0-1.20230119git0645ced.fc38.x86_64.debug()(64bit)
    libgitklientdiff.so.0.4.0-0-1.20230119git0645ced.fc38.x86_64.debug()(64bit)
    libgitklientgui.so.0.4.0-0-1.20230119git0645ced.fc38.x86_64.debug()(64bit)

gitklient-debugsource:
    gitklient-debugsource
    gitklient-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gitklient --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: SugarActivity, Perl, Haskell, Java, PHP, Python, Ocaml, R, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Vitaly 2023-01-19 08:52:24 UTC
> %{_defaultdocdir}/HTML/en/gitklient/*

Package should own its docs directory:

%{_defaultdocdir}/HTML/en/%{name}

> %{_libdir}/lib%{name}.so.*
> %{_libdir}/lib%{name}gui.so.*
> %{_libdir}/lib%{name}diff.so.*

Please include soversion number to avoid accidental bumps:

%{_libdir}/lib%{name}.so.0*
%{_libdir}/lib%{name}gui.so.0*
%{_libdir}/lib%{name}diff.so.0*

> License:        GPL-3.0-or-later

License: GPL-3.0-or-later AND GPL-2.0-or-later AND BSD-3-Clause

Comment 5 Vitaly 2023-01-19 08:54:11 UTC
These minor issues can be fixed during import. Package approved.

Comment 6 Vasiliy Glazov 2023-01-19 08:59:12 UTC
Thanks.
I will fix it during import.

Comment 7 Fedora Admin user for bugzilla script actions 2023-01-19 09:00:46 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/gitklient


Note You need to log in before you can comment on or make changes to this bug.