Spec URL: https://raw.githubusercontent.com/Vascom/lightpack/main/lightpack.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3012/96353012/lightpack-5.11.2.31-1.fc38.src.rpm Description Lightpack is a fully open-source and simple hardware implementation of the backlight for any computer. It's a USB content-driven ambient lighting system. Prismatik is an open-source software we buid to control Lightpack devices. It grabs the screen, analyzes the picture, calculates resulting colors, and provides soft and gentle lighting with a Lightpack device. Moreover, you can handle other devices with Prismatik such as Adalight, Ardulight, or even Alienware LightFX system.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5252629 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2162360-lightpack/fedora-rawhide-x86_64/05252629-lightpack/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
I will review this package.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later", "Standard ML of New Jersey License", "*No copyright* MIT License", "*No copyright* GNU General Public License, Version 3", "[generated file]", "*No copyright* [generated file]", "BSD 3-Clause License". 824 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/lightpack/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor, /usr/share/icons/hicolor/22x22/apps [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: lightpack-5.11.2.31-1.fc38.x86_64.rpm lightpack-debuginfo-5.11.2.31-1.fc38.x86_64.rpm lightpack-debugsource-5.11.2.31-1.fc38.x86_64.rpm lightpack-5.11.2.31-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_hjql4w9')] checks: 31, packages: 4 lightpack.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/lightpack/README.md lightpack.x86_64: W: no-manual-page-for-binary Prismatik lightpack.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24) 4 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: lightpack-debuginfo-5.11.2.31-1.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprvtc4tbf')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 lightpack.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/lightpack/README.md lightpack.x86_64: W: no-manual-page-for-binary Prismatik 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.4 s Source checksums ---------------- https://github.com/psieg/Lightpack/archive/refs/tags/5.11.2.31.tar.gz : CHECKSUM(SHA256) this package : f5441bae1f088ae53bbff69f996d2f97307632d10d338b758eaa939d6b4710a9 CHECKSUM(SHA256) upstream package : f5441bae1f088ae53bbff69f996d2f97307632d10d338b758eaa939d6b4710a9 Requires -------- lightpack (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5SerialPort.so.5()(64bit) libQt5SerialPort.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libc.so.6()(64bit) libfftw3f.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) udev lightpack-debuginfo (rpmlib, GLIBC filtered): lightpack-debugsource (rpmlib, GLIBC filtered): Provides -------- lightpack: application() application(prismatik.desktop) lightpack lightpack(x86-64) lightpack-debuginfo: debuginfo(build-id) lightpack-debuginfo lightpack-debuginfo(x86-64) lightpack-debugsource: lightpack-debugsource lightpack-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name lightpack --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: R, Ocaml, Python, Haskell, PHP, Java, SugarActivity, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> License: GPL-3.0-or-later License: GPL-3.0-or-later AND GPL-2.0-or-later AND SMLNJ AND BSD-3-Clause AND MIT > Note: Directories without known owners: /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor, /usr/share/icons/hicolor/22x22/apps Requires: hicolor-icon-theme > Source0: %{url}/archive/refs/tags/5.11.2.31.tar.gz Source0: %{url}/archive/refs/tags/%{version}.tar.gz > %make_build BuildRequires: make > BuildRequires: gnome-shell-extension-appindicator I think it should be a weak dependency.
These minor issues can be fixed during import. Package approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/lightpack