Bug 2162916 - Review Request: rust-nu-test-support - Support for writing Nushell tests
Summary: Review Request: rust-nu-test-support - Support for writing Nushell tests
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-22 00:42 UTC by Michel Lind
Modified: 2023-02-07 20:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-02-07 20:54:27 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-01-22 00:42:33 UTC
Spec URL: https://salimma.fedorapeople.org/rust-nu-test-support.spec
SRPM URL: https://salimma.fedorapeople.org/rust-nu-test-support-0.74.0-1.fc37.src.rpm

Description:
Support for writing Nushell tests.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-01-22 00:46:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5281882
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2162916-rust-nu-test-support/fedora-rawhide-x86_64/05281882-rust-nu-test-support/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Davide Cavalca 2023-01-22 01:02:13 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide (with dependencies from f38-build-side-62106)
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-01-22 03:34:53 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-test-support

Comment 4 Fedora Update System 2023-02-07 20:53:38 UTC
FEDORA-2023-9c32261087 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9c32261087

Comment 5 Fedora Update System 2023-02-07 20:54:27 UTC
FEDORA-2023-9c32261087 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.