Spec URL: http://rpm.greysector.net/extras/chemtool.spec SRPM URL: http://rpm.greysector.net/extras/chemtool-1.6.9-1.src.rpm Description: Chemtool is a program for drawing organic molecules easily and store them in a variety of output formats including as a X bitmap, Xfig, SVG or EPS file. It runs under the X Window System using the GTK widget set.
Created attachment 141574 [details] Mock build log of chemtool 1.6.9-1.fc7 Mockbuild fails on FC-devel i386. Please check the build log attached. NOTE: in mockbuild environ, %{_desktopdir} and etc are not defined!! (I have not yet checked precisely why).
rpm --showrc on FC6 does have it. Anyway, I replaced those macros: http://rpm.greysector.net/extras/chemtool.spec http://rpm.greysector.net/extras/chemtool-1.6.9-2.src.rpm
Created attachment 141586 [details] Mock build log of chemtool 1.6.9-2.fc7 Umm.. still not okay.
etc is defined as %{_sysconfdir} I'm not sure, but you may also need the scriptlet... http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28snippets%29%7C%28script%29#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
Actually I have not yet checked this package precisely as recently I use mockbuild and I will not check the package unless build succeeds...... NOTE: my environ is FC-devel i386.
Created attachment 141588 [details] rpmbuild build log of chemtool 1.6.9-2.fc7 Umm... rpmbuild succeeded. From diff of the two files I attached, it seems that some BR are missing.
Builds in mock devel/x86_64 now. Added those scriptlets, too. http://rpm.greysector.net/extras/chemtool.spec http://rpm.greysector.net/extras/chemtool-1.6.9-3.src.rpm
Created attachment 141615 [details] rpmbuild build log of chemtool 1.6.9-3.fc7 This time mockbuild succeeds, however, rpmbuild fails. From configure and your spec file (1.6.9-3), it seems that if the directory /usr/share/mimelnk or /usr/share/mime-info exists, 'make install' tries to install some extra files. Check your configure option -------------------------------------- --with-kdedir=%{_prefix} \ --with-gnomedir=%{_prefix} -------------------------------------- , around the line 4534-4581 of configure, and the build log by rpmbuild attached. Currently /usr/share/mimelnk are owned by kdelibs and OOo-core (OOo=openoffice.org), /usr/share/mime-info is owned by OOo-core. So if one of these rpms is installed, rpmbuild fails. (Note: /usr/share/mime-info is not owned by gnome-mime-data, however some files under /usr/share/mime-info are owned by gnome-mime-data) You can fix this by either the following. * BuildRequire kdelibs and gnome-mime-data (or OOo-core!) and fix your spec file so that extra files installed by 'make install' are correctly removed * Use 'rm -f' against possibly installed extra files (not 'rm') I think this is the best idea. * Pass the directory which does not exist to configure option. i.e. --with-kdedir=the_directory_which_does_not_seem_to_exist .
Created attachment 141616 [details] rpmbuild build log of chemtool 1.6.9-3.fc7 (correct one) Oops... this is the correct build log.
http://rpm.greysector.net/extras/chemtool.spec http://rpm.greysector.net/extras/chemtool-1.6.9-4.src.rpm Builds both with mock and with plain rpmbuild.
Okay, this time both mockbuild and rpmbuild are okay. Then doing the full review. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Licensing - Well, it seems that this package is licensed under GPL according to several source codes, however, many source codes have no licensing terms. Would you ask upstream to clarify the license (or include GPL document to source tarball)? (currently not a blocker). 2. From http://fedoraproject.org/wiki/Packaging/ScriptletSnippets : * desktop-database - fedora-chemtool.desktop has mimetype keys, ------------------------------------------- MimeType=application/x-chemtool;Application ------------------------------------------- which requires update-desktop-database. 3. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : (= okay) 4. Other things I have noticed: - %doc I think %doc examples/ (i.e. include 'example' directory itself) is better than %doc examples/* .
(In reply to comment #11) > Okay, this time both mockbuild and rpmbuild are okay. > Then doing the full review. > > 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : > > * Licensing > - Well, it seems that this package is licensed under GPL according > to several source codes, however, many source codes have no > licensing terms. Would you ask upstream to clarify the license > (or include GPL document to source tarball)? (currently not a > blocker). Mail sent. > 2. From http://fedoraproject.org/wiki/Packaging/ScriptletSnippets : > * desktop-database > - fedora-chemtool.desktop has mimetype keys, > ------------------------------------------- > MimeType=application/x-chemtool;Application > ------------------------------------------- > which requires update-desktop-database. Done. > 4. Other things I have noticed: > - %doc > I think %doc examples/ (i.e. include 'example' directory itself) > is better than %doc examples/* . Done. http://rpm.greysector.net/extras/chemtool.spec http://rpm.greysector.net/extras/chemtool-1.6.9-5.src.rpm
Okay. -------------------------------------------------------------- This package (chemtool) is APPROVED by me
Imported and built for devel, FC5 and FC6 branches requested. Thank you very much for the review.
Package Change Request ====================== Package Name: chemtool New Branches: EL-5
cvs done.