Spec URL: https://smani.fedorapeople.org/review/mingw-python-pyproject-hooks.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-pyproject-hooks-1.0.0-1.fc38.src.rpm Description: MinGW Python pyproject-hooks library Fedora Account System Username: smani A scratch build currently fails due to the circular mingw-python-build -> mingw-python-pyproject-hooks -> mingw-python-build dependency.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5284741 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2163339-mingw-python-pyproject-hooks/fedora-rawhide-x86_64/05284741-mingw-python-pyproject-hooks/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
I will take this review. Could you take bug 2163563?
I'm not sure how to review this. As you say, the mingw[32/64]-python3-build packages currently fail to install. That means that the BuildRequires for this package cannot be installed. I see that mingw-python-build has a bootstrap mode, but that needs this package. Say that this package is approved. What do you build first, and how? I need to know that so I can do the same locally.
Indeed it is mingw-python-pyproject-hooks which needs a bootstrap logic, not mingw-python-build... I've updated this package. The sequence then is - mingw-python-pyproject-hooks (bootstrap) - mingw-python-build - mingw-python-pyproject-hooks
Using that sequence, the mingw-python-pyproject-hooks bootstrap build succeeds, but the mingw-python-build package fails to build: + /usr/bin/python3.11 -m build -n -w -o dist_win32 * Getting build dependencies for wheel... Traceback (most recent call last): File "/usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_impl.py", line 321, in _call_hook raise BackendUnavailable(data.get('traceback', '')) pyproject_hooks._impl.BackendUnavailable: Traceback (most recent call last): File "/usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 77, in _build_backend obj = import_module(mod_path) ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "<frozen importlib._bootstrap>", line 1206, in _gcd_import File "<frozen importlib._bootstrap>", line 1178, in _find_and_load File "<frozen importlib._bootstrap>", line 1128, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "<frozen importlib._bootstrap>", line 1206, in _gcd_import File "<frozen importlib._bootstrap>", line 1178, in _find_and_load File "<frozen importlib._bootstrap>", line 1142, in _find_and_load_unlocked ModuleNotFoundError: No module named 'flit_core' ERROR Backend 'flit_core.buildapi' is not available. I added BRs for mingw32-python3-flit-core and mingw64-python3-flit-core to a checkout of the mingw-python-build repository and rebuilt. That worked. Full review in the next comment.
This package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 42 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-python3-pyproject-hooks-1.0.0-1.fc38.noarch.rpm mingw64-python3-pyproject-hooks-1.0.0-1.fc38.noarch.rpm mingw-python-pyproject-hooks-1.0.0-1.fc38.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4coz2dap')] checks: 31, packages: 3 mingw32-python3-pyproject-hooks.noarch: W: no-documentation mingw64-python3-pyproject-hooks.noarch: W: no-documentation mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/__init__.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/__init__.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_compat.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_compat.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_impl.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_impl.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/LICENSE /usr/share/licenses/mingw64-python3-pyproject-hooks/LICENSE:/usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/LICENSE mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/__init__.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/__init__.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_compat.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_compat.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_impl.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_impl.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py ================ 3 packages and 0 specfiles checked; 0 errors, 19 warnings, 0 badness; has taken 0.1 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 mingw32-python3-pyproject-hooks.noarch: W: no-documentation mingw64-python3-pyproject-hooks.noarch: W: no-documentation mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/__init__.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/__init__.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_compat.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_compat.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_impl.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_impl.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py mingw32-python3-pyproject-hooks.noarch: W: files-duplicate /usr/i686-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py /usr/i686-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/LICENSE /usr/share/licenses/mingw64-python3-pyproject-hooks/LICENSE:/usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/LICENSE mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/METADATA mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/RECORD mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks-1.0.0.dist-info/WHEEL mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/__init__.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/__init__.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_compat.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_compat.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_impl.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_impl.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/__init__.py mingw64-python3-pyproject-hooks.noarch: W: files-duplicate /usr/x86_64-w64-mingw32/sys-root/mingw/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py /usr/x86_64-w64-mingw32/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py 2 packages and 0 specfiles checked; 0 errors, 19 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pyproject_hooks/pyproject_hooks-1.0.0.tar.gz : CHECKSUM(SHA256) this package : f271b298b97f5955d53fb12b72c1fb1948c22c1a6b70b315c54cedaca0264ef5 CHECKSUM(SHA256) upstream package : f271b298b97f5955d53fb12b72c1fb1948c22c1a6b70b315c54cedaca0264ef5 Requires -------- mingw32-python3-pyproject-hooks (rpmlib, GLIBC filtered): mingw32(python(abi)) mingw64-python3-pyproject-hooks (rpmlib, GLIBC filtered): mingw64(python(abi)) Provides -------- mingw32-python3-pyproject-hooks: mingw32(python3.11dist(pyproject-hooks)) mingw32(python3dist(pyproject-hooks)) mingw32-python3-pyproject-hooks mingw64-python3-pyproject-hooks: mingw64(python3.11dist(pyproject-hooks)) mingw64(python3dist(pyproject-hooks)) mingw64-python3-pyproject-hooks Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2163339 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: Ocaml, Perl, PHP, C/C++, Java, fonts, Haskell, Ruby, R, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python-pyproject-hooks
Thanks for the review!