Spec URL: https://pagure.io/kio-admin/raw/main/f/kio-admin.spec SRPM URL: https://pagure.io/kio-admin/raw/main/f/kio-admin-1.0.0-1.fc38.src.rpm Description: Manage files as administrator using the admin:// KIO protocol Fedora Account System Username: thunderbirdtr
Copr build: https://copr.fedorainfracloud.org/coprs/build/5284947 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2163424-kio-admin/fedora-rawhide-x86_64/05284947-kio-admin/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
@jkadlcik I know I sent too quickly I updated spec and srpm so It should be works now.
Taking this review.
Spec review: > License: GPLv2+ and BSD and GPLv3+ This needs to be "(GPL-2.0-only or GPL-3.0-only) and BSD-3-Clause and CC0-1.0 and FSFAP"
License done.
> BuildRequires: qt5-qtbase-devel For consistency, this should be "cmake(Qt5Core)"
> %lang_package Drop this, we don't need it. You're putting all the lang files in the main package anyway.
(In reply to Neal Gompa from comment #6) > > BuildRequires: qt5-qtbase-devel > > For consistency, this should be "cmake(Qt5Core)" Done (In reply to Neal Gompa from comment #7) > > %lang_package > > > Drop this, we don't need it. You're putting all the lang files in the main > package anyway. Done
You're missing "BuildRequires: gcc-c++" rpmlint issues: > kio-admin.src: E: description-line-too-long kio-admin implements a new protocol "admin:///" which gives administrative access > kio-admin.x86_64: E: description-line-too-long kio-admin implements a new protocol "admin:///" which gives administrative access
(In reply to Neal Gompa from comment #9) > You're missing "BuildRequires: gcc-c++" > > rpmlint issues: > > > kio-admin.src: E: description-line-too-long kio-admin implements a new protocol "admin:///" which gives administrative access > > kio-admin.x86_64: E: description-line-too-long kio-admin implements a new protocol "admin:///" which gives administrative access Done
I don't see a fix for the description?
Desc fixed.
Okay, everything looks good now. PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/kio-admin
Package is now in repositories, closing review.