Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2163796

Summary: [leapp] false positive risk factor on ceph volumes when ceph-osd is missing
Product: Red Hat Enterprise Linux 7 Reporter: Christophe Besson <cbesson>
Component: leapp-repositoryAssignee: Leapp team <leapp-notifications>
Status: CLOSED ERRATA QA Contact: Archana Singh <arcsingh>
Severity: low Docs Contact:
Priority: low    
Version: 7.9CC: lob+redhat, mmacura, pstodulk, sgolovat, system-engineering
Target Milestone: rcKeywords: OtherQA, Patch, Reproducer, WorkAround
Target Release: ---Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: leapp-repository-0.17.0-7.el7_9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-17 15:00:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Christophe Besson 2023-01-24 12:55:36 UTC
Description of problem:
A customer reported they got a high risk factor while trying to retrieve the Ceph volume list. This is only a ceph client.

The actor in question should not be executed:
- there is no ceph-osd service on this machine (package missing)
- the ceph-volume binary itself comes from this package

Version-Release number of selected component (if applicable):
leapp-upgrade-el7toel8-0.17.0-1.el7_9.noarch

How reproducible:
Always as per the customer (didn't take the time to check but seems obvious)

Steps to Reproduce:
Install ceph client packages from rhel-7-server-rhceph-4-tools-rpms
# yum install ceph-base ceph-common ceph-fuse ceph-selinux libcephfs2 python-cephfs python-ceph-argparse

Actual results:
----------------------------------------
Risk Factor: high
Title: Could not retrieve the ceph volumes list
Summary: {"details": "An exception raised while retrieving ceph volumes Command ['ceph-volume', 'lvm', 'list', '--format', 'json'] failed with exit code 1."}
Key: 4b80fff43fb74e1e2bd5d681d3ae7c2790ebaab4
----------------------------------------

Expected results:
Stop the execution of this actor if ceph-osd package is missing (or not in a container).

Additional info:
There is no need for a workaround as it is not inhibiting the IPU.
To not have such an item in the leapp report, simply remove the actor directory (/usr/share/leapp-repository/repositories/system_upgrade/common/actors/cephvolumescan).

Comment 3 Christophe Besson 2023-01-24 13:03:55 UTC
Suggested a small patch but can't test it (PR #1011).

Comment 4 Petr Stodulka 2023-01-24 13:47:24 UTC
Hi Chris, this has been already fixed in the upstream via
  https://github.com/oamg/leapp-repository/pull/986
the the related BZ for RHEL 8 is bug 2141393. In both cases,
the internal testing builds should already contain the fix.

Adding @sgolovat to Cc.

Comment 8 Christophe Besson 2023-01-24 15:22:28 UTC
Hi Petr

I didn't see this other patch
but it does not prevent the false positive warning I mentioned.

the patch fixes the issue if ceph-osd is missing from the container.

if there is no container named ceph-osd, the actor checks on the host itself...

Comment 9 Christophe Besson 2023-01-24 16:16:16 UTC
Updated the PR instead. Reset this bug as NEW.

Comment 10 Petr Stodulka 2023-01-25 12:14:34 UTC
I see. Thank you Chris for the correction. The upstream PR has been merged, so the fix will be part of the next release. Chris, is customer willing to test the fixed build?

Comment 12 Christophe Besson 2023-01-25 12:47:29 UTC
Will ask.

Comment 16 Christophe Besson 2023-02-06 14:32:17 UTC
Hi Petr, it's marked as fixed in c#11
Fixed In Version: leapp-repository-0.17.0-5.el7_9 → leapp-repository-0.17.0-6.el7_9

But that version I got from brew does not include the patch!

Comment 17 Petr Stodulka 2023-02-07 10:12:03 UTC
Hi Chris,
my apologize - you are right. I've created the new build leapp-repository-0.17.0-7.el7_9 which finally contains the fix - from the building process:
~~~
...
Patch #72 (0072-check-ceph-osd-package-presence.patch):
+ /usr/bin/patch --no-backup-if-mismatch -f -p1 --fuzz=0
patching file repos/system_upgrade/common/actors/cephvolumescan/libraries/cephvolumescan.py
...
~~~

Comment 19 Christophe Besson 2023-02-08 13:10:48 UTC
Reported as working by the customer with leapp-repository-0.17.0-7.el7_9

Comment 22 errata-xmlrpc 2023-05-17 15:00:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (leapp and leapp-repository bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:3187