Bug 2164360 - nsiswrapper dies
Summary: nsiswrapper dies
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mingw-nsiswrapper
Version: 37
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-25 10:46 UTC by nvwarr
Modified: 2023-02-03 01:25 UTC (History)
1 user (show)

Fixed In Version: mingw-nsiswrapper-12-1.fc38 mingw-nsiswrapper-12-1.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-25 13:09:18 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description nvwarr 2023-01-25 10:46:50 UTC
Description of problem:

Died at /usr/bin/nsiswrapper line 516.

Version-Release number of selected component (if applicable):

mingw32-nsiswrapper-11-9.fc37.noarch

How reproducible:

Always

Steps to Reproduce:
1. Run nsiswrapper on a cross-compiled windows executable

Actual results:

fails with the message "Died at /usr/bin/nsiswrapper line 516."

Expected results:

Should generate a .nsi script

Additional info:

The problem is that the method for generating the list of system dlls, suggested by Ivan Romanov a decade ago (https://bugzilla.redhat.com/show_bug.cgi?id=856354#c6), which still worked for Fedora 36, no longer works. It gives no output at all.

The reason is that the provides information is no longer in mingw32-filesystem but mingw32-crt.

Adding mingw32-crt and mingw64-crt to line 501 of /usr/bin/nsiswrapper solves the problem.

Comment 1 Richard W.M. Jones 2023-01-25 11:25:48 UTC
$ rpm -q --provides mingw32-crt | grep '\.dll' | sed "s/mingw32(//" | sed "s/)//"
aclui.dll
activeds.dll
adsldpc.dll
advapi32.dll
apcups.dll
api-ms-win-appmodel-runtime-l1-1-0.dll
api-ms-win-appmodel-runtime-l1-1-1.dll
api-ms-win-core-com-l1-1-0.dll
api-ms-win-core-com-l1-1-1.dll
api-ms-win-core-com-l2-1-1.dll
[etc]

Indeed it does.  Can you suggest a fix via:
https://src.fedoraproject.org/rpms/mingw-nsiswrapper/pull-requests

Comment 2 nvwarr 2023-01-25 11:36:12 UTC
I'm not sure how to do that. I just added mingw32-crt and mingw64-crt to the list of rpms that it runs rpm -q --provided on. It's a pretty trivial fix.

Comment 3 Fedora Update System 2023-01-25 13:08:21 UTC
FEDORA-2023-4a01949c2b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4a01949c2b

Comment 4 Fedora Update System 2023-01-25 13:09:18 UTC
FEDORA-2023-4a01949c2b has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2023-01-25 15:16:17 UTC
FEDORA-2023-130329bf87 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-130329bf87

Comment 6 Fedora Update System 2023-01-26 02:26:10 UTC
FEDORA-2023-130329bf87 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-130329bf87`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-130329bf87

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-02-03 01:25:14 UTC
FEDORA-2023-130329bf87 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.