Bug 2164364 - annobin doesn't pass it own annocheck
Summary: annobin doesn't pass it own annocheck
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: annobin
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-01-25 11:09 UTC by Václav Kadlčík
Modified: 2024-01-19 15:04 UTC (History)
7 users (show)

Fixed In Version: annobin-11.07-2.fc38
Clone Of:
Environment:
Last Closed: 2024-01-19 15:04:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Václav Kadlčík 2023-01-25 11:09:00 UTC
Description of problem:

annobin doesn't pass it own annocheck. As a consequence,
fedora-ci.koji-build.rpminspect.static-analysis fails
in Fedora gating, see e.g.
  https://bodhi.fedoraproject.org/updates/FEDORA-2023-8a88444e9e


Version-Release number of selected component (if applicable):

annobin-11.07-1.fc38 in Rawhide
annobin-11.06-2.fc37
annobin-11.06-2.fc36


Steps to Reproduce:

1. koji download-build --debuginfo annobin-11.06-2.fc36
2. mkdir debug_files
3. for i in *debuginfo*; do rpm2cpio <$i | cpio -id -D debug_files; done
4. annocheck --ignore-unknown --verbose --debug-dir=debug_files *.rpm | grep FAIL


Actual results:

Hardened: ./usr/lib64/clang/plugins/annobin-for-clang.so: FAIL: dynamic-tags test because the BTI_PLT flag is missing from the dynamic tags 
Hardened: ./usr/lib64/clang/plugins/annobin-for-clang.so: FAIL: property-note test because properly formatted .note.gnu.property not found (it is needed for branch protection support) 
Hardened: ./usr/lib64/clang/plugins/annobin-for-clang.so: Overall: FAIL.
Hardened: ./usr/lib64/llvm/plugins/annobin-for-llvm.so: FAIL: dynamic-tags test because the BTI_PLT flag is missing from the dynamic tags 
Hardened: ./usr/lib64/llvm/plugins/annobin-for-llvm.so: FAIL: property-note test because properly formatted .note.gnu.property not found (it is needed for branch protection support) 
Hardened: ./usr/lib64/llvm/plugins/annobin-for-llvm.so: Overall: FAIL.


Expected results:

No FAIL

Comment 1 Nick Clifton 2023-01-25 12:46:34 UTC
*sigh*  Hoist by my own petard!  

OK, I have added the missing security option when building the LLVM and Clang plugins.

Fixed in annobin-11.07-2.fc38

Comment 2 Ben Cotton 2023-02-07 15:13:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.


Note You need to log in before you can comment on or make changes to this bug.