Spec URL: https://raw.githubusercontent.com/Vascom/fancontrol-gui/main/fancontrol-gui.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7208/96767208/fancontrol-gui-0.8-1.20220606git5bfa8fa.fc38.src.rpm Description: GUI for fancontrol which is part of lm_sensors. It uses the KAuth module of the KDE Frameworks 5 to write the generated config file. Furthermore it communicates with systemd via dbus to control the fancontrol service.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5325143 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2165030-fancontrol-gui/fedora-rawhide-x86_64/05325143-fancontrol-gui/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU Library General Public License v2 or later". 26 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/fancontrol-gui/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: fancontrol-gui-0.8-1.20220606git5bfa8fa.fc38.x86_64.rpm fancontrol-gui-kcm-0.8-1.20220606git5bfa8fa.fc38.x86_64.rpm fancontrol-gui-plasmoid-0.8-1.20220606git5bfa8fa.fc38.noarch.rpm fancontrol-gui-debuginfo-0.8-1.20220606git5bfa8fa.fc38.x86_64.rpm fancontrol-gui-debugsource-0.8-1.20220606git5bfa8fa.fc38.x86_64.rpm fancontrol-gui-0.8-1.20220606git5bfa8fa.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpk604kp13')] checks: 31, packages: 6 fancontrol-gui.x86_64: W: no-manual-page-for-binary fancontrol_gui fancontrol-gui-kcm.x86_64: W: no-documentation fancontrol-gui-plasmoid.noarch: W: no-documentation fancontrol-gui-plasmoid.noarch: W: files-duplicate /usr/share/plasma/plasmoids/org.kde.fancontrol.plasmoid/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.fancontrol.plasmoid.desktop fancontrol-gui.x86_64: E: communication not allowed /usr/share/dbus-1/system.d/org.kde.fancontrol.gui.helper.conf 6 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: fancontrol-gui-kcm-debuginfo-0.8-1.20220606git5bfa8fa.fc38.x86_64.rpm fancontrol-gui-debuginfo-0.8-1.20220606git5bfa8fa.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7ji2e2u5')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 fancontrol-gui.x86_64: W: no-manual-page-for-binary fancontrol_gui fancontrol-gui-plasmoid.noarch: W: no-documentation fancontrol-gui-kcm.x86_64: W: no-documentation fancontrol-gui-plasmoid.noarch: W: files-duplicate /usr/share/plasma/plasmoids/org.kde.fancontrol.plasmoid/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.fancontrol.plasmoid.desktop fancontrol-gui.x86_64: E: communication not allowed /usr/share/dbus-1/system.d/org.kde.fancontrol.gui.helper.conf 6 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 1.0 s Unversioned so-files -------------------- fancontrol-gui: /usr/lib64/qt5/qml/Fancontrol/Qml/libfancontrol_qml_plugin.so fancontrol-gui-kcm: /usr/lib64/qt5/plugins/kcms/kcm_fancontrol.so Source checksums ---------------- https://github.com/Maldela/fancontrol-gui/tarball/5bfa8fa9c880db2374c75d2d25107da3926b8f29 : CHECKSUM(SHA256) this package : ccd4677ca5ee509de3dc4cf2e4c4c192ccc6ed33f614f89ba24fea0d883e8917 CHECKSUM(SHA256) upstream package : ccd4677ca5ee509de3dc4cf2e4c4c192ccc6ed33f614f89ba24fea0d883e8917 Requires -------- fancontrol-gui (rpmlib, GLIBC filtered): dbus-common hicolor-icon-theme libKF5AuthCore.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5DBusAddons.so.5()(64bit) libKF5Declarative.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5Notifications.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) polkit rtld(GNU_HASH) fancontrol-gui-kcm (rpmlib, GLIBC filtered): fancontrol-gui(x86-64) kf5-filesystem kf5-kcmutils libKF5CoreAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5QuickAddons.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) plasma-settings rtld(GNU_HASH) fancontrol-gui-plasmoid (rpmlib, GLIBC filtered): fancontrol-gui kf5-filesystem plasma-workspace fancontrol-gui-debuginfo (rpmlib, GLIBC filtered): fancontrol-gui-debugsource (rpmlib, GLIBC filtered): Provides -------- fancontrol-gui: application() application(org.kde.fancontrol.gui.desktop) fancontrol-gui fancontrol-gui(x86-64) libfancontrol_qml_plugin.so()(64bit) metainfo() metainfo(org.kde.fancontrol.gui.appdata.xml) fancontrol-gui-kcm: fancontrol-gui-kcm fancontrol-gui-kcm(x86-64) metainfo() metainfo(org.kde.fancontrol.kcm.appdata.xml) fancontrol-gui-plasmoid: fancontrol-gui-plasmoid metainfo() metainfo(org.kde.fancontrol.plasmoid.appdata.xml) fancontrol-gui-debuginfo: debuginfo(build-id) fancontrol-gui-debuginfo fancontrol-gui-debuginfo(x86-64) libfancontrol_qml_plugin.so-0.8-1.20220606git5bfa8fa.fc38.x86_64.debug()(64bit) fancontrol-gui-debugsource: fancontrol-gui-debugsource fancontrol-gui-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name fancontrol-gui --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: PHP, Java, Python, Haskell, fonts, R, SugarActivity, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/fancontrol-gui