Spec URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts.spec SRPM URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts-20220320-1.fc37.src.rpm Description: Google Noto Sans CJK Fonts Fedora Account System Username:pwu
Copr build: https://copr.fedorainfracloud.org/coprs/build/5359122 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2165448-google-noto-sans-cjk-fonts/fedora-rawhide-x86_64/05359122-google-noto-sans-cjk-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
You can drop below lines which are not needed in this SPEC file as there is no doc files to install. %global fontdocs *.txt %global fontdocsex %{fontlicenses} Use %autosetup instead of just %setup in SPEC file What is the source URL to download the Source0 archive? if possible can it be added there?
Why do you not follow the upstream versioning to package it? that would cause a confusion.
Found it https://github.com/googlefonts/noto-cjk/releases/download/Sans2.004/03_NotoSansCJK-OTC.zip Please use this URL. Also as upstream has started using version numbers, good to use that, so Version: 2.004 With this change, you need to add obsoletes and provides to SPEC file and drop conflicts: I think this package should provide 2 subpackages per family google-noto-sans-cjk-fonts google-noto-sans-mono-cjk-fonts
I just realized upstream archive provides ttc files which can contain multiple families. So in this case no need to have subpackages. You can continue using current spec. Also, Conflicts is needed so add a comment why it needs to be there in SPEC file.
Okay, I just updated the package to follow the upstream versioning, and added one comment in the spec file. Spec URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts.spec SRPM URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts-2.004-1.fc37.src.rpm
Created attachment 1941709 [details] The .spec file difference from Copr build 5359122 to 5402185
Copr build: https://copr.fedorainfracloud.org/coprs/build/5402185 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2165448-google-noto-sans-cjk-fonts/fedora-rawhide-x86_64/05402185-google-noto-sans-cjk-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
This package looks good now. Will approve along with review bug 2165453
APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/google-noto-sans-cjk-fonts
Thanks for the review!