spec: https://download.copr.fedorainfracloud.org/results/fed500/libbee2/fedora-rawhide-x86_64/05361898-libbee2/libbee2.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/libbee2/fedora-rawhide-x86_64/05361898-libbee2/libbee2-2.1.0-1.fc38.src.rpm Description: Bee2 is a cryptographic library which implements cryptographic algorithms and protocols standardized in Belarus. Additionally, Bee2 implements digital signature algorithms standardized in Russia and Ukraine. Fedora Account System Username: fed500 Previous review: https://bugzilla.redhat.com/show_bug.cgi?id=1851405
Copr build: https://copr.fedorainfracloud.org/coprs/build/5361930 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2165536-libbee2/fedora-rawhide-x86_64/05361930-libbee2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
URL and Source0 addresses are Ok. Source0 archive (SHA-512: 7b245d490281467bd78ce0f3ae21c168a737c3ca36310cff67677aeb4a715759efdb26ca71bdfef9e6b8e10ba3dc80e407afa60c1632093dd5269805ba2cc172) is original. Ok. TODO: I think this package should be called "bee2". It's the name used on the home page, on github and also the archive is called like that. TODO: The libbee2 summary is very general. I see that the algorithm names are quite terrible, but couldn't the summary be made more specific? E.g. "STB cryptography"? The same applies to bsum summary. Description texts are Ok. GPL-3.0-only license verified in win/bee2.rc, win/bee2.c, test/test.c, README.md, LICENSE and other files. include/bee2/info.h* are files are "GPL-3.0-only AND GPL-3.0-or-later". include/bee2/info.h is included into src/core/util.c which is linked into bee2 dynamic and static libraries. bsum tool links to a dynamic library, hence it does not contain the header file. FIX: Please correct the license tag for libbee2 and libbee2-devel packages to "GPL-3.0-only AND GPL-3.0-or-later". bsum should use "GPL-3.0-only". TODO: It's possible the GPL-3.0-or-later license is an upstream's mistake. Please report it. FIX: Build-require 'sed' (libbee2.spec:45). TODO: You don't have to add -fPIE and -pie to build flags. Fedora default build flags linked from CFLAGS and LDFLAGS environment variables already do that. FIX: Build-require "coreutils" (libbee2.spec:67). The assembler code with SMD instructions is not built. Thus the resulting code is compatible with a minimal Fedora-supported CPU instruction set. FIX: A soname of the library is "libbee2.so.2.0". The %files section must name it explicitly <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files>, hence "%{_libdir}/libbee2.so.2.*" glob is not specific enough. Use "%{_libdir}/libbee2.so.2.0" and "%{_libdir}/libbee2.so.%{version}" to capture both files. All tests pass. Ok. $ rpmlint libbee2.spec ../SRPMS/libbee2-2.1.0-1.fc38.src.rpm ../RPMS/x86_64/libbee2-* ../RPMS/x86_64/bsum-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 8 bsum.x86_64: W: no-manual-page-for-binary bsum bsum.x86_64: W: no-documentation ========= 7 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/libbee2-2.1.0-1.fc38.x86_64.rpm drwxr-xr-x 2 root root 0 Jan 30 01:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jan 30 01:00 /usr/lib/.build-id/78 lrwxrwxrwx 1 root root 38 Jan 30 01:00 /usr/lib/.build-id/78/bd508922a537e5e8af20c139756d4c1cac60e7 -> ../../../../usr/lib64/libbee2.so.2.1.0 lrwxrwxrwx 1 root root 16 Jan 30 01:00 /usr/lib64/libbee2.so.2.0 -> libbee2.so.2.1.0 -rwxr-xr-x 1 root root 765744 Jan 30 01:00 /usr/lib64/libbee2.so.2.1.0 drwxr-xr-x 2 root root 0 Jan 30 01:00 /usr/share/doc/libbee2 -rw-r--r-- 1 root root 905 Jun 30 2021 /usr/share/doc/libbee2/AUTHORS.md -rw-r--r-- 1 root root 3242 Jun 30 2021 /usr/share/doc/libbee2/README.md drwxr-xr-x 2 root root 0 Jan 30 01:00 /usr/share/licenses/libbee2 -rw-r--r-- 1 root root 35142 Jun 30 2021 /usr/share/licenses/libbee2/LICENSE -rw-r--r-- 1 root root 1888 Jan 30 01:00 /usr/share/man/man3/b64.h.3.gz -rw-r--r-- 1 root root 5689 Jan 30 01:00 /usr/share/man/man3/bake.h.3.gz -rw-r--r-- 1 root root 452 Jan 30 01:00 /usr/share/man/man3/bake_cert.3.gz -rw-r--r-- 1 root root 611 Jan 30 01:00 /usr/share/man/man3/bake_settings.3.gz -rw-r--r-- 1 root root 4443 Jan 30 01:00 /usr/share/man/man3/bash.h.3.gz -rw-r--r-- 1 root root 3741 Jan 30 01:00 /usr/share/man/man3/bels.h.3.gz -rw-r--r-- 1 root root 10828 Jan 30 01:00 /usr/share/man/man3/belt.h.3.gz -rw-r--r-- 1 root root 4462 Jan 30 01:00 /usr/share/man/man3/bign.h.3.gz -rw-r--r-- 1 root root 560 Jan 30 01:00 /usr/share/man/man3/bign_params.3.gz -rw-r--r-- 1 root root 2019 Jan 30 01:00 /usr/share/man/man3/blob.h.3.gz -rw-r--r-- 1 root root 5356 Jan 30 01:00 /usr/share/man/man3/botp.h.3.gz -rw-r--r-- 1 root root 3497 Jan 30 01:00 /usr/share/man/man3/brng.h.3.gz -rw-r--r-- 1 root root 4651 Jan 30 01:00 /usr/share/man/man3/defs.h.3.gz -rw-r--r-- 1 root root 5099 Jan 30 01:00 /usr/share/man/man3/der.h.3.gz -rw-r--r-- 1 root root 439 Jan 30 01:00 /usr/share/man/man3/der_anchor.3.gz -rw-r--r-- 1 root root 3554 Jan 30 01:00 /usr/share/man/man3/dstu.h.3.gz -rw-r--r-- 1 root root 559 Jan 30 01:00 /usr/share/man/man3/dstu_params.3.gz -rw-r--r-- 1 root root 5683 Jan 30 01:00 /usr/share/man/man3/ec.h.3.gz -rw-r--r-- 1 root root 2350 Jan 30 01:00 /usr/share/man/man3/ec2.h.3.gz -rw-r--r-- 1 root root 1194 Jan 30 01:00 /usr/share/man/man3/ec_o.3.gz -rw-r--r-- 1 root root 2673 Jan 30 01:00 /usr/share/man/man3/ecp.h.3.gz -rw-r--r-- 1 root root 999 Jan 30 01:00 /usr/share/man/man3/err.h.3.gz -rw-r--r-- 1 root root 3039 Jan 30 01:00 /usr/share/man/man3/g12s.h.3.gz -rw-r--r-- 1 root root 599 Jan 30 01:00 /usr/share/man/man3/g12s_params.3.gz -rw-r--r-- 1 root root 2827 Jan 30 01:00 /usr/share/man/man3/gf2.h.3.gz -rw-r--r-- 1 root root 1306 Jan 30 01:00 /usr/share/man/man3/gfp.h.3.gz -rw-r--r-- 1 root root 1870 Jan 30 01:00 /usr/share/man/man3/hex.h.3.gz -rw-r--r-- 1 root root 273 Jan 30 01:00 /usr/share/man/man3/info.h.3.gz -rw-r--r-- 1 root root 3869 Jan 30 01:00 /usr/share/man/man3/mem.h.3.gz -rw-r--r-- 1 root root 2751 Jan 30 01:00 /usr/share/man/man3/mt.h.3.gz -rw-r--r-- 1 root root 1813 Jan 30 01:00 /usr/share/man/man3/obj.h.3.gz -rw-r--r-- 1 root root 439 Jan 30 01:00 /usr/share/man/man3/obj_hdr_t.3.gz -rw-r--r-- 1 root root 1553 Jan 30 01:00 /usr/share/man/man3/oid.h.3.gz -rw-r--r-- 1 root root 3145 Jan 30 01:00 /usr/share/man/man3/pfok.h.3.gz -rw-r--r-- 1 root root 491 Jan 30 01:00 /usr/share/man/man3/pfok_params.3.gz -rw-r--r-- 1 root root 413 Jan 30 01:00 /usr/share/man/man3/pfok_seed.3.gz -rw-r--r-- 1 root root 4966 Jan 30 01:00 /usr/share/man/man3/pp.h.3.gz -rw-r--r-- 1 root root 452 Jan 30 01:00 /usr/share/man/man3/pp_pentanom_st.3.gz -rw-r--r-- 1 root root 411 Jan 30 01:00 /usr/share/man/man3/pp_trinom_st.3.gz -rw-r--r-- 1 root root 3076 Jan 30 01:00 /usr/share/man/man3/pri.h.3.gz -rw-r--r-- 1 root root 1983 Jan 30 01:00 /usr/share/man/man3/prng.h.3.gz -rw-r--r-- 1 root root 4538 Jan 30 01:00 /usr/share/man/man3/qr.h.3.gz -rw-r--r-- 1 root root 1072 Jan 30 01:00 /usr/share/man/man3/qr_o.3.gz -rw-r--r-- 1 root root 4041 Jan 30 01:00 /usr/share/man/man3/rng.h.3.gz -rw-r--r-- 1 root root 1563 Jan 30 01:00 /usr/share/man/man3/safe.h.3.gz -rw-r--r-- 1 root root 1884 Jan 30 01:00 /usr/share/man/man3/stack.h.3.gz -rw-r--r-- 1 root root 1642 Jan 30 01:00 /usr/share/man/man3/str.h.3.gz -rw-r--r-- 1 root root 1960 Jan 30 01:00 /usr/share/man/man3/tm.h.3.gz -rw-r--r-- 1 root root 1764 Jan 30 01:00 /usr/share/man/man3/u16.h.3.gz -rw-r--r-- 1 root root 1761 Jan 30 01:00 /usr/share/man/man3/u32.h.3.gz -rw-r--r-- 1 root root 1759 Jan 30 01:00 /usr/share/man/man3/u64.h.3.gz -rw-r--r-- 1 root root 3062 Jan 30 01:00 /usr/share/man/man3/util.h.3.gz -rw-r--r-- 1 root root 1443 Jan 30 01:00 /usr/share/man/man3/word.h.3.gz -rw-r--r-- 1 root root 4784 Jan 30 01:00 /usr/share/man/man3/ww.h.3.gz -rw-r--r-- 1 root root 2452 Jan 30 01:00 /usr/share/man/man3/zm.h.3.gz -rw-r--r-- 1 root root 7261 Jan 30 01:00 /usr/share/man/man3/zz.h.3.gz FIX: Section 3 manual pages belong to devel subpackage. They document an API of the library. $ rpm -q -lv -p ../RPMS/x86_64/libbee2-devel-2.1.0-1.fc38.x86_64.rpm -rw-r--r-- 1 root root 5452 Jun 30 2021 /usr/include/bee2/core/b64.h -rw-r--r-- 1 root root 6421 Jun 30 2021 /usr/include/bee2/core/blob.h -rw-r--r-- 1 root root 7277 Jun 30 2021 /usr/include/bee2/core/dec.h -rw-r--r-- 1 root root 23828 Jun 30 2021 /usr/include/bee2/core/der.h -rw-r--r-- 1 root root 8253 Jun 30 2021 /usr/include/bee2/core/err.h -rw-r--r-- 1 root root 7620 Jun 30 2021 /usr/include/bee2/core/hex.h -rw-r--r-- 1 root root 17205 Jun 30 2021 /usr/include/bee2/core/mem.h -rw-r--r-- 1 root root 8929 Jun 30 2021 /usr/include/bee2/core/mt.h -rw-r--r-- 1 root root 6297 Jun 30 2021 /usr/include/bee2/core/obj.h -rw-r--r-- 1 root root 4584 Jun 30 2021 /usr/include/bee2/core/oid.h -rw-r--r-- 1 root root 7453 Jun 30 2021 /usr/include/bee2/core/prng.h -rw-r--r-- 1 root root 15568 Jun 30 2021 /usr/include/bee2/core/rng.h -rw-r--r-- 1 root root 4911 Jun 30 2021 /usr/include/bee2/core/safe.h -rw-r--r-- 1 root root 6143 Jun 30 2021 /usr/include/bee2/core/stack.h -rw-r--r-- 1 root root 4979 Jun 30 2021 /usr/include/bee2/core/str.h -rw-r--r-- 1 root root 5923 Jun 30 2021 /usr/include/bee2/core/tm.h -rw-r--r-- 1 root root 5602 Jun 30 2021 /usr/include/bee2/core/u16.h -rw-r--r-- 1 root root 5610 Jun 30 2021 /usr/include/bee2/core/u32.h -rw-r--r-- 1 root root 5957 Jun 30 2021 /usr/include/bee2/core/u64.h -rw-r--r-- 1 root root 10459 Jun 30 2021 /usr/include/bee2/core/util.h -rw-r--r-- 1 root root 7654 Jun 30 2021 /usr/include/bee2/core/word.h -rw-r--r-- 1 root root 38070 Jun 30 2021 /usr/include/bee2/crypto/bake.h -rw-r--r-- 1 root root 21129 Jun 30 2021 /usr/include/bee2/crypto/bash.h -rw-r--r-- 1 root root 19295 Jun 30 2021 /usr/include/bee2/crypto/bels.h -rw-r--r-- 1 root root 89383 Jun 30 2021 /usr/include/bee2/crypto/belt.h -rw-r--r-- 1 root root 29707 Jun 30 2021 /usr/include/bee2/crypto/bign.h -rw-r--r-- 1 root root 27544 Jun 30 2021 /usr/include/bee2/crypto/botp.h -rw-r--r-- 1 root root 9308 Jun 30 2021 /usr/include/bee2/crypto/bpki.h -rw-r--r-- 1 root root 15510 Jun 30 2021 /usr/include/bee2/crypto/brng.h -rw-r--r-- 1 root root 14895 Jun 30 2021 /usr/include/bee2/crypto/dstu.h -rw-r--r-- 1 root root 12092 Jun 30 2021 /usr/include/bee2/crypto/g12s.h -rw-r--r-- 1 root root 16418 Jun 30 2021 /usr/include/bee2/crypto/pfok.h -rw-r--r-- 1 root root 23223 Jun 30 2021 /usr/include/bee2/defs.h -rw-r--r-- 1 root root 7237 Jun 30 2021 /usr/include/bee2/info.h -rw-r--r-- 1 root root 32259 Jun 30 2021 /usr/include/bee2/math/ec.h -rw-r--r-- 1 root root 9418 Jun 30 2021 /usr/include/bee2/math/ec2.h -rw-r--r-- 1 root root 10605 Jun 30 2021 /usr/include/bee2/math/ecp.h -rw-r--r-- 1 root root 9833 Jun 30 2021 /usr/include/bee2/math/gf2.h -rw-r--r-- 1 root root 3966 Jun 30 2021 /usr/include/bee2/math/gfp.h -rw-r--r-- 1 root root 23799 Jun 30 2021 /usr/include/bee2/math/pp.h -rw-r--r-- 1 root root 13648 Jun 30 2021 /usr/include/bee2/math/pri.h -rw-r--r-- 1 root root 21969 Jun 30 2021 /usr/include/bee2/math/qr.h -rw-r--r-- 1 root root 24548 Jun 30 2021 /usr/include/bee2/math/ww.h -rw-r--r-- 1 root root 11723 Jun 30 2021 /usr/include/bee2/math/zm.h -rw-r--r-- 1 root root 48871 Jun 30 2021 /usr/include/bee2/math/zz.h lrwxrwxrwx 1 root root 14 Jan 30 01:00 /usr/lib64/libbee2.so -> libbee2.so.2.0 FIX: devel subpackage must own %{_includedir}/bee2, %{_includedir}/bee2/core etc. directories. I recommend simply using "%{_includedir}/bee2" in %files section instead of listing files separately. $ rpm -q -lv -p ../RPMS/x86_64/bsum-2.1.0-1.fc38.x86_64.rpm -rwxr-xr-x 1 root root 15592 Jan 30 01:00 /usr/bin/bsum drwxr-xr-x 2 root root 0 Jan 30 01:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jan 30 01:00 /usr/lib/.build-id/fa lrwxrwxrwx 1 root root 24 Jan 30 01:00 /usr/lib/.build-id/fa/11ffb604a21eab277b740f03211e607b09e825 -> ../../../../usr/bin/bsum bsum binary package layou and file permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/libbee2-2.1.0-1.fc38.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) $ rpm -q --requires -p ../RPMS/x86_64/libbee2-devel-2.1.0-1.fc38.x86_64.rpm | sort -f | uniq -c 1 libbee2(x86-64) = 2.1.0-1.fc38 1 libbee2.so.2.0()(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 $ rpm -q --requires -p ../RPMS/x86_64/bsum-2.1.0-1.fc38.x86_64.rpm | sort -f | uniq -c 1 libbee2(x86-64) = 2.1.0-1.fc38 1 libbee2.so.2.0()(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/libbee2-2.1.0-1.fc38.x86_64.rpm | sort -f | uniq -c 1 libbee2 = 2.1.0-1.fc38 1 libbee2(x86-64) = 2.1.0-1.fc38 1 libbee2.so.2.0()(64bit) $ rpm -q --provides -p ../RPMS/x86_64/libbee2-devel-2.1.0-1.fc38.x86_64.rpm | sort -f | uniq -c 1 libbee2-devel = 2.1.0-1.fc38 1 libbee2-devel(x86-64) = 2.1.0-1.fc38 $ rpm -q --provides -p ../RPMS/x86_64/bsum-2.1.0-1.fc38.x86_64.rpm | sort -f | uniq -c 1 bsum = 2.1.0-1.fc38 1 bsum(x86-64) = 2.1.0-1.fc38 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/{libbee2,libbee2-devel,bsum}-2.1.0-1.fc38.x86_64.rpm Binary dependencies are resolvable. Ok. The package fails to build on s390x F38 (https://koji.fedoraproject.org/koji/taskinfo?taskID=97237047) because a beltTest test fails there. s390x is a big-endian, 64-bit, signed char archicterure. Maybe there is a bug in the library which manifests on that architecture. FIX: Either fix the bug, or exclude the package from building on s390x with "ExcludeArch: s390x" <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures>. Otherwise, the package is in line with Fedora packaging guidelines. Please correct the FIX items, consider fixing TODO items, and provide a new spec file.
Thanks for your detailed suggestions. > TODO: I think this package should be called "bee2". It's the name used on the home page, on github and also the archive is called like that. Renamed package. > TODO: The libbee2 summary is very general. I see that the algorithm names are quite terrible, but couldn't the summary be made more specific? E.g. "STB cryptography"? The same applies to bsum summary. Expanded this a little. Much of the documentation is in Belorusian > FIX: Please correct the license tag for libbee2 and libbee2-devel packages to "GPL-3.0-only AND GPL-3.0-or-later". bsum should use "GPL-3.0-only". Done. > TODO: It's possible the GPL-3.0-or-later license is an upstream's mistake. Please report it. Done. https://github.com/agievich/bee2/issues/30 > FIX: Build-require 'sed' (libbee2.spec:45). Done. > TODO: You don't have to add -fPIE and -pie to build flags. Fedora default build flags linked from CFLAGS and LDFLAGS environment variables already do that. From build log, build flags are: + CFLAGS='-O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer' + export CFLAGS + CXXFLAGS='-O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer' + export CXXFLAGS + FFLAGS='-O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/lib64/gfortran/modules' + export FFLAGS + FCFLAGS='-O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/lib64/gfortran/modules' + export FCFLAGS + VALAFLAGS=-g + export VALAFLAGS + LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -flto=thin -fno-openmp-implicit-rpath -Wl,--build-id=sha1 ' Left as is to ensure do not get a warning from fedora-review > FIX: Build-require "coreutils" (libbee2.spec:67). Done. > The assembler code with SMD instructions is not built. Thus the resulting code is compatible with a minimal Fedora-supported CPU instruction set. OpenSSL has more checks in its build allowing for a variety of SIMD instructions, however will start with the base case. > FIX: A soname of the library is "libbee2.so.2.0". The %files section must name it explicitly <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files>, hence "%{_libdir}/libbee2.so.2.*" glob is not specific enough. Use "%{_libdir}/libbee2.so.2.0" and "%{_libdir}/libbee2.so.%{version}" to capture both files. Done. > FIX: Section 3 manual pages belong to devel subpackage. They document an API of the library. Done. > FIX: devel subpackage must own %{_includedir}/bee2, %{_includedir}/bee2/core etc. directories. I recommend simply using "%{_includedir}/bee2" in %files section instead of listing files separately. Added directory listings, find it easier to remember what is included. Hope this is ok. > FIX: Either fix the bug, or exclude the package from building on s390x with "ExcludeArch: s390x" <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures>. Excluded this, and reported upstream. Needs further investigation. Some of the tests also fail with GCC compiler and Fedora build flags. Made the main package a libs package to more correctly indicate the content. Review template: https://download.copr.fedorainfracloud.org/results/fed500/libbee2/fedora-rawhide-x86_64/05521033-bee2/fedora-review/review.txt spec: https://download.copr.fedorainfracloud.org/results/fed500/libbee2/fedora-rawhide-x86_64/05521033-bee2/bee2.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/libbee2/fedora-rawhide-x86_64/05521033-bee2/bee2-2.1.0-3.fc39.src.rpm
TODO: bsum description ends with "see apmi.bsu.by/resources/std.html". Could you spell it as a proper URL and with a full stop at the end of the sentence like "see <https://apmi.bsu.by/resources/std.html>."? TODO: Delete the static library in %install section (rm %{buildroot}%{_libdir}/libbee2_static.a), rather then using %exclude in %files libs. Unpackaged files can trigger side effects like bug #878863. FIX: A license for bsum package should be "GPL-3.0-only". The executable does not contain the GPL-3.0-or-later file. Add an explicit "License: GPL-3.0-only" to bsum package section. > From build log, build flags are: > + CFLAGS='-O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer' > + LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -flto=thin -fno-openmp-implicit-rpath -Wl,--build-id=sha1 ' I think the PIE flags are stored in /usr/lib/rpm/redhat/redhat-hardened-clang.cfg which is passed with a --config option. $ rpmlint bee2.spec ../SRPMS/bee2-2.1.0-3.fc39.src.rpm ../RPMS/x86_64/bee2-libs-* ../RPMS/x86_64/bsum-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 bsum.x86_64: W: no-manual-page-for-binary bsum bsum.x86_64: W: no-documentation ========= 5 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.4 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/bee2-libs-2.1.0-3.fc39.x86_64.rpm drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/lib/.build-id/ff lrwxrwxrwx 1 root root 38 Feb 13 01:00 /usr/lib/.build-id/ff/8a303b1b587ef56e8df35cadd0893f26948f12 -> ../../../../usr/lib64/libbee2.so.2.1.0 lrwxrwxrwx 1 root root 16 Feb 13 01:00 /usr/lib64/libbee2.so.2.0 -> libbee2.so.2.1.0 -rwxr-xr-x 1 root root 765744 Feb 13 01:00 /usr/lib64/libbee2.so.2.1.0 drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/share/doc/bee2-libs -rw-r--r-- 1 root root 905 Jun 30 2021 /usr/share/doc/bee2-libs/AUTHORS.md -rw-r--r-- 1 root root 3242 Jun 30 2021 /usr/share/doc/bee2-libs/README.md drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/share/licenses/bee2-libs -rw-r--r-- 1 root root 35142 Jun 30 2021 /usr/share/licenses/bee2-libs/LICENSE $ rpm -q -lv -p ../RPMS/x86_64/bee2-libs-2.1.0-3.fc39.x86_64.rpm drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/lib/.build-id/ff lrwxrwxrwx 1 root root 38 Feb 13 01:00 /usr/lib/.build-id/ff/8a303b1b587ef56e8df35cadd0893f26948f12 -> ../../../../usr/lib64/libbee2.so.2.1.0 lrwxrwxrwx 1 root root 16 Feb 13 01:00 /usr/lib64/libbee2.so.2.0 -> libbee2.so.2.1.0 -rwxr-xr-x 1 root root 765744 Feb 13 01:00 /usr/lib64/libbee2.so.2.1.0 drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/share/doc/bee2-libs -rw-r--r-- 1 root root 905 Jun 30 2021 /usr/share/doc/bee2-libs/AUTHORS.md -rw-r--r-- 1 root root 3242 Jun 30 2021 /usr/share/doc/bee2-libs/README.md drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/share/licenses/bee2-libs -rw-r--r-- 1 root root 35142 Jun 30 2021 /usr/share/licenses/bee2-libs/LICENSE test@fedora-39:~/rpmbuild/SPECS $ rpm -q -lv -p ../RPMS/x86_64/bee2-devel-2.1.0-3.fc39.x86_64.rpm drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/include/bee2 drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/include/bee2/core -rw-r--r-- 1 root root 5452 Jun 30 2021 /usr/include/bee2/core/b64.h -rw-r--r-- 1 root root 6421 Jun 30 2021 /usr/include/bee2/core/blob.h -rw-r--r-- 1 root root 7277 Jun 30 2021 /usr/include/bee2/core/dec.h -rw-r--r-- 1 root root 23828 Jun 30 2021 /usr/include/bee2/core/der.h -rw-r--r-- 1 root root 8253 Jun 30 2021 /usr/include/bee2/core/err.h -rw-r--r-- 1 root root 7620 Jun 30 2021 /usr/include/bee2/core/hex.h -rw-r--r-- 1 root root 17205 Jun 30 2021 /usr/include/bee2/core/mem.h -rw-r--r-- 1 root root 8929 Jun 30 2021 /usr/include/bee2/core/mt.h -rw-r--r-- 1 root root 6297 Jun 30 2021 /usr/include/bee2/core/obj.h -rw-r--r-- 1 root root 4584 Jun 30 2021 /usr/include/bee2/core/oid.h -rw-r--r-- 1 root root 7453 Jun 30 2021 /usr/include/bee2/core/prng.h -rw-r--r-- 1 root root 15568 Jun 30 2021 /usr/include/bee2/core/rng.h -rw-r--r-- 1 root root 4911 Jun 30 2021 /usr/include/bee2/core/safe.h -rw-r--r-- 1 root root 6143 Jun 30 2021 /usr/include/bee2/core/stack.h -rw-r--r-- 1 root root 4979 Jun 30 2021 /usr/include/bee2/core/str.h -rw-r--r-- 1 root root 5923 Jun 30 2021 /usr/include/bee2/core/tm.h -rw-r--r-- 1 root root 5602 Jun 30 2021 /usr/include/bee2/core/u16.h -rw-r--r-- 1 root root 5610 Jun 30 2021 /usr/include/bee2/core/u32.h -rw-r--r-- 1 root root 5957 Jun 30 2021 /usr/include/bee2/core/u64.h -rw-r--r-- 1 root root 10459 Jun 30 2021 /usr/include/bee2/core/util.h -rw-r--r-- 1 root root 7654 Jun 30 2021 /usr/include/bee2/core/word.h drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/include/bee2/crypto -rw-r--r-- 1 root root 38070 Jun 30 2021 /usr/include/bee2/crypto/bake.h -rw-r--r-- 1 root root 21129 Jun 30 2021 /usr/include/bee2/crypto/bash.h -rw-r--r-- 1 root root 19295 Jun 30 2021 /usr/include/bee2/crypto/bels.h -rw-r--r-- 1 root root 89383 Jun 30 2021 /usr/include/bee2/crypto/belt.h -rw-r--r-- 1 root root 29707 Jun 30 2021 /usr/include/bee2/crypto/bign.h -rw-r--r-- 1 root root 27544 Jun 30 2021 /usr/include/bee2/crypto/botp.h -rw-r--r-- 1 root root 9308 Jun 30 2021 /usr/include/bee2/crypto/bpki.h -rw-r--r-- 1 root root 15510 Jun 30 2021 /usr/include/bee2/crypto/brng.h -rw-r--r-- 1 root root 14895 Jun 30 2021 /usr/include/bee2/crypto/dstu.h -rw-r--r-- 1 root root 12092 Jun 30 2021 /usr/include/bee2/crypto/g12s.h -rw-r--r-- 1 root root 16418 Jun 30 2021 /usr/include/bee2/crypto/pfok.h -rw-r--r-- 1 root root 23223 Jun 30 2021 /usr/include/bee2/defs.h -rw-r--r-- 1 root root 7237 Jun 30 2021 /usr/include/bee2/info.h drwxr-xr-x 2 root root 0 Feb 13 01:00 /usr/include/bee2/math -rw-r--r-- 1 root root 32259 Jun 30 2021 /usr/include/bee2/math/ec.h -rw-r--r-- 1 root root 9418 Jun 30 2021 /usr/include/bee2/math/ec2.h -rw-r--r-- 1 root root 10605 Jun 30 2021 /usr/include/bee2/math/ecp.h -rw-r--r-- 1 root root 9833 Jun 30 2021 /usr/include/bee2/math/gf2.h -rw-r--r-- 1 root root 3966 Jun 30 2021 /usr/include/bee2/math/gfp.h -rw-r--r-- 1 root root 23799 Jun 30 2021 /usr/include/bee2/math/pp.h -rw-r--r-- 1 root root 13648 Jun 30 2021 /usr/include/bee2/math/pri.h -rw-r--r-- 1 root root 21969 Jun 30 2021 /usr/include/bee2/math/qr.h -rw-r--r-- 1 root root 24548 Jun 30 2021 /usr/include/bee2/math/ww.h -rw-r--r-- 1 root root 11723 Jun 30 2021 /usr/include/bee2/math/zm.h -rw-r--r-- 1 root root 48871 Jun 30 2021 /usr/include/bee2/math/zz.h lrwxrwxrwx 1 root root 14 Feb 13 01:00 /usr/lib64/libbee2.so -> libbee2.so.2.0 -rw-r--r-- 1 root root 1889 Feb 13 01:00 /usr/share/man/man3/b64.h.3.gz -rw-r--r-- 1 root root 5688 Feb 13 01:00 /usr/share/man/man3/bake.h.3.gz -rw-r--r-- 1 root root 452 Feb 13 01:00 /usr/share/man/man3/bake_cert.3.gz -rw-r--r-- 1 root root 612 Feb 13 01:00 /usr/share/man/man3/bake_settings.3.gz -rw-r--r-- 1 root root 4442 Feb 13 01:00 /usr/share/man/man3/bash.h.3.gz -rw-r--r-- 1 root root 3741 Feb 13 01:00 /usr/share/man/man3/bels.h.3.gz -rw-r--r-- 1 root root 10826 Feb 13 01:00 /usr/share/man/man3/belt.h.3.gz -rw-r--r-- 1 root root 4461 Feb 13 01:00 /usr/share/man/man3/bign.h.3.gz -rw-r--r-- 1 root root 560 Feb 13 01:00 /usr/share/man/man3/bign_params.3.gz -rw-r--r-- 1 root root 2018 Feb 13 01:00 /usr/share/man/man3/blob.h.3.gz -rw-r--r-- 1 root root 5354 Feb 13 01:00 /usr/share/man/man3/botp.h.3.gz -rw-r--r-- 1 root root 3496 Feb 13 01:00 /usr/share/man/man3/brng.h.3.gz -rw-r--r-- 1 root root 4649 Feb 13 01:00 /usr/share/man/man3/defs.h.3.gz -rw-r--r-- 1 root root 5099 Feb 13 01:00 /usr/share/man/man3/der.h.3.gz -rw-r--r-- 1 root root 440 Feb 13 01:00 /usr/share/man/man3/der_anchor.3.gz -rw-r--r-- 1 root root 3552 Feb 13 01:00 /usr/share/man/man3/dstu.h.3.gz -rw-r--r-- 1 root root 560 Feb 13 01:00 /usr/share/man/man3/dstu_params.3.gz -rw-r--r-- 1 root root 5680 Feb 13 01:00 /usr/share/man/man3/ec.h.3.gz -rw-r--r-- 1 root root 2349 Feb 13 01:00 /usr/share/man/man3/ec2.h.3.gz -rw-r--r-- 1 root root 1194 Feb 13 01:00 /usr/share/man/man3/ec_o.3.gz -rw-r--r-- 1 root root 2674 Feb 13 01:00 /usr/share/man/man3/ecp.h.3.gz -rw-r--r-- 1 root root 997 Feb 13 01:00 /usr/share/man/man3/err.h.3.gz -rw-r--r-- 1 root root 3039 Feb 13 01:00 /usr/share/man/man3/g12s.h.3.gz -rw-r--r-- 1 root root 599 Feb 13 01:00 /usr/share/man/man3/g12s_params.3.gz -rw-r--r-- 1 root root 2826 Feb 13 01:00 /usr/share/man/man3/gf2.h.3.gz -rw-r--r-- 1 root root 1306 Feb 13 01:00 /usr/share/man/man3/gfp.h.3.gz -rw-r--r-- 1 root root 1869 Feb 13 01:00 /usr/share/man/man3/hex.h.3.gz -rw-r--r-- 1 root root 274 Feb 13 01:00 /usr/share/man/man3/info.h.3.gz -rw-r--r-- 1 root root 3868 Feb 13 01:00 /usr/share/man/man3/mem.h.3.gz -rw-r--r-- 1 root root 2750 Feb 13 01:00 /usr/share/man/man3/mt.h.3.gz -rw-r--r-- 1 root root 1813 Feb 13 01:00 /usr/share/man/man3/obj.h.3.gz -rw-r--r-- 1 root root 440 Feb 13 01:00 /usr/share/man/man3/obj_hdr_t.3.gz -rw-r--r-- 1 root root 1551 Feb 13 01:00 /usr/share/man/man3/oid.h.3.gz -rw-r--r-- 1 root root 3144 Feb 13 01:00 /usr/share/man/man3/pfok.h.3.gz -rw-r--r-- 1 root root 493 Feb 13 01:00 /usr/share/man/man3/pfok_params.3.gz -rw-r--r-- 1 root root 415 Feb 13 01:00 /usr/share/man/man3/pfok_seed.3.gz -rw-r--r-- 1 root root 4965 Feb 13 01:00 /usr/share/man/man3/pp.h.3.gz -rw-r--r-- 1 root root 452 Feb 13 01:00 /usr/share/man/man3/pp_pentanom_st.3.gz -rw-r--r-- 1 root root 411 Feb 13 01:00 /usr/share/man/man3/pp_trinom_st.3.gz -rw-r--r-- 1 root root 3076 Feb 13 01:00 /usr/share/man/man3/pri.h.3.gz -rw-r--r-- 1 root root 1981 Feb 13 01:00 /usr/share/man/man3/prng.h.3.gz -rw-r--r-- 1 root root 4537 Feb 13 01:00 /usr/share/man/man3/qr.h.3.gz -rw-r--r-- 1 root root 1072 Feb 13 01:00 /usr/share/man/man3/qr_o.3.gz -rw-r--r-- 1 root root 4041 Feb 13 01:00 /usr/share/man/man3/rng.h.3.gz -rw-r--r-- 1 root root 1562 Feb 13 01:00 /usr/share/man/man3/safe.h.3.gz -rw-r--r-- 1 root root 1882 Feb 13 01:00 /usr/share/man/man3/stack.h.3.gz -rw-r--r-- 1 root root 1641 Feb 13 01:00 /usr/share/man/man3/str.h.3.gz -rw-r--r-- 1 root root 1956 Feb 13 01:00 /usr/share/man/man3/tm.h.3.gz -rw-r--r-- 1 root root 1761 Feb 13 01:00 /usr/share/man/man3/u16.h.3.gz -rw-r--r-- 1 root root 1758 Feb 13 01:00 /usr/share/man/man3/u32.h.3.gz -rw-r--r-- 1 root root 1756 Feb 13 01:00 /usr/share/man/man3/u64.h.3.gz -rw-r--r-- 1 root root 3062 Feb 13 01:00 /usr/share/man/man3/util.h.3.gz -rw-r--r-- 1 root root 1443 Feb 13 01:00 /usr/share/man/man3/word.h.3.gz -rw-r--r-- 1 root root 4783 Feb 13 01:00 /usr/share/man/man3/ww.h.3.gz -rw-r--r-- 1 root root 2452 Feb 13 01:00 /usr/share/man/man3/zm.h.3.gz -rw-r--r-- 1 root root 7262 Feb 13 01:00 /usr/share/man/man3/zz.h.3.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/bee2-devel-2.1.0-3.fc39.x86_64.rpm | sort -f | uniq -c 1 bee2-libs(x86-64) = 2.1.0-3.fc39 1 libbee2.so.2.0()(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 $ rpm -q --requires -p ../RPMS/x86_64/bsum-2.1.0-3.fc39.x86_64.rpm | sort -f | uniq -c 1 bee2-libs(x86-64) = 2.1.0-3.fc39 1 libbee2.so.2.0()(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary require are Ok. $ resolvedeps rawhide ../RPMS/x86_64/bsum-2.1.0-3.fc39.x86_64.rpm ../RPMS/x86_64/bee2-{devel,libs}-2.1.0-3.fc39.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in F39 (https://koji.fedoraproject.org/koji/taskinfo?taskID=97482670). Ok. The package is almos perfect. Please correct the FIX item, consider fixing the TODO items and provide a new spec file.
Thanks. -FPIE is provided but -pie is not in the linker flags and needs to be added. Updated. spec: https://download.copr.fedorainfracloud.org/results/fed500/libbee2/fedora-rawhide-x86_64/05528308-bee2/bee2.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/libbee2/fedora-rawhide-x86_64/05528308-bee2/bee2-2.1.0-3.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/5528474 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2165536-bee2/fedora-rawhide-x86_64/05528474-bee2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
$ rpmlint bee2.spec ../SRPMS/bee2-2.1.0-3.fc39.src.rpm ../RPMS/x86_64/bee2-* ../RPMS/x86_64/bsum-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 9 bsum.x86_64: W: no-manual-page-for-binary bsum bsum.x86_64: W: no-documentation ========= 8 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.7 s ======== rpmlint is Ok. $ rpm -q --qf '%{license}\n' -p ../RPMS/x86_64/bsum-2.1.0-3.fc39.x86_64.rpm GPL-3.0-only License is Ok. The package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/bee2
Thanks for the review.