Bug 2165762 - Anaconda Rawhide warning does not switch to selected language
Summary: Anaconda Rawhide warning does not switch to selected language
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 38
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Vendula Poncova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: RejectedBlocker AcceptedFreezeException
Depends On:
Blocks: F38FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2023-01-30 23:18 UTC by Lukas Ruzicka
Modified: 2023-03-15 00:16 UTC (History)
8 users (show)

Fixed In Version: anaconda-38.23.2-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-15 00:16:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot showing the discrepancy. (134.09 KB, image/png)
2023-02-13 10:40 UTC, Lukas Ruzicka
no flags Details
wrongly translated elements (164.33 KB, image/png)
2023-03-03 19:41 UTC, Kamil Páral
no flags Details

Description Lukas Ruzicka 2023-01-30 23:18:55 UTC
Description of problem:

When trying to install the 20230130 compose, I realized that the Rawhide warning stays in the pre-selected language. 
Anaconda pre-selects the language based on some geo-location information it gets from the network, but when the languge preference is changed and confirmed, the new language is effective immediately. However, the pre-selected Czech was replaced by US English and confirmed, yet the warning is still written in Czech, just the buttons have switched languages.


Version-Release number of selected component (if applicable):

How reproducible:
Always

Steps to Reproduce:
1. When Anaconda offers the language during installation, select another one.
2. Confirm the selection.
3. Check the Warning language.

Actual results:
as described

Expected results:
the warning language should be changed to the selected language

Comment 1 Ben Cotton 2023-02-07 15:07:34 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Lukas Ruzicka 2023-02-13 10:39:32 UTC
This is still happening on Fedora 38, see Screenshot.

Comment 3 Lukas Ruzicka 2023-02-13 10:40:04 UTC
Created attachment 1943815 [details]
Screenshot showing the discrepancy.

Comment 4 Fedora Blocker Bugs Application 2023-02-13 10:43:13 UTC
Proposed as a Blocker for 38-final by Fedora user lruzicka using the blocker tracking app because:

 This might violate the Installer translations release criterion

https://fedoraproject.org/wiki/Fedora_38_Final_Release_Criteria#Installer_translations

Comment 5 Adam Williamson 2023-02-24 19:38:43 UTC
-4 in https://pagure.io/fedora-qa/blocker-review/issue/1034 , marking rejected Final blocker. However, proposing as a Beta FE as Beta would be the place it makes sense to fix this, and it does seem worth an FE if we can get a fix.

Comment 6 Adam Williamson 2023-03-01 17:35:28 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1034 , marking accepted Beta FE. We'll only take a clearly safe and targeted fix for this though, given the issue is relatively minor and anaconda is a high-risk component.

Comment 7 Vendula Poncova 2023-03-03 12:22:38 UTC
There are two issues:

1. All elements of the warning should be translated to the selected language. This will be fixed with https://github.com/rhinstaller/anaconda/pull/4590.
2. The Czech translation of the buttons doesn't work. This is caused by https://github.com/rhinstaller/anaconda/commit/64641d61 and it needs to be fixed in Weblate.

Comment 8 Jiri Konecny 2023-03-03 13:03:17 UTC
I have fixed the period in the languages where I'm able to do that.

Comment 9 Kamil Páral 2023-03-03 19:41:29 UTC
Created attachment 1947765 [details]
wrongly translated elements

Actually, this is not just about the pre-release warning. See the screenshot regarding other wrongly translated texts. Because this is no longer about just pre-release, reproposing as a blocker.

Also, Help seems to be always in English, regardless of picked language. But that might be a separate problem.

Comment 10 Lukas Ruzicka 2023-03-06 12:04:46 UTC
(In reply to Kamil Páral from comment #9)
> Created attachment 1947765 [details]
> wrongly translated elements
> 
> Actually, this is not just about the pre-release warning. See the screenshot
> regarding other wrongly translated texts. Because this is no longer about
> just pre-release, reproposing as a blocker.
> 
> Also, Help seems to be always in English, regardless of picked language. But
> that might be a separate problem.

One could argue here, that the translation could happen AFTER you have clicked
**Continue**, so I am not sure what the correct behavior should be. 
Maybe @vponcova or @jkonecny do?

Comment 11 Vendula Poncova 2023-03-06 13:09:44 UTC
I don't know how I could have missed that, but it makes more sense now. We will look at it, the texts should be translated and my fix handles only the pre-release warning.

Comment 12 Vladimír Slávik 2023-03-08 15:40:34 UTC
Fixes for the rest of the screen: https://github.com/rhinstaller/anaconda/pull/4601 and https://github.com/rhinstaller/anaconda/pull/4602 (f39 and f38, respectively).

Help is English-only, so that's not applicable here.

Comment 13 Fedora Update System 2023-03-09 15:13:03 UTC
FEDORA-2023-6cfa0fe11e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6cfa0fe11e

Comment 14 Fedora Update System 2023-03-10 01:48:32 UTC
FEDORA-2023-6cfa0fe11e has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6cfa0fe11e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Adam Williamson 2023-03-13 14:37:24 UTC
-5 blocker / +5 FE in https://pagure.io/fedora-qa/blocker-review/issue/1034 , marking rejected/accepted.

Comment 16 Lukas Ruzicka 2023-03-14 09:05:20 UTC
I can confirm that his has been fixed in the above mentioned build.

Comment 17 Fedora Update System 2023-03-15 00:16:52 UTC
FEDORA-2023-6cfa0fe11e has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.