Spec URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview-6.4.2-1.fc38.src.rpm Description: Qt WebView provides a way to display web content in a QML application without necessarily including a full web browser stack by using native APIs where it makes sense. Fedora Account System Username: jgrulich
Taking this review.
This package doesn't build. The build log indicates there is a missing dependency: -- Could NOT find XKB (missing: XKB_LIBRARY XKB_INCLUDE_DIR) (Required is at least version "0.5.0") -- Found WrapVulkanHeaders: /usr/include -- Configuring done CMake Error at /usr/lib64/cmake/Qt6Gui/Qt6GuiTargets.cmake:98 (set_target_properties): The link interface of target "Qt6::GuiPrivate" contains: XKB::XKB but the target was not found. Possible reasons include: * There is a typo in the target name. * A find_package call is missing for an IMPORTED target. * An ALIAS target is missing. Call Stack (most recent call first): /usr/lib64/cmake/Qt6Gui/Qt6GuiConfig.cmake:62 (include) /usr/lib64/cmake/Qt6/Qt6Config.cmake:167 (find_package) CMakeLists.txt:12 (find_package) -- Generating done
Fixed. Spec URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview-6.4.2-1.fc38.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* BSD 3-Clause License", "GNU Free Documentation License v1.3", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 3", "*No copyright* [generated file]", "BSD 3-Clause License", "GNU Library General Public License v2 or later". 156 files have unknown license. Detailed output of licensecheck in /home/ngompa/2165946-qt6-qtwebview/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/cmake/Qt6Qml/QmlPlugins [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/qt6/examples(qt6-qtserialbus-examples, qt6-qtnetworkauth- examples, qt6-qtwebengine-examples, qt6-qtsensors-examples, qt6-qtscxml-examples, qt6-qtserialport-examples, qt6-qt3d-examples, qt6-qtcharts-examples, qt6-qtbase-examples, qt6-qtvirtualkeyboard- examples, qt6-qtpositioning-examples, qt6-qtwebsockets-examples, qt6-qtconnectivity-examples, qt6-qtmultimedia-examples, qt6-qtdeclarative-examples, qt6-qtdatavis3d-examples, qt6-qttools- examples, qt6-qtsvg-examples, qt6-qtquick3d-examples, qt6-qtwebchannel-examples, qt6-qtremoteobjects-examples) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qt6-qtwebview-6.4.2-1.fc38.x86_64.rpm qt6-qtwebview-devel-6.4.2-1.fc38.x86_64.rpm qt6-qtwebview-examples-6.4.2-1.fc38.x86_64.rpm qt6-qtwebview-debuginfo-6.4.2-1.fc38.x86_64.rpm qt6-qtwebview-debugsource-6.4.2-1.fc38.x86_64.rpm qt6-qtwebview-6.4.2-1.fc38.src.rpm =========================================================================================================== rpmlint session starts =========================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp67xw2qca')] checks: 31, packages: 6 qt6-qtwebview.x86_64: W: no-documentation qt6-qtwebview-devel.x86_64: W: no-documentation qt6-qtwebview-examples.x86_64: W: no-documentation qt6-qtwebview-devel.x86_64: W: files-duplicate /usr/lib64/cmake/Qt6WebViewQuick/Qt6WebViewQuickConfigVersionImpl.cmake /usr/lib64/cmake/Qt6Qml/QmlPlugins/Qt6qtwebviewquickpluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6WebView/Qt6QWebEngineWebViewPluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6WebView/Qt6WebViewConfigVersionImpl.cmake qt6-qtwebview.src: E: description-line-too-long Qt WebView provides a way to display web content in a QML application without necessarily qt6-qtwebview.x86_64: E: description-line-too-long Qt WebView provides a way to display web content in a QML application without necessarily ============================================================================ 6 packages and 0 specfiles checked; 2 errors, 4 warnings, 2 badness; has taken 0.7 s ============================================================================ Rpmlint (debuginfo) ------------------- Checking: qt6-qtwebview-examples-debuginfo-6.4.2-1.fc38.x86_64.rpm qt6-qtwebview-debuginfo-6.4.2-1.fc38.x86_64.rpm =========================================================================================================== rpmlint session starts =========================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgk4hf384')] checks: 31, packages: 2 ============================================================================ 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ============================================================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 qt6-qtwebview-devel.x86_64: W: no-documentation qt6-qtwebview-examples.x86_64: W: no-documentation qt6-qtwebview.x86_64: W: no-documentation qt6-qtwebview-devel.x86_64: W: files-duplicate /usr/lib64/cmake/Qt6WebViewQuick/Qt6WebViewQuickConfigVersionImpl.cmake /usr/lib64/cmake/Qt6Qml/QmlPlugins/Qt6qtwebviewquickpluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6WebView/Qt6QWebEngineWebViewPluginConfigVersionImpl.cmake:/usr/lib64/cmake/Qt6WebView/Qt6WebViewConfigVersionImpl.cmake qt6-qtwebview.x86_64: E: description-line-too-long Qt WebView provides a way to display web content in a QML application without necessarily 6 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 1.7 s Unversioned so-files -------------------- qt6-qtwebview: /usr/lib64/qt6/plugins/webview/libqtwebview_webengine.so qt6-qtwebview: /usr/lib64/qt6/qml/QtWebView/libqtwebviewquickplugin.so Source checksums ---------------- https://download.qt.io/official_releases/qt/6.4/6.4.2/submodules/qtwebview-everywhere-src-6.4.2.tar.xz : CHECKSUM(SHA256) this package : a642961415c153c6fbf2c8adfebe9d53653116af79c32ebdb06be0c56fb2f372 CHECKSUM(SHA256) upstream package : a642961415c153c6fbf2c8adfebe9d53653116af79c32ebdb06be0c56fb2f372 Requires -------- qt6-qtwebview (rpmlib, GLIBC filtered): libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.4)(64bit) libQt6Core.so.6(Qt_6_PRIVATE_API)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Qml.so.6()(64bit) libQt6Quick.so.6()(64bit) libQt6WebEngineCore.so.6()(64bit) libQt6WebEngineQuick.so.6()(64bit) libQt6WebView.so.6()(64bit) libQt6WebViewQuick.so.6()(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt6-qtbase(x86-64) rtld(GNU_HASH) qt6-qtwebview-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libQt6WebView.so.6()(64bit) libQt6WebViewQuick.so.6()(64bit) pkgconfig(Qt6Core) pkgconfig(Qt6Gui) pkgconfig(Qt6OpenGL) pkgconfig(Qt6QmlModels) pkgconfig(Qt6Quick) qt6-qtbase-devel(x86-64) qt6-qtdeclarative-devel(x86-64) qt6-qtwebview(x86-64) qt6-qtwebview-examples (rpmlib, GLIBC filtered): libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.4)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Qml.so.6()(64bit) libQt6WebView.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt6-qtwebview(x86-64) rtld(GNU_HASH) qt6-qtwebview-debuginfo (rpmlib, GLIBC filtered): qt6-qtwebview-debugsource (rpmlib, GLIBC filtered): Provides -------- qt6-qtwebview: libQt6WebView.so.6()(64bit) libQt6WebViewQuick.so.6()(64bit) libqtwebview_webengine.so()(64bit) libqtwebviewquickplugin.so()(64bit) qt6-qtwebview qt6-qtwebview(x86-64) qt6-qtwebview-devel: cmake(Qt6QWebEngineWebViewPlugin) cmake(Qt6WebView) cmake(Qt6WebViewQuick) cmake(Qt6qtwebviewquickplugin) cmake(QtWebViewTests) cmake(qt6qtwebviewquickplugin) cmake(qt6qwebenginewebviewplugin) cmake(qt6webview) cmake(qt6webviewquick) cmake(qtwebviewtests) pkgconfig(Qt6WebView) pkgconfig(Qt6WebViewQuick) qt6-qtwebview-devel qt6-qtwebview-devel(x86-64) qt6-qtwebview-examples: qt6-qtwebview-examples qt6-qtwebview-examples(x86-64) qt6-qtwebview-debuginfo: debuginfo(build-id) libQt6WebView.so.6.4.2-6.4.2-1.fc38.x86_64.debug()(64bit) libQt6WebViewQuick.so.6.4.2-6.4.2-1.fc38.x86_64.debug()(64bit) libqtwebview_webengine.so-6.4.2-1.fc38.x86_64.debug()(64bit) libqtwebviewquickplugin.so-6.4.2-1.fc38.x86_64.debug()(64bit) qt6-qtwebview-debuginfo qt6-qtwebview-debuginfo(x86-64) qt6-qtwebview-debugsource: qt6-qtwebview-debugsource qt6-qtwebview-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2165946 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: PHP, Haskell, Ocaml, Java, Perl, SugarActivity, fonts, Python, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Also note that your BR: ninja-build isn't being used, since you're not passing in "-GNinja" to cmake.
(In reply to Neal Gompa from comment #5) > Also note that your BR: ninja-build isn't being used, since you're not > passing in "-GNinja" to cmake. From macros.qt6: >%_qt6_build_tool ninja > >%if "%_qt6_build_tool" == "ninja" \ > -GNinja \\\ >%else \ > -G"Unix Makefiles" \\\ >%endif \
>[!]: Package must own all directories that it creates. > Note: Directories without known owners: > /usr/lib64/cmake/Qt6Qml/QmlPlugins This should be fixed in qt6-qtdeclarative. > [!]: Package does not own files or directories owned by other packages. Fixed. > qt6-qtwebview.x86_64: E: description-line-too-long Qt WebView provides a way to display web content in a QML application without necessarily Fixed. Spec URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6-qtwebview/qt6-qtwebview-6.4.2-1.fc38.src.rpm
> %{_qt6_libdir}/libQt6WebView.so.6* > %{_qt6_libdir}/libQt6WebViewQuick.so.6* The soname glob isn't quite right, it should be "6{,.*}". Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files But this can be fixed on import. Everything else is good, so... PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtwebview
Package is now in repositories, closing review.