Bug 2166935 - Review Request: rubygem-redis-client - Simple low-level client for Redis 6+
Summary: Review Request: rubygem-redis-client - Simple low-level client for Redis 6+
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jarek Prokop
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2120331
TreeView+ depends on / blocked
 
Reported: 2023-02-03 14:58 UTC by Vít Ondruch
Modified: 2023-02-06 16:05 UTC (History)
2 users (show)

Fixed In Version: rubygem-redis-client-0.12.1-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-06 16:05:28 UTC
Type: ---
Embargoed:
jprokop: fedora-review+

Attachments (Terms of Use)

Description Vít Ondruch 2023-02-03 14:58:52 UTC 
Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-redis-client.git/plain/rubygem-redis-client.spec?id=7374e333f072fa282ed0e2dcc4b821424a3a584c
SRPM URL: https://people.redhat.com/vondruch/rubygem-redis-client-0.12.1-1.fc38.src.rpm
Description: Simple low-level client for Redis 6+.
Fedora Account System Username: vondruch
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=97049963
Comment 1 Vít Ondruch 2023-02-03 14:59:35 UTC 
Just FTR, this is require by rubygem-redis now:

https://github.com/redis/redis-rb/blob/6dbbc94e48c62ae3607c3a2796b49878dd03c5f9/redis.gemspec#L48
Comment 2 Jakub Kadlčík 2023-02-03 15:06:02 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5434995
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2166935-rubygem-redis-client/fedora-rawhide-x86_64/05434995-rubygem-redis-client/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
Comment 3 Jarek Prokop 2023-02-03 18:28:29 UTC 
LGTM. Simple package, no big surprises.

Mock OK,
copr OK,
spec is sane,
license is OK,
RPM is installable,
simple `ruby -e 'require "redis-client"; p RedisClient'` smoke test OK,
gem2rpm template was used so pretty standard.

Not going to block import on this, but consider using `git -C redis-client archive ...` instead of `git clone ... && cd ...` for tests checkout.
It is personally more comfortable in the update experience I had with similar packages that do not ship the test suite.

Also for hiredis and toxiproxi tests we need gems of those names for the test, right? Not sure from the TODO what kind of work is needed.
Comment 4 Vít Ondruch 2023-02-06 10:40:38 UTC 
(In reply to Jarek Prokop from comment #3)
> Also for hiredis and toxiproxi tests we need gems of those names for the
> test, right? Not sure from the TODO what kind of work is needed.

Toxi proxy would need the (Go) server + gem. A have not explored Hiredis that much TBH, but I don't consider it that important (yet).

Thx for a review.
Comment 5 Fedora Admin user for bugzilla script actions 2023-02-06 10:45:09 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-redis-client
Note You need to log in before you can comment on or make changes to this bug.