Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-redis-client.git/plain/rubygem-redis-client.spec?id=7374e333f072fa282ed0e2dcc4b821424a3a584c SRPM URL: https://people.redhat.com/vondruch/rubygem-redis-client-0.12.1-1.fc38.src.rpm Description: Simple low-level client for Redis 6+. Fedora Account System Username: vondruch Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=97049963
Just FTR, this is require by rubygem-redis now: https://github.com/redis/redis-rb/blob/6dbbc94e48c62ae3607c3a2796b49878dd03c5f9/redis.gemspec#L48
Copr build: https://copr.fedorainfracloud.org/coprs/build/5434995 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2166935-rubygem-redis-client/fedora-rawhide-x86_64/05434995-rubygem-redis-client/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
LGTM. Simple package, no big surprises. Mock OK, copr OK, spec is sane, license is OK, RPM is installable, simple `ruby -e 'require "redis-client"; p RedisClient'` smoke test OK, gem2rpm template was used so pretty standard. Not going to block import on this, but consider using `git -C redis-client archive ...` instead of `git clone ... && cd ...` for tests checkout. It is personally more comfortable in the update experience I had with similar packages that do not ship the test suite. Also for hiredis and toxiproxi tests we need gems of those names for the test, right? Not sure from the TODO what kind of work is needed.
(In reply to Jarek Prokop from comment #3) > Also for hiredis and toxiproxi tests we need gems of those names for the > test, right? Not sure from the TODO what kind of work is needed. Toxi proxy would need the (Go) server + gem. A have not explored Hiredis that much TBH, but I don't consider it that important (yet). Thx for a review.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-redis-client