Bug 2167167 - Review Request: budgie-desktop-defaults - Budgie Desktop Defaults for Fedora
Summary: Review Request: budgie-desktop-defaults - Budgie Desktop Defaults for Fedora
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2166007
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-05 11:09 UTC by Joshua Strobl
Modified: 2023-02-05 13:02 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-05 13:02:07 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Joshua Strobl 2023-02-05 11:09:45 UTC 
Spec URL: https://raw.githubusercontent.com/JoshStrobl/fedpkg-review-packages/master/budgie-desktop-defaults.spec
SRPM URL: https://github.com/JoshStrobl/fedpkg-review-packages/raw/master/budgie-desktop-defaults-0.3-1.fc38.src.rpm
Description: Budgie Desktop Defaults for Fedora / Fedora Budgie Spin
Fedora Account System Username: joshstrobl
Comment 1 Neal Gompa 2023-02-05 12:15:07 UTC 
Taking this review.
Comment 2 Neal Gompa 2023-02-05 12:16:37 UTC 
This package doesn't install:

Error: 
 Problem: conflicting requests
  - nothing provides budgie-backgrounds needed by budgie-desktop-defaults-0.3-1.fc38.noarch
Comment 3 Joshua Strobl 2023-02-05 12:20:47 UTC 
Hmm, it should be in rawhide by now. Would there be any reason for a delay there given it is already even in testing in f37 and f36?
Comment 4 Joshua Strobl 2023-02-05 12:21:53 UTC 
https://bodhi.fedoraproject.org/updates/FEDORA-2023-53d3d52cc8 shows that it should be in f38 stable (or "submitted") to it.
Comment 5 Neal Gompa 2023-02-05 12:24:34 UTC 
Ah, I see, it's in Koji but not in a compose...

Review notes:

* Package naming is fine
* Package complies with packaging guidelines
* Package builds and installs
* No serious issues from rpmlint

Thus...

PACKAGE APPROVED.
Comment 6 Fedora Admin user for bugzilla script actions 2023-02-05 12:29:26 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/budgie-desktop-defaults
Comment 7 Joshua Strobl 2023-02-05 13:02:07 UTC 
This is now in Fedora rawhide, closing :) Thank you for the quick review / response!
Note You need to log in before you can comment on or make changes to this bug.