Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve-2.1.13-1.1.src.rpm Description: libSieve provides a library to interpret Sieve scripts, and to execute those scripts over a given set of messages. The return codes from the libSieve functions let your program know how to handle the message, and then it's up to you to make it so. libSieve makes no attempt to have knowledge of how SMTP, IMAP, or anything else work; just how to parse and deal with a buffer full of emails. The rest is up to you!
Is this your first package? Not able to see you in any existing package owner. If you are first time submitter then i can not officially review this package.
you need to correct SPEC. I got following rpmlint warnings on binary rpm W: libsieve incoherent-version-in-changelog 2.1.13-1.1.sc 2.1.13-1.1 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. ==> Remove .sc from Chnagelog W: libsieve devel-file-in-non-devel-package /usr/lib/libsieve.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. ==> .so files are part of -devel packages. W: libsieve one-line-command-in-%post /sbin/ldconfig You should use %post -p <command> instead of using: %post <command> It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command. ==>Use %post -p /sbin/ldconfig
> Is this your first package? Not able to see you in any existing package owner. > If you are first time submitter then i can not officially review this package. Yes, it's the first package I've submitted to FE.
Updated as requested in comment #2. Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve-2.1.13-2.src.rpm
Moving this package status from FE-REVIEW to FE-NEW.
Now its looking better. rpmlints are silent now. More (unofficial)review will do later on.
Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve-2.1.13-3.src.rpm * Mon Dec 11 2006 Bernard Johnson <bjohnson> - 2.1.13-3 - added repotag for anyone who may want to use it - move ldconfig calls to post and postun with -p - minor spec file cleanups
Bad URL for srpm. Try this instead. SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve-2.1.13-3.fc6.src.rpm
Well, * Why do you call autoconf while there is a original "configure" script? * Remove static archive (*.a) * Usually the dependency for the main package should be given with full version-release dependency. * Please specify the URL of SOURCE0 * Is %repotag needed? As least this is not needed for Fedora. * And.. I don't know, however are many files under www/ or rfc/ can be ignored?
(In reply to comment #9) > Well, > * Why do you call autoconf while there is a original > "configure" script? At one point I was using a newer release that did not have a configure script. I forgot to change it back. Fixed. > * Remove static archive (*.a) Fixed. > * Usually the dependency for the main package should be given > with full version-release dependency. Fixed. > * Please specify the URL of SOURCE0 Fixed. > * Is %repotag needed? As least this is not needed for > Fedora. No, at the moment it's for my convenience so I don't need two spec files for non-FE builds. > * And.. I don't know, however are many files under www/ or > rfc/ can be ignored? www files are the smarty templated files that are for the web pages hosted at sf.net. In my opinion the RFCs should not be included. rfc/README: These RFC's are copied here for convenience only! In no way does the libSieve project make any claims as to ownership, authorship or stewardship over these documents. Please do not make reference to this "mini-repository" in any way; rather, point to the home repository hosted by the IETF: http://www.ietf.org/internet-drafts/ Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve-2.1.13-4.fc6.src.rpm * Sat Jan 27 2007 Bernard Johnson <bjohnson> - 2.1.13-4 - add fully versioned dependency on main package for -devel - remove .a library from -devel - do not call autoconf, use configure file - direct download url for source0 - remove buildrequires for autoconf and m4
Well, * License - Some sources are not licensed under LGPL. + GPL sv_util/*print*.[hc] sv_util/xsize.h As GPL is more strict than LGPL, please modify the whole license of this package to GPL (not a blocker, however, would you tell upstream about this? License text is LGPL, however this package is surely GPL) * Timestamps - This package installs several header files, and in that case keeping timestamps on these files are preferred. For this package, -------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p" -------------------------------------------------- will keep timestamps. * Source: - It seems that the newest is 2.2.4.
Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve-2.2.4-1.fc6.src.rpm * Sun Jan 28 2007 Bernard Johnson <bjohnson> - 2.2.4-1 - 2.2.4 - change license to GPL based on https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216723#c11 - install files preserving timestamps
(In reply to comment #11) > * License > - Some sources are not licensed under LGPL. > + GPL > sv_util/*print*.[hc] > sv_util/xsize.h > > As GPL is more strict than LGPL, please modify > the whole license of this package to GPL > (not a blocker, however, would you tell upstream > about this? License text is LGPL, however this > package is surely GPL) I sent a message to the author. He's usually pretty responsive, so we'll see what he has to say.
Created attachment 146773 [details] Mock build log of libsieve-2.2.4-1.fc7 Mockbuild log of libsieve-2.2.4-1 on FC-devel i386. Fedora specific compilation flags are not passed. Please check how CFLAGS, etc are treated.
Created attachment 146783 [details] possible patch for cflags Would this patch be considered acceptable or do I need to fix autotools and regenerate everything?
(In reply to comment #15) > Created an attachment (id=146783) [edit] > possible patch for cflags > > Would this patch be considered acceptable or do I need to fix autotools and > regenerate everything? Well, we recommend _not_ to use autotool. Your patch is good, however, when I checked your patch, the following may be simpler. ---------------------------------------------------------- %prep %setup -q %{__sed} -i.cflags \ -e 's|^\(CFLAGS = -Wall\)|\1 @CFLAGS@|' \ `find . -name Makefile -or -name Makefile.in` ----------------------------------------------------------
(In reply to comment #16) > %{__sed} -i.cflags \ > -e 's|^\(CFLAGS = -Wall\)|\1 @CFLAGS@|' \ > `find . -name Makefile -or -name Makefile.in` That works for me. Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/libsieve-2.2.4-2.fc6.src.rpm * Mon Jan 29 2007 Bernard Johnson <bjohnson> - 2.2.4-2 - add note regarding why license tag is GPL - sed surgery on Makefile.in files so that CFLAGS is passed properly
Okay. * The issues for this package are all now fixed. * Your other package review requests or your pre-reviews seem to be of quality to a certain extent. ------------------------------------------------------- This package (libsieve) is APPROVED by me. ------------------------------------------------------- Please follow http://fedoraproject.org/wiki/Extras/Contributors . I will sponsor you when you do a procedure and I receive a mail which tells that you need a sponsor.
Removing NEEDSPONSOR as I am sponsoring now
Additional Branches: FC-5
Additional Branches: EL-4, EL-5
Additional Branches: EL-7
Package Change Request ====================== Package Name: libsieve New Branches: epel7 Owners: bjohnson
Git done (by process-git-requests).