Created attachment 1942532 [details]
volume group backup

Description of problem:
LVM metadata is broken if device_id is set and contains a double quote `"`

Version-Release number of selected component (if applicable):
LVM2 version 2.03.16(2) (2022-05-18): Wed Feb  1 16:46:42 2023

How reproducible:
- install Rocky/Alma Linux 9.1 on a Broadwell system with Intel i3-5010U CPU, 4 GB RAM and 32 GB Innodisk 2.5" SATA SSD 3MG2-P
- do minimal installation and use LVM for disk partitioning
- the volume group uses all available space and assigns 10 GB to the root partition so that there are still ~14 GB available space in the volume group:

	[root@localhost ~]# vgs
	  VG #PV #LV #SN Attr   VSize   VFree  
	  rl   1   2   0 wz--n- <27.30g <14.41g

	[root@localhost ~]# lvs
	  LV   VG Attr       LSize  Pool Origin Data%  Meta%  Move Log Cpy%Sync Convert
	  root rl -wi-ao---- 10.00g                                                    
	  swap rl -wi-ao----  2.89g                                                    

	[root@localhost ~]# df -h
	  Filesystem           Size  Used Avail Use% Mounted on
	  devtmpfs             4.0M     0  4.0M   0% /dev
	  tmpfs                1.8G     0  1.8G   0% /dev/shm
	  tmpfs                713M  9.1M  704M   2% /run
	  /dev/mapper/rl-root   10G  1.1G  9.0G  11% /
	  /dev/sda2           1014M  214M  801M  22% /boot
	  /dev/sda1            599M  7.0M  592M   2% /boot/efi
	  tmpfs                357M     0  357M   0% /run/user/0

Steps to Reproduce:
Try to create a lvm snapshot of the root partiton:

	[root@localhost ~]# lvcreate -v -s rl/root -n root_snapshot -L 5G
	  Setting chunksize to 4.00 KiB.
	  Creating logical volume root_snapshot
	  Archiving volume group "rl" metadata (seqno 3).
	  Parse error at byte 401 (line 20): unexpected token
	  Error parsing metadata for VG rl.
	  Failed to write VG rl.

Actual results:
Failed to create the lvm snapshot.

Expected results:
lvm snapshot should be created.

Additional info:
Found while watching the lvm backup & archive files - in short / full backup is attached:

	# Generated by LVM2 version 2.03.16(2) (2022-05-18): Wed Feb  1 16:46:42 2023
	...
	rl {
		...
		physical_volumes {
			pv0 {
				id = "9iGP6J-AS0i-URS2-W5gV-t3pu-Fr1Z-Rj5myh"
				device = "/dev/sda3"	# Hint only

				device_id_type = "sys_wwid"
				device_id = "t10.ATA_____2.5"_SATA_SSD_3MG2-P____________________20161128AA0018230001"
				...
			}
		}
		logical_volumes {
			...
		}
	}