Bug 2167795 - Review Request: php-sebastian-code-unit2 - Collection of value objects that represent the PHP code units
Summary: Review Request: php-sebastian-code-unit2 - Collection of value objects that r...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/%{gh_owner}/%{gh_p...
Depends On:
Blocks: 2168112
TreeView+ depends on / blocked
Reported: 2023-02-07 14:58 UTC by Remi Collet
Modified: 2023-06-16 02:21 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2023-06-16 02:21:39 UTC
Type: ---
benson_muite: fedora-review+

Attachments (Terms of Use)

Description Remi Collet 2023-02-07 14:58:25 UTC
Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-code-unit2.git/plain/php-sebastian-code-unit2.spec?id=4beb380300c3bb1954166199c9d00908b2895245
SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-code-unit2-2.0.0-1.remi.src.rpm
Collection of value objects that represent the PHP code units.

Fedora Account System Username: remi


for phpunit10

previous review:
bug #1820478 for php-sebastian-code-unit

Comment 1 Jakub Kadlčík 2023-02-07 15:06:29 UTC
Copr build:

Review template:

Please take a look if any issues were found.

This comment was created by the fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Benson Muite 2023-06-06 14:37:46 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
     BSD 3-Clause License". 48 files have unknown license. Detailed output
     of licensecheck in /home/fedora/php-reviews2/2167795-php-sebastian-
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/php/SebastianBergmann(php-phpunit-php-file-iterator2, php-
     phpunit-php-invoker3, php-phpunit-php-text-template2, php-phpunit-php-
     token-stream3, php-sebastian-complexity, php-sebastian-diff4, php-
     sebastian-cli-parser, php-phpunit-php-token-stream2, php-sebastian-
     environment4, php-sebastian-global-state2, php-sebastian-finder-
     facade2, php-phpunit-php-timer5, php-phpunit-FinderFacade, php-
     phpunit-git, php-phpunit-php-token-stream4, php-sebastian-code-unit-
     reverse-lookup, php-phpunit-environment, php-phpunit-Version, php-
     sebastian-object-reflector, php-sebastian-object-reflector2, php-
     sebastian-environment5, php-sebastian-recursion-context, php-
     sebastian-recursion-context4, php-sebastian-recursion-context3, php-
     phpunit-php-timer3, php-sebastian-global-state, php-phpunit-php-
     timer2, php-sebastian-resource-operations2, php-sebastian-type, php-
     sebastian-lines-of-code, php-sebastian-resource-operations3, php-
     sebastian-diff3, php-phpunit-diff, php-sebastian-version3, php-
     phpunit-php-file-iterator3, php-phpunit-php-invoker2, php-sebastian-
     resource-operations, php-phpunit-PHPUnit-SkeletonGenerator, php-
     sebastian-code-unit, php-sebastian-code-unit-reverse-lookup2, php-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

[x]: Run phpci static analyze on all php files.
     Note: 7.0.0@7b05300 static analyze results in /home/fedora/php-

Checking: php-sebastian-code-unit2-2.0.0-1.fc39.noarch.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
rpmlintrc: [PosixPath('/tmp/tmpfj84fs9t')]
checks: 31, packages: 2

php-sebastian-code-unit2.spec: W: invalid-url Source0: php-sebastian-code-unit2-2.0.0-a81fee9.tgz
 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 

Rpmlint (installed packages)
============================ rpmlint session starts ============================
rpmlint: 2.4.0
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s 

php-sebastian-code-unit2 (rpmlib, GLIBC filtered):


Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2167795
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, PHP
Disabled plugins: SugarActivity, Ocaml, fonts, C/C++, Perl, Haskell, Java, Python, R

a) Builds on all architectures:
b) Tests require phpunit10 so conditionally enabled.

Comment 3 Fedora Admin user for bugzilla script actions 2023-06-07 13:46:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-sebastian-code-unit2

Comment 5 Fedora Update System 2023-06-07 13:56:14 UTC
FEDORA-2023-9d9e858271 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9d9e858271

Comment 6 Fedora Update System 2023-06-08 01:44:36 UTC
FEDORA-2023-9d9e858271 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9d9e858271 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9d9e858271

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-06-16 02:21:39 UTC
FEDORA-2023-9d9e858271 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.