Spec URL: https://yselkowitz.fedorapeople.org/libcuefile.spec SRPM URL: https://yselkowitz.fedorapeople.org/libcuefile-0-0.1.20110810svn475.fc38.src.rpm Description: CUE file library used by Musepack utilities and libraries Fedora Account System Username: yselkowitz
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later". 21 files have unknown license. Detailed output of licensecheck in /home/benson/Projects/FedoraPackaging/reviews/libcuefile/2167841-libcuefile/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [?]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://files.musepack.net/source/libcuefile_r475.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libcuefile-0-0.1.20110810svn475.fc38.x86_64.rpm libcuefile-devel-0-0.1.20110810svn475.fc38.x86_64.rpm libcuefile-debuginfo-0-0.1.20110810svn475.fc38.x86_64.rpm libcuefile-debugsource-0-0.1.20110810svn475.fc38.x86_64.rpm libcuefile-0-0.1.20110810svn475.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpku6xa07n')] checks: 31, packages: 5 libcuefile.x86_64: E: incorrect-fsf-address /usr/share/licenses/libcuefile/COPYING 5 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 4.0 s Rpmlint (debuginfo) ------------------- Checking: libcuefile-debuginfo-0-0.1.20110810svn475.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpu9c9me89')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 libcuefile.x86_64: E: incorrect-fsf-address /usr/share/licenses/libcuefile/COPYING 4 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 3.2 s Requires -------- libcuefile (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) libcuefile-devel (rpmlib, GLIBC filtered): libcuefile(x86-64) libcuefile.so.0()(64bit) libcuefile-debuginfo (rpmlib, GLIBC filtered): libcuefile-debugsource (rpmlib, GLIBC filtered): Provides -------- libcuefile: libcuefile libcuefile(x86-64) libcuefile.so.0()(64bit) libcuefile-devel: libcuefile-devel libcuefile-devel(x86-64) libcuefile-debuginfo: debuginfo(build-id) libcuefile-debuginfo libcuefile-debuginfo(x86-64) libcuefile.so.0.0.0-0-0.1.20110810svn475.fc38.x86_64.debug()(64bit) libcuefile-debugsource: libcuefile-debugsource libcuefile-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2167841 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: R, SugarActivity, Perl, Ocaml, Ruby, Python, fonts, Haskell, Java, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Builds on all architectures https://copr.fedorainfracloud.org/coprs/build/5502953 b) Can you add sed to BuildRequires c) The files src/cue_parse.c src/cue_parse.h src/toc_parse.c src/toc_parse.h are GPL2 or later, update License section to indicate GPL-2.0-only AND GPL-2.0-or-later d) Check if upstream will add a SONAME e) To preserve timestamps use cp -p -v include/cuetools/*.h %{buildroot}%{_includedir}/cuetools/ instead of cp -v include/cuetools/*.h %{buildroot}%{_includedir}/cuetools/ f) There is another cuetools package at https://github.com/gchudov/cuetools.net g) Very similar package: https://github.com/svend/cuetools https://packages.fedoraproject.org/pkgs/cuetools/cuetools/ Could this be used instead?
> Comments: > a) Builds on all architectures > https://copr.fedorainfracloud.org/coprs/build/5502953 > b) Can you add sed to BuildRequires Strictly speaking it's not necessary, but I'll add it. > c) The files > src/cue_parse.c > src/cue_parse.h > src/toc_parse.c > src/toc_parse.h > are GPL2 or later, update License section to indicate > GPL-2.0-only AND GPL-2.0-or-later These are bison-generated parsers, and as such fall under a GPL exception. I'll use a WITH statement here instead. > d) Check if upstream will add a SONAME Upstream is stagnant, there hasn't been a release in years, and the only expected consumer is another package from the same project. > e) To preserve timestamps use > cp -p -v include/cuetools/*.h %{buildroot}%{_includedir}/cuetools/ > instead of > cp -v include/cuetools/*.h %{buildroot}%{_includedir}/cuetools/ This was copied from libreplaygain, another library from the same project; please report this there. I'll use install instead. > f) There is another cuetools package at > https://github.com/gchudov/cuetools.net That's .NET/C#, completely unrelated to this. > g) Very similar package: > https://github.com/svend/cuetools > https://packages.fedoraproject.org/pkgs/cuetools/cuetools/ > Could this be used instead? That is the original sources from which libcuefile was forked, but the library there was treated as a convenience library (used in tree, not installed as a system library). As such, they do not conflict. This version is what musepack tools expect to use, and they have modified it somewhat to meet their specific needs.
Spec URL: https://yselkowitz.fedorapeople.org/libcuefile.spec SRPM URL: https://yselkowitz.fedorapeople.org/libcuefile-0-0.1.20110810svn475.fc39.src.rpm Description: CUE file library used by Musepack utilities and libraries Fedora Account System Username: yselkowitz
Are you planning on continuing this review?
Thanks for the update. Yes. Another couple days if that is ok.
Are you still planning on continuing this review?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later". 21 files have unknown license. Detailed output of licensecheck in /home/fedora/2167841-libcuefile/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://files.musepack.net/source/libcuefile_r475.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libcuefile-0-0.1.20110810svn475.fc39.aarch64.rpm libcuefile-devel-0-0.1.20110810svn475.fc39.aarch64.rpm libcuefile-debuginfo-0-0.1.20110810svn475.fc39.aarch64.rpm libcuefile-debugsource-0-0.1.20110810svn475.fc39.aarch64.rpm libcuefile-0-0.1.20110810svn475.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplqyc9vxf')] checks: 31, packages: 5 libcuefile.aarch64: E: incorrect-fsf-address /usr/share/licenses/libcuefile/COPYING 5 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.8 s Rpmlint (debuginfo) ------------------- Checking: libcuefile-debuginfo-0-0.1.20110810svn475.fc39.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprbex1yhb')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 libcuefile.aarch64: E: incorrect-fsf-address /usr/share/licenses/libcuefile/COPYING 4 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.9 s Requires -------- libcuefile (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) libcuefile-devel (rpmlib, GLIBC filtered): libcuefile(aarch-64) libcuefile.so.0()(64bit) libcuefile-debuginfo (rpmlib, GLIBC filtered): libcuefile-debugsource (rpmlib, GLIBC filtered): Provides -------- libcuefile: libcuefile libcuefile(aarch-64) libcuefile.so.0()(64bit) libcuefile-devel: libcuefile-devel libcuefile-devel(aarch-64) libcuefile-debuginfo: debuginfo(build-id) libcuefile-debuginfo libcuefile-debuginfo(aarch-64) libcuefile.so.0.0.0-0-0.1.20110810svn475.fc39.aarch64.debug()(64bit) libcuefile-debugsource: libcuefile-debugsource libcuefile-debugsource(aarch-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2167841 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, Java, SugarActivity, fonts, PHP, Perl, Haskell, R, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Header files seem to have timestamps from the date the srpm was made, not 18 June 2011 from the archive file. Not sure if it is possible to fix this, but not a blocker. b) Fedora review cannot download the file from http://files.musepack.net/source/libcuefile_r475.tar.gz but wget seems to work. c) Is it possible to add `Provides: bundled(cuetools)` to the spec file? See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
> a) Header files seem to have timestamps from the date the srpm was made, not > 18 June 2011 from the archive file. > Not sure if it is possible to fix this, but not a blocker. That's probably a result of the chmod 0644 in %prep. > b) Fedora review cannot download the file from > http://files.musepack.net/source/libcuefile_r475.tar.gz but > wget seems to work. Unfortunately the website has not been updated in years. > c) Is it possible to add `Provides: bundled(cuetools)` to the spec file? See > https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling If anything, it's the other way around: cuetools should have a bundled(libcuefile).
Ok. Approved. Thanks for your patience.
The Pagure repository was created at https://src.fedoraproject.org/rpms/libcuefile