Bug 2168258 - saving alternative content source is possible, even if IP instead of fqdn is specified and red warning is present
Summary: saving alternative content source is possible, even if IP instead of fqdn is ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Alternate Content Sources
Version: 6.13.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: 6.13.0
Assignee: Ian Ballou
QA Contact: Chris Roberts
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-08 15:24 UTC by Stefan Nemeth
Modified: 2023-08-03 17:35 UTC (History)
4 users (show)

Fixed In Version: tfm-rubygem-katello-4.7.0.12-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-03 13:25:08 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
altcontentsource (82.16 KB, image/png)
2023-02-08 15:24 UTC, Stefan Nemeth 		no flags Details
screenshot showing acs working with ip (96.39 KB, image/png)
2023-03-07 17:09 UTC, Chris Roberts 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 36074 0 Normal Closed Saving RHUI alternate content source with a malformed Base URL is possible 2023-02-20 21:53:59 UTC
Red Hat Issue Tracker SAT-15776 0 None None None 2023-02-09 15:16:42 UTC
Red Hat Product Errata RHSA-2023:2097 0 None None None 2023-05-03 13:25:23 UTC

Description Stefan Nemeth 2023-02-08 15:24:15 UTC 
Created attachment 1942911 [details]
altcontentsource

Description of problem:

when adding alternative content source, it is possible to save it even, if baseurl path is red, if IP address instead of fqdn is specified in path. Which is fine. However valid IP address should be a option along with fqdn. 

There are deployments without DNS
Also not-having DNS as single point of failure for alternative content source, can be good practice.  

Version-Release number of selected component (if applicable):


How reproducible:

100%

Steps to Reproduce:
1.create new content source
2.as a path https://10.37.195.233./pulp/content/ instead of https://rhui-server.example.com/pulp/content
3.next

Actual results:

Red warning appears, yet it allows to save the content source

Expected results:

Valid IP shows as green as well as valid fqdn. 

Additional info:

If back button is pressed, and than again next, red warning does not appear
Comment 1 Ian Ballou 2023-02-09 21:27:08 UTC 
Clarification: the red flag is not due to the IP address, it's due to the extra '/' at the end. We don't validate anything other than that http or https is there and that at the end there us /pulp/content.

The main issue is that we allow the user to continue if the URL is malformed. If this is fixed, the issue around returning to the page to see the red flag is missing will also be fixed.
Comment 2 Ian Ballou 2023-02-09 21:30:26 UTC 
Created redmine issue https://projects.theforeman.org/issues/36074 from this bug
Comment 3 Bryan Kearney 2023-02-10 00:03:44 UTC 
Upstream bug assigned to iballou
Comment 4 Bryan Kearney 2023-02-15 20:03:41 UTC 
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36074 has been resolved.
Comment 6 Chris Roberts 2023-03-07 17:09:13 UTC 
Created attachment 1948741 [details]
screenshot showing acs working with ip
Comment 7 Chris Roberts 2023-03-07 17:09:56 UTC 
Able to use IP instead of fqdn (see screenshot)

Moving to VERIFIED
Comment 10 errata-xmlrpc 2023-05-03 13:25:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.13 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2097
Note You need to log in before you can comment on or make changes to this bug.