2168728 – Uploading invalid datastream file while creating Tailoring File in Satellite WebUI should show some meaningful error message instead of 500 Internal Server Error

Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2168728 - Uploading invalid datastream file while creating Tailoring File in Satellite WebUI should show some meaningful error message instead of 500 Internal Server Error

Summary: Uploading invalid datastream file while creating Tailoring File in Satellite ...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Satellite
Classification:	Red Hat
Component:	SCAP Plugin
Sub Component:
Version:	6.13.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	medium
Target Milestone:	6.15.0
Assignee:	Adam Ruzicka
QA Contact:	Pavel Novotny
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2023-02-09 21:17 UTC by Jayant Bhatia
Modified:	2024-04-23 17:13 UTC (History)
CC List:	5 users (show)
Fixed In Version:	rubygem-foreman_openscap-7.1.0
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2024-04-23 17:13:35 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)
better error message for invalid tailoring file (24.38 KB, image/png) 2023-12-08 16:58 UTC, Pavel Novotny	no flags	Details
View All

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Issue Tracker	SAT-16261	0	None	None	None	2023-03-02 15:38:20 UTC
Red Hat Product Errata	RHSA-2024:2010	0	None	None	None	2024-04-23 17:13:36 UTC

Description Jayant Bhatia 2023-02-09 21:17:43 UTC

Description of problem:

The tailoring file creation fails when a invalid datastream file is uploaded which is a expected behavior. But a relevant meaningful message should get displayed to user instead of '500 Internal Server Error'


Version-Release number of selected component (if applicable): satellite-6.13.0-4.el8sat.noarch


How reproducible: Always


Steps to Reproduce:

1. Navigate to Satellite WebUI -> Hosts -> Tailoring Files -> New Tailoring File.

2. Enter the name and then browse and upload DataStream tailoring file which is not valid. Select the respective Organizations and Locations.

3. Hit submit.


Actual results: The Tailoring file cannot be created and it fails with below message. (Refer attached screen image)

       Oops, we're sorry but something went wrong 500 Internal Server Error


Expected results: Some meaningful message like "Invalid Datastream tailoring file" should be shown on screen instead of failure with 500 Internal Server Error.


Additional info: Uploading valid datastream tailoring file leads to successful creation. It would be great if the datastream file is validated when it is browsed and uploaded and shows the relevant message then and there instead of waiting for user to hit Submit.

Comment 1 Jayant Bhatia 2023-02-09 21:22:15 UTC

Created attachment 1943175 [details]
Error Shown To user

Comment 3 Jayant Bhatia 2023-02-09 21:27:53 UTC

This behavior is also seen in Satellite 6.12.

Comment 5 Brad Buckingham 2023-10-30 11:29:29 UTC

Bulk setting Target Milestone = 6.15.0 where sat-6.15.0+ is set.

Comment 6 Pavel Novotny 2023-12-08 16:57:48 UTC

Verified in Sat 6.15 snap 2:
satellite-6.15.0-1.el8sat.noarch
rubygem-foreman_openscap-7.1.0-1.el8sat.noarch

When providing an invalid tailoring datastream file, the page no longer shows the infamous HTTP 500 page "Oops, we're sorry but something went wrong 500 Internal Server Error",
but shows more informative error message right next to the Scap File field, like "Error occurred: Failed to parse profiles". See the attached screenshot for details.

Comment 7 Pavel Novotny 2023-12-08 16:58:56 UTC

Created attachment 2003325 [details]
better error message for invalid tailoring file

Comment 10 errata-xmlrpc 2024-04-23 17:13:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010

Note You need to log in before you can comment on or make changes to this bug.