Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05512628-python-rapidfuzz/python-rapidfuzz.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05512628-python-rapidfuzz/python-rapidfuzz-2.13.7-1.fc38.src.rpm Description: RapidFuzz is a fast string matching library for Python and C++, which is using the string similarity calculations from FuzzyWuzzy. However there are a couple of aspects that set RapidFuzz apart from FuzzyWuzzy: - It is MIT licensed so it can be used whichever License you might want to choose for your project, while you're forced to adopt the GPL license when using FuzzyWuzzy - It provides many string_metrics like hamming or jaro_winkler, which are not included in FuzzyWuzzy - It is mostly written in C++ and on top of this comes with a lot of Algorithmic improvements to make string matching even faster, while still providing the same results. For detailed benchmarks check the documentation - Fixes multiple bugs in the partial_ratio implementation} Fedora Account System Username: thrnciar
Starting with question marks as I'm not familiar with arch packages. Fedora Review points out this one: - Header files in -devel subpackage, if present. Note: python3-rapidfuzz : /usr/lib64/python3.11/site- packages/rapidfuzz/rapidfuzz.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages I don't know how to evaluate those points. C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Rpmlint's output: Rpmlint ------- Checking: python3-rapidfuzz-2.13.7-1.fc39.x86_64.rpm python-rapidfuzz-debugsource-2.13.7-1.fc39.x86_64.rpm python-rapidfuzz-2.13.7-1.fc39.src.rpm ================================================ rpmlint session starts =============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4lcznls9')] checks: 31, packages: 3 python3-rapidfuzz.x86_64: W: files-duplicate /usr/lib64/python3.11/site-packages/rapidfuzz/distance/LCSseq.pyi /usr/lib64/python3.11/site-packages/rapidfuzz/distance/Hamming.pyi:/usr/lib64/python3.11/site-packages/rapidfuzz/distance/Indel.pyi python3-rapidfuzz.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.11/site-packages/rapidfuzz/rapidfuzz.h python-rapidfuzz.src: E: description-line-too-long RapidFuzz is a fast string matching library for Python and C++, which is using the string similarity python-rapidfuzz.src: E: description-line-too-long calculations from FuzzyWuzzy. However there are a couple of aspects that set RapidFuzz apart from FuzzyWuzzy: python-rapidfuzz.src: E: description-line-too-long - It is MIT licensed so it can be used whichever License you might want to choose for your project, while you're python-rapidfuzz.src: E: description-line-too-long - It provides many string_metrics like hamming or jaro_winkler, which are not included in FuzzyWuzzy python-rapidfuzz.src: E: description-line-too-long - It is mostly written in C++ and on top of this comes with a lot of Algorithmic improvements to make string matching python-rapidfuzz.src: E: description-line-too-long even faster, while still providing the same results. For detailed benchmarks check the documentation python3-rapidfuzz.x86_64: E: description-line-too-long RapidFuzz is a fast string matching library for Python and C++, which is using the string similarity python3-rapidfuzz.x86_64: E: description-line-too-long calculations from FuzzyWuzzy. However there are a couple of aspects that set RapidFuzz apart from FuzzyWuzzy: python3-rapidfuzz.x86_64: E: description-line-too-long - It is MIT licensed so it can be used whichever License you might want to choose for your project, while you're python3-rapidfuzz.x86_64: E: description-line-too-long - It provides many string_metrics like hamming or jaro_winkler, which are not included in FuzzyWuzzy python3-rapidfuzz.x86_64: E: description-line-too-long - It is mostly written in C++ and on top of this comes with a lot of Algorithmic improvements to make string matching python3-rapidfuzz.x86_64: E: description-line-too-long even faster, while still providing the same results. For detailed benchmarks check the documentation ================ 3 packages and 0 specfiles checked; 12 errors, 2 warnings, 12 badness; has taken 1.1 s =============== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 python3-rapidfuzz.x86_64: W: files-duplicate /usr/lib64/python3.11/site-packages/rapidfuzz/distance/LCSseq.pyi /usr/lib64/python3.11/site-packages/rapidfuzz/distance/Hamming.pyi:/usr/lib64/python3.11/site-packages/rapidfuzz/distance/Indel.pyi python3-rapidfuzz.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.11/site-packages/rapidfuzz/rapidfuzz.h python3-rapidfuzz.x86_64: E: description-line-too-long RapidFuzz is a fast string matching library for Python and C++, which is using the string similarity python3-rapidfuzz.x86_64: E: description-line-too-long calculations from FuzzyWuzzy. However there are a couple of aspects that set RapidFuzz apart from FuzzyWuzzy: python3-rapidfuzz.x86_64: E: description-line-too-long - It is MIT licensed so it can be used whichever License you might want to choose for your project, while you're python3-rapidfuzz.x86_64: E: description-line-too-long - It provides many string_metrics like hamming or jaro_winkler, which are not included in FuzzyWuzzy python3-rapidfuzz.x86_64: E: description-line-too-long - It is mostly written in C++ and on top of this comes with a lot of Algorithmic improvements to make string matching python3-rapidfuzz.x86_64: E: description-line-too-long even faster, while still providing the same results. For detailed benchmarks check the documentation 2 packages and 0 specfiles checked; 6 errors, 2 warnings, 6 badness; has taken 0.3 s
`SKIPPED [1] tests/test_process.py:330: could not import 'pandas': No module named 'pandas'` There's a test skipped in the %check run - maybe pandas should be BuildRequired?
(In reply to Karolina Surma from comment #1) > Starting with question marks as I'm not familiar with arch packages. > > Fedora Review points out this one: > > - Header files in -devel subpackage, if present. > Note: python3-rapidfuzz : /usr/lib64/python3.11/site- > packages/rapidfuzz/rapidfuzz.h > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_devel_packages Is this file required for the package to function? If not, it should probably not be installed (that should be fixable upstream). If it is, it needs to stay. > I don't know how to evaluate those points. > > C/C++: > [ ]: Package does not contain kernel modules. Unlikely. Kernel modules don't live in %{python3_sitearch}. > [ ]: Package contains no static executables. Check if the package BRs any static libraris. > [ ]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. If the .so file is a Python extension module in %{python3_sitearch}, this check is not relevant.
Is this rapidfuzz bundling https://src.fedoraproject.org/rpms/rapidfuzz-cpp/tree/rawhide or is it just a name collision?
> [ ]: Package contains no static executables. See also https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables
(In reply to Miro Hrončok from comment #4) > Is this rapidfuzz bundling > https://src.fedoraproject.org/rpms/rapidfuzz-cpp/tree/rawhide or is it just > a name collision? It looks so, that's the unpacked source (the built debugsource package contains them too) rapidfuzz-2.13.7/extern/rapidfuzz-cpp/ rapidfuzz-2.13.7/extern/rapidfuzz-cpp/CMakeLists.txt rapidfuzz-2.13.7/extern/rapidfuzz-cpp/LICENSE rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/ rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/ rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/CharSet.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/GrowingHashmap.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/Matrix.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/PatternMatchVector.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/Range.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/SplittedSentenceView.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/common.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/common_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/distance.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/intrinsics.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/simd.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/simd_avx2.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/simd_sse2.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/type_traits.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/details/types.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/ rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/DamerauLevenshtein.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/DamerauLevenshtein_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Hamming.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Hamming_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Indel.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Indel_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Jaro.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/JaroWinkler.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/JaroWinkler_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Jaro_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/LCSseq.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/LCSseq_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Levenshtein.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Levenshtein_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/OSA.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/OSA_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Postfix.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Postfix_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Prefix.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance/Prefix_impl.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/distance.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/fuzz.hpp rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/fuzz.impl rapidfuzz-2.13.7/extern/rapidfuzz-cpp/rapidfuzz/rapidfuzz_all.hpp
There's also Taskflow bundled in this package: https://src.fedoraproject.org/rpms/taskflow
Here is the updated spec file. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05533578-python-rapidfuzz/python-rapidfuzz.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05533578-python-rapidfuzz/python-rapidfuzz-2.13.7-1.fc38.src.rpm (In reply to Miro Hrončok from comment #3) > (In reply to Karolina Surma from comment #1) > > Starting with question marks as I'm not familiar with arch packages. > > > > Fedora Review points out this one: > > > > - Header files in -devel subpackage, if present. > > Note: python3-rapidfuzz : /usr/lib64/python3.11/site- > > packages/rapidfuzz/rapidfuzz.h > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/#_devel_packages > > Is this file required for the package to function? If not, it should > probably not be installed (that should be fixable upstream). If it is, it > needs to stay. > I believe it needs to stay. I've tried to remove it, but the tests failed with ModuleNotFoundError: No module named 'rapidfuzz.distance.metrics_cpp'.
> (In reply to Miro Hrončok from comment #3) > > (In reply to Karolina Surma from comment #1) > > > Starting with question marks as I'm not familiar with arch packages. > > > > > > Fedora Review points out this one: > > > > > > - Header files in -devel subpackage, if present. > > > Note: python3-rapidfuzz : /usr/lib64/python3.11/site- > > > packages/rapidfuzz/rapidfuzz.h > > > See: https://docs.fedoraproject.org/en-US/packaging- > > > guidelines/#_devel_packages > > > > Is this file required for the package to function? If not, it should > > probably not be installed (that should be fixable upstream). If it is, it > > needs to stay. > > > I believe it needs to stay. I've tried to remove it, but the tests failed > with ModuleNotFoundError: No module named 'rapidfuzz.distance.metrics_cpp'. How did you try to remove it? (If you deleted it before building the extension module, the ModuleNotFoundError is quite expected.)
> rm extern -rf Please don't remove with -f in spec files. If the folder is renamed (e.g. to external or 3rdparty) in the next release you will not notice.
> BuildRequires: cmake > BuildRequires: ninja-build If you need this, maybe the python3-scikit-build should require those? it already pulls in cmake.
Please package the [full] extra. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Extras """Python packages SHOULD have Provides for all extras the upstream project specifies"""
I've addressed all remarks above. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05534067-python-rapidfuzz/python-rapidfuzz.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05534067-python-rapidfuzz/python-rapidfuzz-2.13.7-1.fc38.src.rpm
I've added one more empty line before %prep section to improve the readability and link to the upstream PR wrt sedding out the header file. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05537093-python-rapidfuzz/python-rapidfuzz.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05537093-python-rapidfuzz/python-rapidfuzz-2.13.7-1.fc38.src.rpm
Updated spec file with -devel subpackage. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05545533-python-rapidfuzz/python-rapidfuzz.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05545533-python-rapidfuzz/python-rapidfuzz-2.13.7-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/5545563 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168858-python-rapidfuzz/fedora-rawhide-x86_64/05545563-python-rapidfuzz/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I follow the discussion on packaging mailing list which may change the ultimate direction of this package, but just the two notes regarding the latest package. 1) rapidfuzz.h and __init__.pxd are now present in both python3-rapidfuzz and python-rapidfuzz-devel, instead of just python-rapidfuzz-devel. pyproject-rpm-files say: "Note that %pyproject_save_files uses data from the RECORD file. If you wish to rename, remove or otherwise change the installed files of a package after %pyproject_install, %pyproject_save_files might break. If possible, remove/rename such files in %prep. If not possible, avoid using %pyproject_save_files or edit/replace %{pyproject_files}." - maybe it would be enough to modify %{pyproject_files} not to contain the two files? 2) From rpmlint: python3-rapidfuzz.x86_64: W: tag-in-description Requires: The Requires line was consumed by the Description (you can check it with `rpm -qi` on the built RPM).
(In reply to Karolina Surma from comment #17) > I follow the discussion on packaging mailing list which may change the > ultimate direction of this package, but just the two notes regarding the > latest package. > > 1) rapidfuzz.h and __init__.pxd are now present in both python3-rapidfuzz > and python-rapidfuzz-devel, instead of just python-rapidfuzz-devel. > > pyproject-rpm-files say: "Note that %pyproject_save_files uses data from the > RECORD file. If you wish to rename, remove or otherwise change the installed > files of a package after %pyproject_install, %pyproject_save_files might > break. If possible, remove/rename such files in %prep. If not possible, > avoid using %pyproject_save_files or edit/replace %{pyproject_files}." - > maybe it would be enough to modify %{pyproject_files} not to contain the two > files? The advice is for removing files completely. To move them to a different package, this should do: %files -n python3-rapidfuzz -f %{pyproject_files} %doc README.* %exclude %{python3_sitearch}/rapidfuzz/rapidfuzz.h %exclude %{python3_sitearch}/rapidfuzz/__init__.pxd %files -n python3-rapidfuzz-devel %{python3_sitearch}/rapidfuzz/rapidfuzz.h %{python3_sitearch}/rapidfuzz/__init__.pxd Also note that the devel package name should be python3-rapidfuzz-devel, not python-rapidfuzz-devel -- rule of thumb: it installs files to %{python3_sitearch}.
I've excluded .h and .pxd files from the main package and removed the requirement on -devel subpackage since cleo doesn't need it. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/05547861-python-rapidfuzz/python-rapidfuzz.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/05547861-python-rapidfuzz/python-rapidfuzz-2.13.7-1.fc39.src.rpm
Created attachment 1945201 [details] The .spec file difference from Copr build 5545563 to 5547942
Copr build: https://copr.fedorainfracloud.org/coprs/build/5547942 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168858-python-rapidfuzz/fedora-rawhide-x86_64/05547942-python-rapidfuzz/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I have one more question. The definition of the provided -static package looks exactly like the Packaging Guidelines define (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries): %package -n python3-rapidfuzz-devel Summary: Development files for the RapidFuzz library Provides: python3-rapidfuzz-static = %{version}-%{release} The Provides of the -devel package then look like this: $ rpm -qP python3-rapidfuzz-devel-2.13.7-1.fc39.x86_64.rpm python-rapidfuzz-devel = 2.13.7-1.fc39 python3-rapidfuzz-devel = 2.13.7-1.fc39 python3-rapidfuzz-devel(x86-64) = 2.13.7-1.fc39 python3-rapidfuzz-static = 2.13.7-1.fc39 python3.11-rapidfuzz-devel = 2.13.7-1.fc39 The provides for python3-rapidfuzz-static with the unversioned python and python 3.X are not generated. Should they be? The Python Guidelines say: "For any FOO, a package that provides python3-FOO SHOULD use %py_provides or an automatic generator to also provide python-FOO and python3.X-FOO, where X is the minor version of the interpreter." (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatic-unversioned-provides). Is it the case here too or is this unrelated?
I've removed the unnecessary Provides. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05552947-python-rapidfuzz/python-rapidfuzz.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-rapidfuzz/fedora-rawhide-x86_64/05552947-python-rapidfuzz/python-rapidfuzz-2.13.7-1.fc39.src.rpm
Created attachment 1945487 [details] The .spec file difference from Copr build 5547942 to 5553031
Copr build: https://copr.fedorainfracloud.org/coprs/build/5553031 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168858-python-rapidfuzz/fedora-rawhide-x86_64/05553031-python-rapidfuzz/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I ran a scratchbuild on Koji to check the other architectures when we were discussing the header file status and all green there. I think it's good now. Package APPROVED. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 117 files have unknown license. Detailed output of licensecheck in /home/ksurma/tmp/2168858-python- rapidfuzz/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-rapidfuzz , python3-rapidfuzz+full , python3-rapidfuzz-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Requires -------- python3-rapidfuzz (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) rtld(GNU_HASH) python3-rapidfuzz+full (rpmlib, GLIBC filtered): python(abi) python3-rapidfuzz python3.11dist(numpy) python3-rapidfuzz-devel (rpmlib, GLIBC filtered): python3-rapidfuzz(x86-64) python-rapidfuzz-debugsource (rpmlib, GLIBC filtered):
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rapidfuzz
*** Bug 2156257 has been marked as a duplicate of this bug. ***