Bug 216912 - Review Request: rtpproxy - A symmetric RTP proxy
Summary: Review Request: rtpproxy - A symmetric RTP proxy
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-11-22 17:14 UTC by Jeffrey C. Ollie
Modified: 2015-03-28 18:38 UTC (History)
1 user (show)

Fixed In Version: rtpproxy-2.0.0-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-04 02:11:22 UTC
Type: ---
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jeffrey C. Ollie 2006-11-22 17:14:29 UTC
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/rtpproxy-0.3-1.fc6.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/rtpproxy-0.3-1.fc6.src.rpm
Description:

This is a symmetric RTP proxy designed to be used in conjunction with
the SIP Express Router (SER) or any other SIP proxy capable of
rewriting SDP bodies in SIP messages that it processes.

Comment 1 Kevin Fenzi 2006-12-04 00:05:26 UTC
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
2a316f4854da4e8c8d358c623e5ffdb6  rtpproxy-0.3.tar.gz
2a316f4854da4e8c8d358c623e5ffdb6  rtpproxy-0.3.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
i386/x86_64 - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Is there anything aside from the including COPYING file to indicate
the license? I guess including that COPYING file might be enough, but there
is no mention anywhere in the code, web page or other files what the license is.
Perhaps you could report to upstream that they could be more explicit about the
license moving forward?

Otherwise I don't see any issues... this package is APPROVED. 

Don't forget to close this report NEXTRELEASE once it's been imported and built. 

Also, do consider reviewing another waiting package to try and spread out the
reviewer load. 

Comment 2 Jeffrey C. Ollie 2006-12-04 02:11:22 UTC
Thanks for the review... imported and build for development kicked off...

Comment 3 Jeffrey C. Ollie 2008-01-29 19:59:49 UTC
Package Change Request
======================
Package Name: rtpproxy
New Branches: EL-4 EL-5
Updated Fedora Owners: jcollie, peter
Updated EPEL Owners: jcollie, peter


Comment 4 Kevin Fenzi 2008-01-30 17:04:47 UTC
cvs done.

Comment 5 Peter Lemenkov 2015-03-10 15:33:04 UTC
Package Change Request
======================
Package Name: rtpproxy
New Branches: epel7
Owners: peter jcollie itamarjp

Comment 6 Gwyn Ciesla 2015-03-10 15:46:42 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2015-03-10 16:06:13 UTC
rtpproxy-2.0.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/rtpproxy-2.0.0-1.el7

Comment 8 Fedora Update System 2015-03-28 18:38:49 UTC
rtpproxy-2.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.